[Bug 45727] New: Quik 7: Regression with button bitmaps after 3.6 release - No any bitmap on the buttons in a messages window

https://bugs.winehq.org/show_bug.cgi?id=45727

Bug ID: 45727
           Summary: Quik 7: Regression with button bitmaps after 3.6
                    release - No any bitmap on the buttons in a messages
                    window
           Product: Wine
           Version: 3.14
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Overview:
   wine-3.14
   No any bitmap on the buttons in the messages window

Steps to Reproduce:
  Install:
  1) Download the app by link
http://arqatech.com/upload/iblock/68d/Quik_v7.19.0_ENG.exe
  2) wine Quik_v7.19.0_ENG.exe
  3) Click Next until end

Repoduce:
  1) Login is valid until 09/28/2018. I will update after this date. 
     User:U0127723
     Pass:02303
  2) Messages window is shown right after login.

Actual Result:
  No bitmaps on the buttons

Expected:
  Buttons with bitmaps

Regression testing:
  The result of the regression testing is:

05d4e4a23b06fd927bbe72ad4e5a864e9a8d842d is the first bad commit
commit 05d4e4a23b06fd927bbe72ad4e5a864e9a8d842d
Author: Zhiyi Zhang 
Date:   Tue Apr 3 09:10:57 2018 +0300

comctl32/button: Remove style checking when handling BM_SETIMAGE.

Signed-off-by: Zhiyi Zhang 
    Signed-off-by: Nikolay Sivov 
    Signed-off-by: Alexandre Julliard

:040000 040000 db5bf8e127fef8ea3f983f59a76e36acdc21d8ad
cf0088f4858e57ca74308e4fe63ac5ccda10d272 M    dlls

[Bug 45727] Quik 7: Regression with button bitmaps after 3.6 release - No any bitmap on the buttons in a messages window

https://bugs.winehq.org/show_bug.cgi?id=45727

--- Comment #1 from akw  ---
Created attachment 62155
  --> https://bugs.winehq.org/attachment.cgi?id=62155
A picture showing problem

[Bug 45727] Quik 7: Regression with button bitmaps after 3.6 release - No any bitmap on the buttons in a messages window

https://bugs.winehq.org/show_bug.cgi?id=45727

akw  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |05d4e4a23b06fd927bbe72ad4e5
                   |                            |a864e9a8d842d

[Bug 45727] Quik 7: Regression with button bitmaps after 3.6 release - No any bitmap on the buttons in a messages window

https://bugs.winehq.org/show_bug.cgi?id=45727

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #2 from Gijs Vermeulen  ---
Could you confirm that the patches attached to bug 45246 fix this issue as
well? That bug has the same regression SHA1.

[Bug 45727] Quik 7: Regression with button bitmaps after 3.6 release - No any bitmap on the buttons in a messages window

https://bugs.winehq.org/show_bug.cgi?id=45727

--- Comment #3 from akw  ---
Current version from git wine-3.14-295-ga1e0a02. The problem is still there.

Patches links from bug 45246
https://bugs.winehq.org/attachment.cgi?id=61523
https://bugs.winehq.org/attachment.cgi?id=61524
https://bugs.winehq.org/attachment.cgi?id=61525

I applied patches one by one by number in patch name . The button bitmaps
appeared after 2 patches https://bugs.winehq.org/attachment.cgi?id=61523 and
https://bugs.winehq.org/attachment.cgi?id=61524. And it still appears after all
3 applied patches.

Looks like that these patches fix the problem

[Bug 45727] Quik 7: Regression with button bitmaps after 3.6 release - No any bitmap on the buttons in a messages window

https://bugs.winehq.org/show_bug.cgi?id=45727

--- Comment #4 from Nikolay Sivov  ---
Please retest with current git, specifically
1f323f31d6311fe3c3a33f237583afe489325265.

[Bug 45727] Quik 7: Regression with button bitmaps after 3.6 release - No any bitmap on the buttons in a messages window

https://bugs.winehq.org/show_bug.cgi?id=45727

--- Comment #5 from akw  ---
last wine from git wine-3.15-46-gd99f682 with
1f323f31d6311fe3c3a33f237583afe489325265

All button bitmaps is shown. The regression is fixed

[Bug 45727] Quik 7: Regression with button bitmaps after 3.6 release - No any bitmap on the buttons in a messages window

https://bugs.winehq.org/show_bug.cgi?id=45727

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |1f323f31d6311fe3c3a33f23758
                   |                            |3afe489325265

--- Comment #6 from Nikolay Sivov  ---
Thanks for testing.

[Bug 45727] Quik 7: Regression with button bitmaps after 3.6 release - No any bitmap on the buttons in a messages window

https://bugs.winehq.org/show_bug.cgi?id=45727

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 3.16.