[Bug 25427] New: Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

Summary: Arcanum crashes in the main menu (when using hardware
                    acceleration)
           Product: Wine
           Version: 1.3.8
          Platform: x86
               URL: http://www.fileplanet.com/59649/50000/fileinfo/Arcanum
                    :-Of-Steamworks-&-Magick-Obscura-Demo
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=32364)
 --> (http://bugs.winehq.org/attachment.cgi?id=32364)
terminal output

Arcanum: Of Steamworks & Magick Obscura crashes in the main menu (without a
usable backtrace).
There's no crash if you start the game with the '-no3d' command line parameter. 
The game started without the issue, using hw. acceleration in Wine-1.3.6.

Bisecting revealed the following commit:

d3fd7b247b35d7c8c453afa2fc07e121ea75214b is the first bad commit
commit d3fd7b247b35d7c8c453afa2fc07e121ea75214b
Author: Henri Verbeet 
Date:   Thu Nov 11 12:39:18 2010 +0100

wined3d: Handle rendertargetlock_mode in surface_load_location().

:040000 040000 780aa9e2a2ad864aa99506bbc94945858f04c8fe
4f3ff593fb727990574ac015f6f7512ba8bd76f2 M    dlls

Author of the patch added to CC.
Link to the demo added to URL (255 MB download size)

Just let me know if you need a log with specific debug channels.

Fedora 14
Nvidia 7600 / driver 260.19.21

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

paulo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from paulo  2010-12-06 15:58:59 CST ---
I can confirm, one ubuntu 10.10, 86-64x, ati, with fglrx drivers. I remember
this didn't happen before too.

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #2 from paulo  2010-12-06 16:00:24 CST ---
And wine-1.3.8

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Austin English  2010-12-09 19:51:42 CST ---
Two users -> confirming.

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #4 from paulo  2010-12-12 08:37:02 CST ---
Still not fixed in wine 1.3.9

Forgot to say, i have a dual core.

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #5 from paulo  2010-12-14 20:05:37 CST ---
Mmmm. I tried to revert the patch from HEAD (1.3.9)

git revert d3fd7b247b35d7c8c453afa2fc07e121ea75214b

(it said something strange i probably should have had taken more attention to,
adding some files or something)

But it compiled.
After compiling it and running Arcanum.exe (regardless of the -no3d switch),
It gave this error before running the movies:
err:d3d:wined3d_unregister_window Window 0x40064 is not registered with
wined3d.

I had hoped to confirm this one way or the other, but i seem to have fucked up.

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #6 from paulo  2010-12-14 20:07:16 CST ---
the revert actually said this:

Finished one revert.
# Not currently on any branch.
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#    cam.cfg
#    dlls/Maketest.rules
#    dlls/actxprxy/actxprxy_servprov_i.c
#    dlls/d3dx9_36/asmshader.tab.c
#    dlls/d3dx9_36/asmshader.tab.h
#    dlls/d3dx9_36/asmshader.yy.c
#    dlls/winhelp.exe16
#    dlls/winoldap.mod16
#    dlls/wprocs.dll16
#    iv5play.exe
#    libs/wine/version-stamp
#    loader/wine-glibc
#    loader/wine-glibc-installed
#    loader/wine-kthread
#    loader/wine-kthread-installed
#    loader/wine-preloader-installed
#    loader/wine-pthread
#    loader/wine-pthread-installed
#    programs/clock/clock
#    programs/cmd/cmd
#    programs/cmdlgtst/cmdlgtst
#    programs/control/control
#    programs/eject/eject
#    programs/expand/expand
#    programs/explorer/explorer
#    programs/hh/hh
#    programs/icinfo/icinfo
#    programs/iexplore/iexplore
#    programs/msiexec/msiexec
#    programs/net/net
#    programs/notepad/notepad
#    programs/oleview/oleview
#    programs/progman/progman
#    programs/reg/reg
#    programs/regedit/regedit
#    programs/regsvr32/regsvr32
#    programs/rpcss/rpcss
#    programs/rundll32/rundll32
#    programs/secedit/secedit
#    programs/services/services
#    programs/spoolsv/spoolsv
#    programs/start/start
#    programs/svchost/svchost
#    programs/taskmgr/taskmgr
#    programs/uninstaller/uninstaller
#    programs/view/view
#    programs/wineapploader
#    programs/wineboot/wineboot
#    programs/winebrowser/winebrowser
#    programs/winecfg/winecfg
#    programs/wineconsole/wineconsole
#    programs/winedbg/winedbg
#    programs/winedevice/winedevice
#    programs/winefile/winefile
#    programs/winemenubuilder/winemenubuilder
#    programs/winemine/winemine
#    programs/winepath/winepath
#    programs/winetest/tests.rc
#    programs/winetest/winetest
#    programs/winevdm/winevdm
#    programs/winhlp32/winhlp32
#    programs/winver/winver
#    programs/wordpad/wordpad
#    programs/write/write
#    programs/xcopy/xcopy
#    tools/wineprefixcreate
#    tools/wineprefixcreate.man
nothing added to commit but untracked files present (use "git add" to track)

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #7 from GyB  2010-12-14 21:32:28 CST ---
The commit cannot be reverted cleanly on Wine-1.3.9. If you want to confirm
that this is the patch causing the game to crash you should perform:

In the git tree:
1) git checkout d3fd7b247b35d7c8c453afa2fc07e121ea75214b  (and compile the
source then test the game: it should crash).

2) git reset --hard HEAD^ (compile the source again and test the game: it
shouldn't crash).

I'm not so experienced with git but this is how I used to confirm a regression
when the commit cannot be reverted cleanly.

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #8 from paulo  2010-12-15 10:03:03 CST ---
I tried that, but it is still crashing with the
"err:d3d:wined3d_unregister_window Window 0x3004e is not registered with
wined3d."

On both builds

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #9 from paulo  2010-12-17 16:13:54 CST ---
Sorry, i wasn't running it from the from the arcanum dir, but from the wine
build dir. It is that commit yes (and i'm a fool).

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #10 from Kevin Meyer  2010-12-22 00:03:14 CST ---
Created an attachment (id=32585)
 --> (http://bugs.winehq.org/attachment.cgi?id=32585)
backtrace for arcanum with opengl directdraw renderer

I can confirm the problem, though I have not determined if the mentioned commit
is to blame.

Using the OpenGL directdraw renderer, Arcanum produces a stack overflow when it
reaches the main menu. The backtrace I obtained can be seen in the attachments
and is applicable to current GIT. Give or take a day or two.

I'll see if I can produce a patch as well.

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from joaopa  2010-12-26 02:48:19 CST ---
Bug 25550 is a duplicate.

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #12 from joaopa  2010-12-26 02:51:52 CST ---
*** Bug 25550 has been marked as a duplicate of this bug. ***

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Austin English  2010-12-26 13:04:51 CST ---
*** Bug 25611 has been marked as a duplicate of this bug. ***

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #14 from Henri Verbeet  2011-01-04 08:23:59 CST ---
Created an attachment (id=32720)
 --> (http://bugs.winehq.org/attachment.cgi?id=32720)
patch

Does this patch work for you?

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #15 from GyB  2011-01-04 08:52:31 CST ---
(In reply to comment #14)
> Does this patch work for you?

Yes, it fixed the crash in Arcanum.

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

--- Comment #16 from joaopa  2011-01-04 11:14:40 CST ---
The patch fixes the bug 25550 too.

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #17 from Austin English  2011-01-05 13:05:01 CST ---
(In reply to comment #15)
> (In reply to comment #14)
> > Does this patch work for you?
>
> Yes, it fixed the crash in Arcanum.

Fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=e5d1a0c72d41d630cd32b1...

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Alexandre Julliard  2011-01-07 12:39:42 CST ---
Closing bugs fixed in 1.3.11.

[Bug 25427] Arcanum crashes in the main menu (when using hardware acceleration)

http://bugs.winehq.org/show_bug.cgi?id=25427

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e5d1a0c72d41d630cd32b1b67c7
                   |                            |9149e76699dc5
    Regression SHA1|                            |d3fd7b247b35d7c8c453afa2fc0
                   |                            |7e121ea75214b