http://bugs.winehq.org/show_bug.cgi?id=28516
Bug #: 28516 Summary: Regression: Red Alert 3 crashes when loading map Product: Wine Version: 1.3.24 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: shell32 AssignedTo: wine-bugs@winehq.org ReportedBy: c_korn@gmx.de CC: vshader@gmail.com Classification: Unclassified Regression SHA1: 08186a9c26e954aea26ad0129cae35f24f18054e
Created attachment 36596 --> http://bugs.winehq.org/attachment.cgi?id=36596 wine-1.3.29 output
The menu works fine when loading any map (tutorial, skirmish, mission) the game crashes immediately.
A regression test returned this result: 08186a9c26e954aea26ad0129cae35f24f18054e is the first bad commit commit 08186a9c26e954aea26ad0129cae35f24f18054e Author: Mariusz Pluciński vshader@gmail.com Date: Thu Jun 30 14:59:46 2011 +0200
shell32: Check for known folder existance.
:040000 040000 b3f8d21b18277ad943ac1b8d0f723d2fd967960f 8db8eca5b64afce8ab414dd5437335dbe3e19299 M dlls
This patch was committed between wine-1.3.23 and wine-1.3.24 so wine-1.3.24 is the first bad version. I have tested in current git head (wine-1.3.29-99-g3960ea8) and the problem is exactly the same.
Output with of wine-1.3.29 is attached.
http://bugs.winehq.org/show_bug.cgi?id=28516
--- Comment #1 from Christoph Korn c_korn@gmx.de 2011-09-28 07:23:16 CDT --- Created attachment 36597 --> http://bugs.winehq.org/attachment.cgi?id=36597 workaround
The attached patch worksaround the bug.
http://bugs.winehq.org/show_bug.cgi?id=28516
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com
--- Comment #2 from Bruno Jesus 00cpxxx@gmail.com 2011-09-28 08:23:08 CDT --- Can you please attach a WINEDEBUG=+shell log? It's important to get the traces from the function get_known_folder_path_by_id().
http://bugs.winehq.org/show_bug.cgi?id=28516
Christoph Korn c_korn@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=28516
--- Comment #3 from Christoph Korn c_korn@gmx.de 2011-09-28 08:35:42 CDT --- Created attachment 36600 --> http://bugs.winehq.org/attachment.cgi?id=36600 wine 1.3.29 +shell output
http://bugs.winehq.org/show_bug.cgi?id=28516
--- Comment #4 from Bruno Jesus 00cpxxx@gmail.com 2011-09-28 09:16:18 CDT --- It's trying to get this folder: {4C5C32FF-BB9D-43B0-B5B4-2D72E54EAAA4} = Saved Games GUID
Did you get the log with or without your patch? I was expecting the trace from inside the IF to be printed in the log:
TRACE("directory %s not found\n", debugstr_w(*ppszPath));
Maybe that GUID is not supported yet.
http://bugs.winehq.org/show_bug.cgi?id=28516
--- Comment #5 from Christoph Korn c_korn@gmx.de 2011-09-28 09:37:42 CDT --- The log came from the unpatched version.
To be more specific I did not even use my own build but the wine that comes with the Ubuntu package from the official PPA: wine1.3: Installed: 1.3.29-0ubuntu1~ppa1~natty1 Candidate: 1.3.29-0ubuntu1~ppa1~natty1 Version table: *** 1.3.29-0ubuntu1~ppa1~natty1 0 500 http://ppa.launchpad.net/ubuntu-wine/ppa/ubuntu/ natty/main amd64 Packages
I doubt that there was a patch applied in the package which changes something in the shell area.
http://bugs.winehq.org/show_bug.cgi?id=28516
--- Comment #6 from Bruno Jesus 00cpxxx@gmail.com 2011-09-28 14:30:02 CDT --- Can you confirm if this path exists: C:\users\korn\Gespeicherte Spiele
If it does not can you please create it and retry running the application? It looks like the saved games folder does not exist and that check makes the function returns error.
http://bugs.winehq.org/show_bug.cgi?id=28516
--- Comment #7 from Christoph Korn c_korn@gmx.de 2011-09-28 15:54:41 CDT --- This directory did not exist, after creating it the game does not crash any more.
http://bugs.winehq.org/show_bug.cgi?id=28516
--- Comment #8 from Bruno Jesus 00cpxxx@gmail.com 2011-09-28 17:05:11 CDT --- It seems like wine is not creating some of the required user directories in their own language. Or the invalid path check is making wine not create it, I'll seek advise in the devel list.
http://bugs.winehq.org/show_bug.cgi?id=28516
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: Red Alert 3 |Red Alert 3 crashes when |crashes when loading map |loading map
http://bugs.winehq.org/show_bug.cgi?id=28516
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |nerv@dawncrow.de Ever Confirmed|0 |1
--- Comment #9 from André H. nerv@dawncrow.de 2011-10-13 14:46:49 CDT --- i analyzed that a bit more and will see what i can do. it's about the _SHRegisterUserShellFolders that needs to be converted to FOLDERID_* handling
http://bugs.winehq.org/show_bug.cgi?id=28516
Huw Davies huw@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |huw@codeweavers.com
--- Comment #10 from Huw Davies huw@codeweavers.com 2012-02-09 04:28:25 CST --- I think 9ae17687c0654e89b702c4b7bc7a2e93f85321d4 should fix this.
http://bugs.winehq.org/show_bug.cgi?id=28516
Christoph Korn c_korn@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |8272045cd84c304c07ccc4273f1 | |cd544cd20b209 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #11 from Christoph Korn c_korn@gmx.de 2012-02-11 07:44:29 CST --- Works on master.
Did a git bisect to find the good commit. This is it: 8272045cd84c304c07ccc4273f1cd544cd20b209 is the first bad commit commit 8272045cd84c304c07ccc4273f1cd544cd20b209 Author: Huw Davies huw@codeweavers.com Date: Wed Feb 8 16:52:16 2012 +0000
shell32: Zero-init the out parameter and fix the error if the folder id is invalid.
:040000 040000 b32618d0c9b6aaef18955d0f76e52ec9d4fca62d ec4256581824b46d0ac7109e77df17339667aa09 M dlls
Thanks.
http://bugs.winehq.org/show_bug.cgi?id=28516
--- Comment #12 from André H. nerv@dawncrow.de 2012-02-11 09:07:36 CST --- still we should consider to simply generate the folders...
http://bugs.winehq.org/show_bug.cgi?id=28516
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org 2012-02-11 13:53:19 CST --- Closing bugs fixed in 1.4-rc3.
-
wine-bugs＠winehq.org