[Bug 18046] New: Resource leaks

http://bugs.winehq.org/show_bug.cgi?id=18046

Summary: Resource leaks
           Product: Wine
           Version: 1.1.19
          Platform: Other
               URL: http://cppcheck.wiki.sourceforge.net/
        OS/Version: other
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Running cppcheck 1.31 against wine 1.1.19 yeilds:

[./dlls/wineps.drv/mkagl.c:519]: (error) Resource leak: f_c
[./dlls/wineps.drv/mkagl.c:519]: (error) Resource leak: f_h
[./tools/fnt2bdf.c:219]: (error) Resource leak: fp

fclose() shold be called on these.

[Bug 18046] Resource leaks

http://bugs.winehq.org/show_bug.cgi?id=18046

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]            |[e-mail]
           Keywords|                            |download, source

[Bug 18046] Resource leaks

http://bugs.winehq.org/show_bug.cgi?id=18046

--- Comment #1 from Austin English   2009-04-16 15:20:58 ---
The wineps.drv memory leaks are fixed by
5f4cc6a89bf8cf401d9cc03a2689e0f9a06c5dc8.

[Bug 18046] Resource leaks

http://bugs.winehq.org/show_bug.cgi?id=18046

--- Comment #2 from bill   2009-05-02 09:05:45 ---
is this really fixed yet?

[Bug 18046] Resource leaks

http://bugs.winehq.org/show_bug.cgi?id=18046

--- Comment #3 from Nikolay Sivov   2009-05-02 09:14:08 ---
(In reply to comment #2)
> is this really fixed yet?

http://source.winehq.org/git/wine.git/?a=commit;h=5f4cc6a89bf8cf401d9cc03a26...

http://source.winehq.org/git/wine.git/?a=commit;h=e911fde41cbcbfe0bf2bc8fea5...

So feel free to run you checker again and mark this fixed.

[Bug 18046] Resource leaks

http://bugs.winehq.org/show_bug.cgi?id=18046

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |wineps.drv

[Bug 18046] Resource leaks

http://bugs.winehq.org/show_bug.cgi?id=18046

Wolfram Sang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Wolfram Sang   2010-03-20 04:45:51 ---
Out of interest, I ran cppcheck (1.42) today over wine-sources (1.1.41) (doing
this once in a lifetime is enough, though ;)) and those errors are not reported
anymore. fnt2bdf was fixed by commit a30625306d1cdfad74ac27fd677ba38d0ca338fb.

[Bug 18046] Resource leaks

http://bugs.winehq.org/show_bug.cgi?id=18046

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Alexandre Julliard   2010-03-20 04:58:03 ---
Fixed.

[Bug 18046] Resource leaks

http://bugs.winehq.org/show_bug.cgi?id=18046

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2010-04-02 12:52:10 ---
Closing bugs fixed in 1.1.42.