[Bug 29355] New: XMLdocument loadfromfile? doesn't work correctly

http://bugs.winehq.org/show_bug.cgi?id=29355

Bug #: 29355
           Summary: XMLdocument loadfromfile? doesn't work correctly
           Product: Wine
           Version: 1.3.34
          Platform: x86
               URL: http://netikka.net/dev/xml.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Small sample: http://netikka.net/dev/xml.exe

Save attached test.xml to .wine/drive_c/ first.

procedure TForm1.Button1Click(Sender: TObject);
begin
 xmldocument1.LoadFromFile('c:/test.xml');
 xmldocument1.SaveToFile('c:/test2.xml');
 memo1.text:=xmldocument1.XML.Text; //also without header?
end;

Problem is test2.xml has lost it's header.

winetricks msxml3 helps

[Bug 29355] XMLdocument loadfromfile? doesn't work correctly

http://bugs.winehq.org/show_bug.cgi?id=29355

--- Comment #1 from [e-mail] 2011-12-16 04:09:35 CST ---
Created attachment 37984
  --> http://bugs.winehq.org/attachment.cgi?id=37984
Test xml

[Bug 29355] XMLdocument loadfromfile? doesn't work correctly

http://bugs.winehq.org/show_bug.cgi?id=29355

--- Comment #2 from [e-mail] 2011-12-16 04:12:18 CST ---
Created attachment 37985
  --> http://bugs.winehq.org/attachment.cgi?id=37985
+msxml,+tid

[Bug 29355] XMLdocument loadfromfile? doesn't work correctly

http://bugs.winehq.org/show_bug.cgi?id=29355

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37984|text/xml                    |text/plain
          mime type|                            |

[Bug 29355] XMLdocument loadfromfile? doesn't work correctly

http://bugs.winehq.org/show_bug.cgi?id=29355

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 29355] IXMLDOMDocument::save() doesn't output xml declaration

http://bugs.winehq.org/show_bug.cgi?id=29355

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|XMLdocument loadfromfile?   |IXMLDOMDocument::save()
                   |doesn't work correctly      |doesn't output xml
                   |                            |declaration

[Bug 29355] IXMLDOMDocument::save() doesn't output xml declaration

http://bugs.winehq.org/show_bug.cgi?id=29355

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Nikolay Sivov  2012-01-06 08:56:17 CST ---
This was intentional as I remember, the reason is that we didn't want to depend
on XML_SAVE_NO_DECL flag being supported so I switched off both declarations -
one from fake node and one from libxml2 in case it is supported.

There's a problem that can't be solved actually - with msxml it's possible to
manually add declaration node with DOM methods and set desired encoding as
attribute, so output encoding is determined by it. This is not handled at all
as I remember.

What we need it a document saving rewrite that doesn't depend on libxml2
features and fixes some not-well specified cases or MS historical things like
double char line endings for example.

This is still a valid bug obviously, that should be fixed.

[Bug 29355] Multiple apps need IXMLDOMDocument::save() to preserve/output XML declaration (Lexware Financial Office Pro 2012, ...)

http://bugs.winehq.org/show_bug.cgi?id=29355

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|IXMLDOMDocument::save()     |Multiple apps need
                   |doesn't output xml          |IXMLDOMDocument::save() to
                   |declaration                 |preserve/output XML
                   |                            |declaration (Lexware
                   |                            |Financial Office Pro 2012,
                   |                            |...)

--- Comment #4 from Anastasius Focht  2012-04-15 15:10:44 CDT ---
Hello,

Lexware Financial Office Pro 2012 (v12.0) also needs this.
The installer executes a system "spec" check which results in a XML file being
written and loaded again to be displayed.

The installer GUI breaks because the XML declaration isn't serialized when the
file is created.

'winetricks msxml3' works around.

File created with native msxml3:

--- snip ---
<?xml version="1.0" encoding="iso-8859-1"?>
<systemchecks logopath="" logofilename="C:\Program Files\Common
Files\Lexware\Setup\financial_office_pro\FlashMovie\gfx\lexchecklogo.jpg"
title="Systemressourcen" description="Lexware scout hat Ihr System auf folgende
Punkte geprüft:">
    <systemcheck name="Betriebssystem" description="Ihr Betriebssystem ist mit
dem Produkt kompatibel." category="Success" detectedvalue="Microsoft Windows XP
Professional SP3" requiredvalue="Service Pack 0"></systemcheck><systemcheck
name="Arbeitsspeicher" description="Ihr Rechner verfügt über genügend
Arbeitsspeicher." category="Success" detectedvalue="größer oder gleich 2048 MB"
requiredvalue="512 MB"></systemcheck><systemcheck name="Bildschirmauflösung"
description="Prüfung der Bildschirmauflösung erfolgreich." category="Success"
detectedvalue="1920 x 1080, 32 Bit" requiredvalue="1024 x 768, 15
Bit"></systemcheck></systemchecks>
--- snip ---

File created with Wine builtin msxml3:

--- snip ---
<systemchecks logopath="" logofilename="C:\Program Files\Common
Files\Lexware\Setup\financial_office_pro\FlashMovie\gfx\lexchecklogo.jpg"
title="Systemressourcen" description="Lexware scout hat Ihr System auf folgende
Punkte geprüft:"><systemcheck name="Betriebssystem" description="Ihr
Betriebssystem ist mit dem Produkt kompatibel." category="Success"
detectedvalue="Microsoft Windows XP Professional SP3" requiredvalue="Service
Pack 0"></systemcheck><systemcheck name="Arbeitsspeicher" description="Ihr
Rechner verfügt über genügend Arbeitsspeicher." category="Success"
detectedvalue="größer oder gleich 2048 MB" requiredvalue="512
MB"></systemcheck><systemcheck name="Bildschirmauflösung"
description="Prüfung der Bildschirmauflösung erfolgreich." category="Success"
detectedvalue="1920 x 1080, 32 Bit" requiredvalue="1024 x 768, 15
Bit"></systemcheck></systemchecks>
--- snip ---

Also missing: 'tab' indentation before "systemcheck" but this seems harmless.

For testing I cheated the installer using a debugger and a breakpoint on
'domdoc_save'.
After replacing the created file with a version that preserves the xml
declaration and 'continue' the installer/GUI works fine and displays the
gathered data.
So it's really the missing XML declaration that breaks it.

There are probably more apps that depend on this, refining summary.

$ wine --version
wine-1.5.2

Regards

[Bug 29355] Multiple apps need IXMLDOMDocument::save() to preserve/output XML declaration (Lexware Financial Office Pro 2012, ...)

http://bugs.winehq.org/show_bug.cgi?id=29355

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30438

[Bug 29355] Multiple apps need IXMLDOMDocument::save() to preserve/output XML declaration (Lexware 2012 product installers, ...)

http://bugs.winehq.org/show_bug.cgi?id=29355

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Multiple apps need          |Multiple apps need
                   |IXMLDOMDocument::save() to  |IXMLDOMDocument::save() to
                   |preserve/output XML         |preserve/output XML
                   |declaration (Lexware        |declaration (Lexware 2012
                   |Financial Office Pro 2012,  |product installers, ...)
                   |...)                        |

--- Comment #5 from Anastasius Focht  2012-04-18 18:05:35 CDT ---
Hello,

refining summary as this seems to affect all Lexware 2010 product installers
(with flash based gui).

Regards

[Bug 29355] Multiple apps need IXMLDOMDocument::save() to preserve/output XML declaration (Lexware 2012 product installers, ...)

http://bugs.winehq.org/show_bug.cgi?id=29355

--- Comment #6 from Nikolay Sivov  2012-07-09 15:13:49 CDT ---
This is likely fixed with 46d08bb6cefa6372ef3f597a130d14ee62c662dc or
41aa34758e18f89b6d912e15177eafba12d10d6a please retest.

[Bug 29355] Multiple apps need IXMLDOMDocument::save() to preserve/output XML declaration (Lexware 2012 product installers, ...)

http://bugs.winehq.org/show_bug.cgi?id=29355

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Bruno Jesus  2012-07-23 17:41:28 CDT ---
The test application from comment 0 does work. IMO the bug is fixed, but maybe
someone can test the lexware applications.

[Bug 29355] Multiple apps need IXMLDOMDocument::save() to preserve/output XML declaration (Lexware 2012 product installers, ...)

http://bugs.winehq.org/show_bug.cgi?id=29355

--- Comment #8 from Nikolay Sivov  2012-09-02 01:58:17 CDT ---
Anyone care to retest with Lexware installers? I expect this to be fixed.

[Bug 29355] Multiple apps need IXMLDOMDocument::save() to preserve/output XML declaration (Lexware 2012 product installers, ...)

http://bugs.winehq.org/show_bug.cgi?id=29355

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |46d08bb6cefa6372ef3f597a130
                   |                            |d14ee62c662dc
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Anastasius Focht  2012-10-06 14:10:48 CDT ---
Hello,

indeed, the Lexware 2010 installer is fixed.

Systemcheck xml data with builtin msxml:

--- snip ---
<?xml version="1.0" encoding="iso-8859-1"?>
<systemchecks logopath="" logofilename="C:\Program Files\Common
Files\Lexware\Setup\buchhalter\FlashMovie\gfx\lexchecklogo.jpg"
title="Systemressourcen" description="Lexware scout hat Ihr System auf folgende
Punkte geprüft:"><systemcheck name="Betriebssystem" description="Ihr
Betriebssystem ist mit dem Produkt kompatibel." category="Success"
detectedvalue="Microsoft Windows XP Professional SP3" requiredvalue="Service
Pack 0"></systemcheck><systemcheck name="Arbeitsspeicher" description="Ihr
Rechner verfügt über genügend Arbeitsspeicher" category="Success"
detectedvalue="größer oder gleich 2048 MB" requiredvalue="256
MB"></systemcheck><systemcheck name="Bildschirmauflösung" description="Prüfung
der Bildschirmauflösung erfolgreich" category="Success" detectedvalue="1920 x
1080, 32 Bit" requiredvalue="1024 x 768, 15 Bit"></systemcheck><systemcheck
name="Microsoft Windows Installer" description="Windows Installer Prüfung
erfolgreich" category="Success" detectedvalue="Version 4.5"
requiredvalue="3.0"></systemcheck></systemchecks> 
--- snip ---

Thanks Nikolay.

Regards

[Bug 29355] Multiple apps need IXMLDOMDocument::save() to preserve/output XML declaration (Lexware 2012 product installers, ...)

http://bugs.winehq.org/show_bug.cgi?id=29355

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  2012-10-12 13:34:17 CDT ---
Closing bugs fixed in 1.5.15.