[Bug 13350] New: Dogfood: Vim menu text overlaps itself

http://bugs.winehq.org/show_bug.cgi?id=13350

Summary: Dogfood: Vim menu text overlaps itself
           Product: Wine
           Version: CVS/GIT
          Platform: PC
               URL: ftp://ftp.vim.org/pub/vim/pc/gvim71.exe
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Vim has menus that are split into two columns.  The first column is a verbal
description of a menu item, and the second column is the vim command that
accomplishes the same thing.  Running the Windows version of gvim has both
columns begin at the same x-position, resulting in them overlapping each other.

Unfortunately I haven't figured out how to grab a screenshot of a menu, as
pressing print screen cancels the menu.

[Bug 13350] Dogfood: Vim menu text overlaps itself

http://bugs.winehq.org/show_bug.cgi?id=13350

L. Rahyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from L. Rahyen   2008-05-22 12:10:01 ---
> I haven't figured out how to grab a screenshot of a menu, as

pressing print screen cancels the menu.

Use ksnapshot (it has "Snapshot delay" so you don't need press anything during
screenshot grabbing and therefore will be able to save window with the menu).

[Bug 13350] Dogfood: Vim menu text overlaps itself

http://bugs.winehq.org/show_bug.cgi?id=13350

--- Comment #2 from Austin English   2008-05-22 14:19:41 ---
Might be richedit related.

I tried running this on an old p3 at work, but that causes vim+wineserver to
spike up to 100% of cpu. Notepad, however, runs fine...

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
            Summary|Dogfood: Vim menu text      |Vim menu text overlaps
                   |overlaps itself             |itself [dogfood]

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |user32

--- Comment #3 from Juan Lang   2008-05-23 10:58:03 ---
It's a bug in user32 in the menu drawing code.  Now if I can only figure it
out...

The following hack fixes it, but I doubt it's a proper fix:
diff --git a/dlls/user32/menu.c b/dlls/user32/menu.c
index 49de5e1..ebfcd01 100644
--- a/dlls/user32/menu.c
+++ b/dlls/user32/menu.c
@@ -1601,9 +1601,6 @@ static void MENU_DrawMenuItem( HWND hwnd
                        DT_CENTER | DT_VCENTER | DT_SINGLELINE :
                        DT_LEFT | DT_VCENTER | DT_SINGLELINE;

-        if( !(menu->dwStyle & MNS_CHECKORBMP))
-            rect.left += menu->maxBmpSize.cx;
-
        if ( lpitem->fState & MFS_DEFAULT )
        {
             hfontOld = SelectObject( hdc, get_menu_font(TRUE) );

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

--- Comment #4 from Juan Lang   2008-05-23 11:06:38 ---
Patch sent:
http://www.winehq.org/pipermail/wine-patches/2008-May/055101.html

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

--- Comment #5 from Austin English   2008-12-05 15:54:41 ---
Still present in 1.1.10.

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

--- Comment #6 from Austin English   2009-01-19 15:16:05 ---
Removing deprecated CVS/GIT version tag. Please retest in current git. If the
bug is still present in today's wine, but was not present in some earlier
version of wine, please update version field to earliest known version of wine
that had the bug. Thanks!

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.0-rc2

--- Comment #7 from Juan Lang   2009-01-25 11:04:38 ---
Still present.  Setting Wine version to latest version at the time the bug was
reported.

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |patch

--- Comment #8 from Dan Kegel   2009-01-25 11:16:23 ---
Juan tried posting the patch again in July,
http://www.winehq.org/pipermail/wine-patches/2008-July/057663.html
Was there ever any response?

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

--- Comment #9 from Juan Lang   2009-01-25 12:08:34 ---
I think I might have gotten a stock response:  "You need tests."  The trouble
is the existing menu tests fail for me on WinXP, so I'd have to fix the
existing 80 or so failures before I could tackle this.  That's left me less
than motivated.

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

--- Comment #10 from Austin English   2009-01-25 15:23:02 ---
(In reply to comment #9)
> I think I might have gotten a stock response:  "You need tests."  The trouble
> is the existing menu tests fail for me on WinXP, so I'd have to fix the
> existing 80 or so failures before I could tackle this.  That's left me less
> than motivated.

You could do a standalone test, or simply check that your particular test
passes.

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

--- Comment #11 from Rein Klazes   2009-07-27 01:23:49 ---
I am responsible for this piece of code, yet I wasn't aware of this bug until
now. Sorry for that.

At first the patch looked reasonable to me, so I built some tests for it. That
showed the patch was not correct. There is a good point for those tests.

Anyway I submitted a better patch:

http://www.winehq.org/pipermail/wine-patches/2009-July/076445.html

The tests are interactive, you will have to set WINETEST_INTERACTIVE to 1 to
enable them.

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

Rein Klazes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Rein Klazes   2009-08-03 12:10:38 ---
Patch was committed:

http://source.winehq.org/git/wine.git/?a=commit;h=c18cd1b46fdedd713b0c4113f0...

marking the bug fixed.

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

--- Comment #13 from Juan Lang   2009-08-03 13:01:44 ---
Thanks Rein :)

[Bug 13350] Vim menu text overlaps itself [dogfood]

http://bugs.winehq.org/show_bug.cgi?id=13350

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard   2009-08-07 12:23:36 ---
Closing bugs fixed in 1.1.27.