[Bug 28799] New: d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

Bug #: 28799
           Summary: d3dx9_36/tests/mesh.ok: memcpy source and destination
                    overlap in weld_float16_2() triggered by
                    test_weld_vertices()
           Product: Wine
           Version: 1.3.30
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3dx9
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified

In d3dx9_36/tests, in "make mesh.ok", valgrind complains:

Source and destination overlap in memcpy(0x7fd893dc, 0x7fd893dc, 4)
   at memcpy (mc_replace_strmem.c:635)
   by weld_float16_2 (mesh.c:5861)
   by weld_component (mesh.c:5958)
   by D3DXWeldVertices (mesh.c:6242)
   by test_weld_vertices (mesh.c:8069)
   by func_mesh (mesh.c:8193)
   by run_test (test.h:556)
   by main (test.h:624)

[Bug 28799] d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

--- Comment #1 from Dan Kegel  2011-10-19 11:26:24 CDT ---
Also see the same backtrace but with weld_float16_4 and weld_float16_1 (iirc).

[Bug 28799] d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

Michael Mc Donnell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Michael Mc Donnell  2012-03-21 04:49:32 CDT ---
Thanks for reporting it Dan. I'll have a look at it.

[Bug 28799] d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

--- Comment #3 from Michael Mc Donnell  2012-03-21 18:12:21 CDT ---
Created attachment 39490
  --> http://bugs.winehq.org/attachment.cgi?id=39490
Patch for not welding self

It looks like the error message is caused by the destination and source being
the same. This patch makes sure that a vertex is not welded with itself.

[Bug 28799] d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Bruno Jesus  2012-03-21 18:36:11 CDT ---
Isn't it simpler to use memmove instead? Although your solution may be faster.

[Bug 28799] d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

--- Comment #5 from Michael Mc Donnell  2012-03-22 04:27:45 CDT ---
(In reply to comment #4)
> Isn't it simpler to use memmove instead? Although your solution may be faster.

Using a memmove would just hide the problem. There should not be any
overlapping memory regions at all.

[Bug 28799] d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

--- Comment #6 from Michael Mc Donnell  2012-03-29 17:29:36 CDT ---
The fix has been committed(f144626e81c3b60bbc9a9c028e4a8ec1f5d96c24). Please
re-test.

[Bug 28799] d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

--- Comment #7 from Michael Mc Donnell  2012-05-31 12:54:55 CDT ---
Can someone please mark this as fixed?

[Bug 28799] d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |f144626e81c3b60bbc9a9c028e4
                   |                            |a8ec1f5d96c24
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Austin English  2012-05-31 13:01:00 CDT ---
Fixed.

[Bug 28799] d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2012-06-08 15:28:39 CDT ---
Closing bugs fixed in 1.5.6.

[Bug 28799] d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.4.x

[Bug 28799] d3dx9_36/tests/mesh.ok: memcpy source and destination overlap in weld_float16_2() triggered by test_weld_vertices()

http://bugs.winehq.org/show_bug.cgi?id=28799

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.4.x                       |---