[Bug 53670] New: vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

Bug ID: 53670
           Summary: vbscript can not compile if expressions with reversed
                    gte, lte, (=>, =<)
           Product: Wine
           Version: 7.16
          Hardware: x86-64
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: vbscript
          Assignee: [e-mail]
          Reporter: [e-mail]

While working on leveraging the vbscript engine of Wine for a macos port of
Visual Pinball, I've been testing several user made scripts.

I've found several scripts that use if expressions with gte and lte in reversed
order, ie => and =<, which fail to compile.

vbscript does seem to allow for these to be reversed:

Set g_objWSH = Wscript.CreateObject("Wscript.Shell")

dim x
dim y

x = 6
y = 6

If x => y Then
     Wscript.Echo "This works 1"
End If

If x >= y Then
     Wscript.Echo "This works 2"
End If

If x <= y Then
     Wscript.Echo "This works 3"
End If

If x =< y Then
     Wscript.Echo "This works 4"
End If

[Bug 53670] vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

Jason Millard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 53670] vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

Robert Wilhelm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]

--- Comment #1 from Robert Wilhelm  ---
confirming.

[Bug 53670] vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

--- Comment #2 from Robert Wilhelm  ---
Created attachment 73088
  --> https://bugs.winehq.org/attachment.cgi?id=73088
support reversed gte and lte in lexer.

[Bug 53670] vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

Robert Wilhelm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 53670] vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

--- Comment #3 from Jason Millard  ---
I just tried this and it's working! Thanks again!

[Bug 53670] vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

--- Comment #4 from Nikolay Sivov  ---
(In reply to Robert Wilhelm from comment #2)
> Created attachment 73088 [details]
> support reversed gte and lte in lexer.

This looks good to me. Robert, do you have time to submit this, with some
tests?

[Bug 53670] vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

--- Comment #5 from Robert Wilhelm  ---
> This looks good to me. Robert, do you have time to submit this, with some
> tests?

Yes, I plan to submit this real soon now.

[Bug 53670] vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |3a578022891714a83d5a981693b
                   |                            |945cc0a16b63d
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Nikolay Sivov  ---
Marking fixed, 3a578022891714a83d5a981693b945cc0a16b63d.

[Bug 53670] vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 7.22.

[Bug 53670] vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |7.0.x

[Bug 53670] vbscript can not compile if expressions with reversed gte, lte, (=>, =<)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53670

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|7.0.x                       |---

--- Comment #8 from Michael Stefaniuc  ---
Drop 7.0.x target milestone from bugs that didn't make it.