[Bug 39673] New: Logical error in comparison (misprint)

https://bugs.winehq.org/show_bug.cgi?id=39673

Bug ID: 39673
           Summary: Logical error in comparison (misprint)
           Product: Wine
           Version: 1.8-rc1
          Hardware: x86
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: tapi32
          Assignee: [e-mail]
          Reporter: [e-mail]

Clang show me warning but this is logical mistake
----------
wine-hq/dlls/tapi32/assisted.c:63:8: warning: logical not is only applied to
      the left hand side of this comparison [-Wlogical-not-parentheses]
    if(!RegOpenKeyW(HKEY_LOCAL_MACHINE, locations_keyW, &hkey) !=
ERROR_SUCCESS) {
       ^                                                       ~~
-----
It must be
 if(!RegOpenKeyW(HKEY_LOCAL_MACHINE, locations_keyW, &hkey)) {

or
 if(RegOpenKeyW(HKEY_LOCAL_MACHINE, locations_keyW, &hkey) != ERROR_SUCCESS) {

[Bug 39673] Logical error in comparison (misprint)

https://bugs.winehq.org/show_bug.cgi?id=39673

--- Comment #1 from Sergey Isakov  ---
Same here

---
wine-hq/dlls/msi/tests/automation.c:881:9: warning: logical not is only
      applied to the left hand side of this comparison
[-Wlogical-not-parentheses]
    if (!hr == S_OK) return hr;
        ^   ~~
----
it must be
    if (!hr) return hr;

or
    if (hr == S_OK) return hr;

[Bug 39673] Logical error in comparison (misprint)

https://bugs.winehq.org/show_bug.cgi?id=39673

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |minor

[Bug 39673] Logical error in comparison (misprint)

https://bugs.winehq.org/show_bug.cgi?id=39673

--- Comment #2 from Nikolay Sivov  ---
In practice both cases work as intended, but I agree, clean up is needed. Feel
free to send a patch.

[Bug 39673] Logical error in comparison (misprint)

https://bugs.winehq.org/show_bug.cgi?id=39673

--- Comment #3 from Sergey Isakov  ---
Same

wine-hq/dlls/winex11.drv/clipboard.c:2449:9: warning: logical not is only
      applied to the left hand side of this comparison
[-Wlogical-not-parentheses]
    if (!XGetWindowProperty(display, xe.xselection.requestor,
xe.xselection.property,
        ^

wine-hq/dlls/winex11.drv/clipboard.c:3354:9: warning: logical not is only
      applied to the left hand side of this comparison
[-Wlogical-not-parentheses]
    if (!XGetWindowProperty(display, pevent->requestor, rprop,
        ^

[Bug 39673] Logical error in comparison (misprint)

https://bugs.winehq.org/show_bug.cgi?id=39673

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |3557870302b8256bffc67d578d4
                   |                            |c36b7cfefb349
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Bruno Jesus  ---
Fixed by 3557870302b8256bffc67d578d4c36b7cfefb349.

[Bug 39673] Logical error in comparison (misprint)

https://bugs.winehq.org/show_bug.cgi?id=39673

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.8-rc3.