[Bug 33566] New: Menubar titles go blank in 1.5.26

http://bugs.winehq.org/show_bug.cgi?id=33566

Bug #: 33566
           Summary: Menubar titles go blank in 1.5.26
           Product: Wine
           Version: 1.5.24
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdiplus
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified
   Regression SHA1: 61dafbb7012061fda7a737daf24340ce927ce2cc

After an upgrade to 1.5.26, the menubar titles in Manga Studio 5 go blank. You
can still click on them and their respective menus appear, but the titles
themselves are missing.

Bisecting revealed that the offending change is:
61dafbb7012061fda7a737daf24340ce927ce2cc
gdiplus: Ignore gdiplus page and world transformations when creating a gdi32
clipping region

Problem still exists in 1.5.30. Reverting this change fixes the issue.

[Bug 33566] Menubar titles go blank in 1.5.26

http://bugs.winehq.org/show_bug.cgi?id=33566

Don Koch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.5.24                      |1.5.26

[Bug 33566] Menubar titles go blank in 1.5.26

http://bugs.winehq.org/show_bug.cgi?id=33566

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 33566] Menubar titles go blank in 1.5.26

http://bugs.winehq.org/show_bug.cgi?id=33566

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Menubar titles go blank in  |Manga Studio 5: Menubar
                   |1.5.26                      |titles go blank

--- Comment #1 from Dmitry Timoshkov  2013-05-13 21:14:29 CDT ---
Is there a demo version or some other way to reproduce the problem?

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

Don Koch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Don Koch  2013-05-14 21:42:56 CDT ---
Not that I'm aware of. One would hope some other program also has this issue
and someone will add it to this bug.

Out of curiosity, why was this change made? (I assume there was a reason, but
the commit didn't mention it.)

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

--- Comment #3 from Dmitry Timoshkov  2013-05-14 21:56:02 CDT ---
(In reply to comment #2)
> Not that I'm aware of. One would hope some other program also has this issue
> and someone will add it to this bug.

It would be helpful, without an application which shows the problem it's
pretty much impossible to debug it.
> Out of curiosity, why was this change made? (I assume there was a reason, but
> the commit didn't mention it.)

Here is a comment from the patch sent to wine-patches:
"This patch completely fixes all the drawing defects in applications based
on VGScene graphics library."

Probably that patch discovered a bug in some other code which relies on old
behaviour.

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

--- Comment #4 from Don Koch  2013-05-15 21:01:00 CDT ---
SmithMicro claims that a 30-day free trial version of Manga Studio 5 "will be
available soon." See: http://manga.smithmicro.com/trial.html

I don't know if the MS Debut 4 free trial (same page) has the issue or not.
I'll set up a new environment and install it when I get a chance.

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sagawa.aki+winebugs@gmail.c
                   |                            |om

--- Comment #5 from Sagawa  2013-06-29 00:53:17 CDT ---
I can confirm the issue in wine 1.6 rc3, and reverting the change fix the
issue.
In Japan, Manga Studio 5 is known as Clip Studio. I confirm the issue on Clip
Studio 1.0.2 (demo version).

Japanese version is available without registration. You can download the demo
following URL:
http://www.clip-studio.com/clip_site/download/clipstudiopaint/csptrial/index...

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

--- Comment #6 from Sagawa  2013-06-29 01:24:46 CDT ---
Created attachment 45030
  --> http://bugs.winehq.org/attachment.cgi?id=45030
Clip Studio Paint EX

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

--- Comment #7 from Sagawa  2013-06-29 01:28:20 CDT ---
Created attachment 45031
  --> http://bugs.winehq.org/attachment.cgi?id=45031
Clip Studio

Left menu titles aren't shown.

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #8 from Dmitry Timoshkov  2013-06-30 23:01:04 CDT ---
(In reply to comment #5)
> Japanese version is available without registration. You can download the demo
> following URL:
> http://www.clip-studio.com/clip_site/download/clipstudiopaint/csptrial/index...

Since I don't read Japanese I can't find a link with download on that page.

(In reply to comment #4)
> SmithMicro claims that a 30-day free trial version of Manga Studio 5 "will be
> available soon." See: http://manga.smithmicro.com/trial.html

They offer a trial download now, but want too much of personal info, I'd prefer
to avoid that.

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

--- Comment #9 from Bruno Jesus  2013-06-30 23:16:52 CDT ---
Download link:

http://www.clip-studio.com/clip_site/download/clipstudiopaint/system/dl?f=li...

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

--- Comment #10 from Dmitry Timoshkov  2013-07-01 00:07:17 CDT ---
(In reply to comment #9)
> Download link:
>
> http://www.clip-studio.com/clip_site/download/clipstudiopaint/system/dl?f=li...

Thanks Bruno, I can reproduce the problem.

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

--- Comment #11 from Dmitry Timoshkov  2013-07-01 03:26:20 CDT ---
The application does:

GdipTranslateWorldTransform(gfx, -46, -32, MatrixOrderPrepend);
GdipSetClipRect(gfx, 7, 26, 194, 339, CombineModeReplace);
GdipDrawString(gfx, "CLIP STUDIO START", 17, (46,32+120,36), ...);

Calculated bounds rect is (46,32+101,13) which becomes (0,0+101,13) after
applying world transform, and the string gets clipped out.

This needs some tests.

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

--- Comment #12 from Dmitry Timoshkov  2013-07-12 03:15:00 CDT ---
I sent a revert:
http://www.winehq.org/pipermail/wine-patches/2013-July/125184.html

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |73f7b857b3a8b5a6638168ef8bc
                   |                            |8c0d15552a7a6
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Dmitry Timoshkov  2013-07-12 20:41:18 CDT ---
Revert has been committed.

[Bug 33566] Manga Studio 5: Menubar titles go blank

http://bugs.winehq.org/show_bug.cgi?id=33566

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard  2013-08-02 13:19:02 CDT ---
Closing bugs fixed in 1.7.0.