[Bug 29555] New: Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

Bug #: 29555
           Summary: Age of Empires II screen locks up after playing for
                    around 15 minutes
           Product: Wine
           Version: 1.3.36
          Platform: x86-64
        OS/Version: Mac OS X
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified
   Regression SHA1: regression

Screen will be frozen (stuck at the last working frame) after playing an Age of
Empires II game (which utilizes heavily the DIB engine) for around 10-15
minutes while the audio (& the game itself i suppose) is still working after
the screen is frozen.

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

--- Comment #1 from PommeGolden  2012-01-07 07:13:31 CST ---
Created attachment 38290
  --> http://bugs.winehq.org/attachment.cgi?id=38290
wine log (b00e7039c5fcaa613b9776a38fe60bb697146b42 build)

"err:ddraw:ddraw_clipper_GetClipList Failed to create region.
err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash"

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|regression                  |

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|gdi32                       |-unknown
           Severity|major                       |normal

--- Comment #2 from Dmitry Timoshkov  2012-01-07 07:26:15 CST ---
http://wiki.winehq.org/RegressionTesting

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-d3d
    Regression SHA1|                            |3e9fe3e938f26a8c831f92367a1
                   |                            |3776d165cfdf8

--- Comment #3 from PommeGolden  2012-01-08 00:31:54 CST ---
Wine 1.3.36 & before does not have this problem.

Bisect shows:

3e9fe3e938f26a8c831f92367a13776d165cfdf8 is the first bad commit
commit 3e9fe3e938f26a8c831f92367a13776d165cfdf8
Author: Henri Verbeet 
Date:   Fri Jan 6 11:20:03 2012 +0100

ddraw: Use the window's client rect for clipping.

:040000 040000 41ca6ddda70387741182ce47ad613e207196c570
30adc2d970a2fe0b7be3c2d7e90847d0d7b6bb3a M    dlls

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|3e9fe3e938f26a8c831f92367a1 |
                   |3776d165cfdf8               |

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-d3d                 |-unknown

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-d3d
    Regression SHA1|                            |3e9fe3e938f26a8c831f92367a1
                   |                            |3776d165cfdf8

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|3e9fe3e938f26a8c831f92367a1 |31f3120815721c36b3f31a66e91
                   |3776d165cfdf8               |a564aa3c5165b

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

--- Comment #4 from PommeGolden  2012-01-08 03:33:31 CST ---
(In reply to comment #3)
> Wine 1.3.36 & before does not have this problem.
>
> Bisect shows:
>
> 3e9fe3e938f26a8c831f92367a13776d165cfdf8 is the first bad commit
> commit 3e9fe3e938f26a8c831f92367a13776d165cfdf8
> Author: Henri Verbeet 
> Date:   Fri Jan 6 11:20:03 2012 +0100
> ddraw: Use the window's client rect for clipping.
>
> :040000 040000 41ca6ddda70387741182ce47ad613e207196c570
> 30adc2d970a2fe0b7be3c2d7e90847d0d7b6bb3a M    dlls

CORRECTION:

Sorry, the first bad commit which causes the screen to lock up is actually
31f3120815721c36b3f31a66e91a564aa3c5165b , NOT
3e9fe3e938f26a8c831f92367a13776d165cfdf8 .

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

--- Comment #5 from Henri Verbeet  2012-01-08 03:35:28 CST ---
Created attachment 38298
  --> http://bugs.winehq.org/attachment.cgi?id=38298
patch

This should help.

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|31f3120815721c36b3f31a66e91 |f17e7148578939dbfac67bcb677
                   |a564aa3c5165b               |46831819db5d9

--- Comment #6 from PommeGolden  2012-01-08 03:44:25 CST ---
(In reply to comment #4)
> (In reply to comment #3)
> > Wine 1.3.36 & before does not have this problem.
> >
> > Bisect shows:
> >
> > 3e9fe3e938f26a8c831f92367a13776d165cfdf8 is the first bad commit
> > commit 3e9fe3e938f26a8c831f92367a13776d165cfdf8
> > Author: Henri Verbeet 
> > Date:   Fri Jan 6 11:20:03 2012 +0100
> > ddraw: Use the window's client rect for clipping.
> >
> > :040000 040000 41ca6ddda70387741182ce47ad613e207196c570
> > 30adc2d970a2fe0b7be3c2d7e90847d0d7b6bb3a M    dlls
>
> CORRECTION:
>
> Sorry, the first bad commit which causes the screen to lock up is actually
> 31f3120815721c36b3f31a66e91a564aa3c5165b , NOT
> 3e9fe3e938f26a8c831f92367a13776d165cfdf8 .

Seems I was wrong again. The first bad commit should be
f17e7148578939dbfac67bcb67746831819db5d9 instead...

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://download.microsoft.c
                   |                            |om/download/aoeaok/Trial/1.
                   |                            |0/WIN98/EN-US/AoE2demo.exe

--- Comment #7 from PommeGolden  2012-01-08 03:55:50 CST ---
EXACT STEPS TO REPRODUCE THIS BUG:
========================

1. Download & install AOE 2 Trial:
http://download.microsoft.com/download/aoeaok/Trial/1.0/WIN98/EN-US/AoE2demo...

2. Set DirectDrawRenderer to "gdi" in registry
http://wiki.winehq.org/UsefulRegistryKeys

3. Launch AOE2 Trial

4. Start a Single Player game, for example: Single Player -> Random Map ->
Trial Costal Map

It's a good idea to set the difficulty level to "Easiest" if you are not
familiar with the game (so that you won't be defeated by computers before the
screen freezes ;-))

5. (OPTIONAL) Press F11 enable to game clock (the clock will show up at the top
left corner)

6. Wait for the screen to freeze. (Screen will freeze at around 6:XX to 18:XX
if game speed is set to "fast")

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

--- Comment #8 from PommeGolden  2012-01-08 03:58:10 CST ---
(In reply to comment #6)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Wine 1.3.36 & before does not have this problem.
> > >
> > > Bisect shows:
> > >
> > > 3e9fe3e938f26a8c831f92367a13776d165cfdf8 is the first bad commit
> > > commit 3e9fe3e938f26a8c831f92367a13776d165cfdf8
> > > Author: Henri Verbeet 
> > > Date:   Fri Jan 6 11:20:03 2012 +0100
> > > ddraw: Use the window's client rect for clipping.
> > >
> > > :040000 040000 41ca6ddda70387741182ce47ad613e207196c570
> > > 30adc2d970a2fe0b7be3c2d7e90847d0d7b6bb3a M    dlls
> >
> > CORRECTION:
> >
> > Sorry, the first bad commit which causes the screen to lock up is actually
> > 31f3120815721c36b3f31a66e91a564aa3c5165b , NOT
> > 3e9fe3e938f26a8c831f92367a13776d165cfdf8 .
>
> Seems I was wrong again. The first bad commit should be
> f17e7148578939dbfac67bcb67746831819db5d9 instead...

f17e7148578939dbfac67bcb67746831819db5d9 is the first bad commit
commit f17e7148578939dbfac67bcb67746831819db5d9
Author: Henri Verbeet 
Date:   Fri Jan 6 11:20:04 2012 +0100

ddraw: Implement IDirectDrawClipper::SetClipList().

:040000 040000 30adc2d970a2fe0b7be3c2d7e90847d0d7b6bb3a
a599dea14904e2cf4ba78799d82c426cb12d22bd M    dlls

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

--- Comment #9 from PommeGolden  2012-01-08 05:19:07 CST ---
(In reply to comment #5)
> Created attachment 38298 [details]
> patch
>
> This should help.

thanks, I can confirm the patch does make the frozen screen go away although
the two "err" messages about ddraw_clipper_GetClipList & gdi:alloc_gdi_handle
are still there in the log..

"err:ddraw:ddraw_clipper_GetClipList Failed to create region.
err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash"

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

--- Comment #10 from PommeGolden  2012-01-08 05:20:11 CST ---
Created attachment 38299
  --> http://bugs.winehq.org/attachment.cgi?id=38299
wine log after patch running AOE II (b00e7039c5fcaa613b9776a38fe60bb697146b42
git build)

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

--- Comment #11 from Henri Verbeet  2012-01-08 05:31:18 CST ---
(In reply to comment #9)
> thanks, I can confirm the patch does make the frozen screen go away although
> the two "err" messages about ddraw_clipper_GetClipList & gdi:alloc_gdi_handle
> are still there in the log..
>
> "err:ddraw:ddraw_clipper_GetClipList Failed to create region.
> err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash"

Not in the log you attached. If it's just the two messages that are actually in
the log, that's probably harmless, it may be because e.g. the window was
destroyed.

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

--- Comment #12 from PommeGolden  2012-01-08 06:49:19 CST ---
(In reply to comment #11)
> (In reply to comment #9)
> > thanks, I can confirm the patch does make the frozen screen go away although
> > the two "err" messages about ddraw_clipper_GetClipList & gdi:alloc_gdi_handle
> > are still there in the log..
> >
> > "err:ddraw:ddraw_clipper_GetClipList Failed to create region.
> > err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash"
>
> Not in the log you attached. If it's just the two messages that are actually in
> the log, that's probably harmless, it may be because e.g. the window was
> destroyed.

My bad, the err messages after patch are actually:

"err:ddraw:get_window_region Failed to get client rect.
err:ddraw:ddraw_clipper_GetClipList Failed to get window region."

I notice when the log is flooded with

"err:ddraw:ddraw_clipper_GetClipList Failed to create region.
err:gdi:alloc_gdi_handle out of GDI object handles, expect a crash""

the screen will freeze sooner or later.

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

--- Comment #13 from Henri Verbeet  2012-01-09 15:09:55 CST ---
Should be fixed by 01992d7fb52e4276bb121a7d91d9615c93f97b42.

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |01992d7fb52e4276bb121a7d91d
                   |                            |9615c93f97b42
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from PommeGolden  2012-01-10 03:02:38 CST ---
Fixed

[Bug 29555] Age of Empires II screen locks up after playing for around 15 minutes

http://bugs.winehq.org/show_bug.cgi?id=29555

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard  2012-01-13 13:50:11 CST ---
Closing bugs fixed in 1.3.37.