http://bugs.winehq.org/show_bug.cgi?id=28404
Summary: Incoming Forces: visual glitches Product: Wine Version: 1.3.22 Platform: x86 URL: http://www.fileplanet.com/85297/80000/fileinfo/Incomin g-Forces-Demo OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: gyebro69@gmail.com CC: hverbeet@gmail.com Regression SHA1: 708d94212b4a6419f15200c1c9c5b79c5264903d
Created an attachment (id=36419) --> (http://bugs.winehq.org/attachment.cgi?id=36419) screenshot
The game is a 3D shooter, released in 2002.
When turning with the mouse in mid-game, strange visual artifacts appear: textures are smearing, leaving an afterimage(?) behind (see attached screenshot). Text is also drawn over (at the top of the screen).
Nothing interesting in the terminal while running the game. The same in wine-1.3.28-247-g54b37b8 too.
This is due to the following commit:
708d94212b4a6419f15200c1c9c5b79c5264903d is the first bad commit commit 708d94212b4a6419f15200c1c9c5b79c5264903d Author: Henri Verbeet hverbeet@codeweavers.com Date: Sun Jun 5 22:48:50 2011 +0200
wined3d: Don't clamp vertex depth values.
Since we report D3DPMISCCAPS_CLIPTLVERTS.
:040000 040000 3f31511205215608752163b4feda891e0a76bc29 7012cb2766378f7cb711e1ec9ccc14b8506ba30e M dlls
Other bug related to this commit: bug #27821. I must add that I can't reproduce bug #27821 in the GTA games.
Steps to reproduce the problem: 1) Unpack and install the demo (uncheck the DX8 option during setup). 2) Launch the game by forces.exe. If the game crashes in dsound, choose 'emulation' instead of 'full' in winecfg's Audio tab. 3) In the menu select Start game > Demo mission.
Fedora 15 x86 Nvidia 250 / driver 280.13
http://bugs.winehq.org/show_bug.cgi?id=28404
GyB gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=28404
--- Comment #1 from GyB gyebro69@gmail.com 2011-12-18 12:53:31 CST --- Still present in Wine-1.3.35 with the latest Nvidia proprietary driver (290.10).
http://bugs.winehq.org/show_bug.cgi?id=28404
--- Comment #2 from Henri Verbeet hverbeet@gmail.com 2012-02-03 15:25:44 CST --- I spent a fair amount of time on this, but I'm not quite sure where the problem is. The smearing you see happens because the game doesn't clear the backbuffer and depth buffer between frames, but instead just draws the skymap with depth testing disabled. However, that gets clipped because the (rhw) vertices have Z-values slightly larger than 1.0. A typical skymap triangle looks like this:
{8.01000000e+02, 3.67438812e+02, 1.00024152e+00, 8.41857855e-06} {0.00000000e+00, 4.59675171e+02, 1.00024152e+00, 8.41857855e-06} {0.00000000e+00, 3.00110535e+02, 1.00024152e+00, 8.41857855e-06}
Depth clamping avoided the clipping, but would be inconsistent with the D3DPMISCCAPS_CLIPTLVERTS we report. (And the tests prove this.) Matteo tested this on Windows with an NVIDIA card, and it works there as well. I suppose we could just remove the cap and enable depth clamping again, but it strikes me as hiding the real bug, since this is somehow supposed to work even with D3DPMISCCAPS_CLIPTLVERTS.
http://bugs.winehq.org/show_bug.cgi?id=28404
--- Comment #3 from Henri Verbeet hverbeet@gmail.com 2012-02-14 10:37:01 CST --- Created attachment 38872 --> http://bugs.winehq.org/attachment.cgi?id=38872 patch
Actually, maybe something like the attached patch makes sense. Needs tests.
http://bugs.winehq.org/show_bug.cgi?id=28404
--- Comment #4 from GyB gyebro69@gmail.com 2012-02-14 13:47:35 CST --- (In reply to comment #3)
Created attachment 38872 [details] patch
Actually, maybe something like the attached patch makes sense. Needs tests.
The patch fixes the problem here as well. I keep testing the patch with other games as well.
http://bugs.winehq.org/show_bug.cgi?id=28404
Bastian hougaard.junior@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hougaard.junior@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=28404
--- Comment #5 from Bastian hougaard.junior@gmail.com 2012-02-16 11:04:52 CST --- (In reply to comment #3)
Created attachment 38872 [details] patch
Actually, maybe something like the attached patch makes sense. Needs tests.
I was unable to test this patch with the Incomming Forces demo as I have a lot of visual glitches unrelated to this bug. I can confirm though that this patch fixes bug 29869 which you have mentioned sound similar to this bug.
http://bugs.winehq.org/show_bug.cgi?id=28404
--- Comment #6 from Henri Verbeet hverbeet@gmail.com 2012-02-24 10:55:06 CST --- Should be fixed by d17f037fb11b8a654a38040aaefbdce5f2358963. Note that the patch that was submitted is slightly different from what's attached here though.
http://bugs.winehq.org/show_bug.cgi?id=28404
GyB gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |d17f037fb11b8a654a38040aaef | |bdce5f2358963 Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #7 from GyB gyebro69@gmail.com 2012-02-24 11:42:24 CST --- Fixed indeed.
http://bugs.winehq.org/show_bug.cgi?id=28404
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org 2012-02-24 12:49:10 CST --- Closing bugs fixed in 1.4-rc5.