[Bug 12236] New: Irfanview: distorted image display

http://bugs.winehq.org/show_bug.cgi?id=12236

Summary: Irfanview: distorted image display
           Product: Wine
           Version: 0.9.58.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Displayed images are vertically distorted, when their height exceeds the height
of the client area. The image is squashed into the bottom, the area above does
not repaint.
The relevant setting for reproducing:
View -> Display options -> Do not fit anything

The cause seems to be this commit, reverting to the previous (0.9.57) version
of dlls/gdi32/dib.c fixes the problem:

http://source.winehq.org/git/wine.git/?a=commitdiff;h=5953a86ab180575c71f3d0...

Irfanview can be found here: http://irfanview.com

[Bug 12236] Irfanview: distorted image display

http://bugs.winehq.org/show_bug.cgi?id=12236

--- Comment #1 from James Hawkins   2008-03-26 15:37:42 ---
Did you run an actual regression test?  The only way to verify that commit is
the problem is to revert only that commit, not go all the way back to the
0.9.57 version of that file.

[Bug 12236] Irfanview: distorted image display

http://bugs.winehq.org/show_bug.cgi?id=12236

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 12236] Irfanview: distorted image display

http://bugs.winehq.org/show_bug.cgi?id=12236

--- Comment #2 from [e-mail]  2008-03-26 16:17:16 ---
(In reply to comment #1)
> Did you run an actual regression test?  The only way to verify that commit is
> the problem is to revert only that commit, not go all the way back to the
> 0.9.57 version of that file.

No, I have not. (Never done that before, but will try, if necessary).
Using the wine.git web interface, the mentioned commit seems to be the only one
between the two wine releases, that affects dlls/gdi32/dib.c.

[Bug 12236] Irfanview: distorted image display

http://bugs.winehq.org/show_bug.cgi?id=12236

--- Comment #3 from James Hawkins   2008-03-26 16:24:35 ---
Your probably right, but for the sake of completeness, please run an actual
regression test:

http://wiki.winehq.org/RegressionTesting

[Bug 12236] Irfanview: distorted image display

http://bugs.winehq.org/show_bug.cgi?id=12236

--- Comment #4 from [e-mail]  2008-03-26 18:07:26 ---
Created an attachment (id=11677)
 --> (http://bugs.winehq.org/attachment.cgi?id=11677)
result of the regression test

[Bug 12236] Irfanview: distorted image display

http://bugs.winehq.org/show_bug.cgi?id=12236

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from [e-mail]  2008-03-26 18:18:52 ---
Following the examples on http://wiki.winehq.org/RegressionTesting, I initiated
the tests with:

git bisect start dlls/gdi32
git bisect good wine-0.9.57
git bisect bad

using current git, of course.

[Bug 12236] Irfanview: distorted image display

http://bugs.winehq.org/show_bug.cgi?id=12236

--- Comment #6 from Austin English   2008-03-26 18:22:11 ---
(In reply to comment #4)
> Created an attachment (id=11677)

--> (http://bugs.winehq.org/attachment.cgi?id=11677) [details]
> result of the regression test

No need to attach that, just paste it inline:

5953a86ab180575c71f3d001e0c6a05cf8348c26 is first bad commit
commit 5953a86ab180575c71f3d001e0c6a05cf8348c26
Author: Alexandre Julliard 
Date:   Mon Mar 10 17:21:33 2008 +0100

gdi32: Properly handle SetDIBits failure in StretchDIBits.

:040000 040000 f41868fa8473ac088bde0a5af2677c295f2933e0
6225321637ba1fdcba7c06cc6f5bc5f3477ca0bb M      dlls

[Bug 12236] Irfanview: distorted image display

http://bugs.winehq.org/show_bug.cgi?id=12236

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Alexandre Julliard   2008-03-27 07:34:36 ---
I committed a fix.

[Bug 12236] Irfanview: distorted image display

http://bugs.winehq.org/show_bug.cgi?id=12236

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard   2008-04-04 10:07:07 ---
Closing bugs fixed in 0.9.59.