[Bug 46291] New: Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

Bug ID: 46291
           Summary: Blizzard update WoW to use DX12 and Multithread.
           Product: vkd3d
           Version: 1.1
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: vkd3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Shown below are the fixme that come from vkd3d, after the most recent Blizzard
patch to World of Warcraft.  Using Nvidia, driver 415.23, latest vkd3d from
git, and wine-4.0-rc1-36-gec2c2f9fa0 (Staging).

fixme:vkd3d_create_device: Unsupported feature level 0xc000.
fixme:d3d12_device_CheckFeatureSupport: Root signature version 1_1 not
supported yet.
fixme:vkd3d_serialize_root_signature: Ignoring error blob 0x25f418.
fixme:d3d12_root_signature_init: Ignoring root signature flags 0x1.
fixme:vkd3d_serialize_root_signature: Ignoring error blob 0x25f418.
fixme:d3d12_root_signature_init: Ignoring root signature flags 0x1.
fixme:rs_desc_from_d3d12: Ignoring MultisampleEnable 0x1.
fixme:d3d12_device_CheckFeatureSupport: Unhandled feature 0x4.
fixme:d3d12_command_queue_GetPrivateData: iface 0x7e5a6230, guid
{000000f0-0000-000d-c0f5-fed7c47f0000}, data_size 0x25f898, data 0x25f860 stub!

Tell me how I can help, since I can test and report back usually same day.

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

Ker noa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever confirmed|0                           |1

--- Comment #1 from Józef Kucia  ---
Thanks for the bug report. FIXMEs() aren't bugs per se. Please describe the
actual bug symptoms. See also https://wiki.winehq.org/Bugs for more information
about how to report bugs.

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

Sveinar Søpler  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Sveinar Søpler  ---
Created attachment 63010
  --> https://bugs.winehq.org/attachment.cgi?id=63010
Debug log for WoW 8.1

winedebug=+seh,+dxgi,+d3d12
VKD3D_DEBUG="trace"

After starting wow, there is only a black screen with the mousepointer visible.

This happened after latest WoW update (Patch 8.1) last wednesday 12/12-18.

Tested with custom wine-staging-4.0-rc1
vkd3d: git(4e66897a1efe9316f853febcad669876595611aa)

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #3 from Józef Kucia  ---
Created attachment 63011
  --> https://bugs.winehq.org/attachment.cgi?id=63011
WIP private data patch

The attached patch may help a little bit. I'll look into other issues later.

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #4 from Steve Ebey  ---
Allowed me to login, and once I selected a character, starting flashing, and
text above the npc were blocked. Took off on a gryphon from the flightmaster in
boralus and the game hard locked, with a single core on my cpu locked at 103%
usage.  What traces and debug do I need to provide?

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #5 from Józef Kucia  ---
Created attachment 63022
  --> https://bugs.winehq.org/attachment.cgi?id=63022
Update descriptors hack

This should fix the flashing.

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #6 from Sveinar Søpler  ---
Working fine Józef!

Patched vkd3d(4e66897a1efe9316f853febcad669876595611aa) with those two, and
played WoW with d3d12 for 4 hours with no issues :)

Thanks!

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #7 from Steve Ebey  ---
I concur, you did great Jozef. You always do.  Thank you very much.@Sveinar,
what version of driver are you running, and is it Nvidia or AMD? What is your
FPS around Boralus. Mine is kind of low, I am wondering if the DX12 threading
is working well on my AMD Cpu.

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #8 from Sveinar Søpler  ---
nVidia GTX970 4GB - driver 415.22.01
Intel 8700K

Wine-tkg-4.0-rc2 (Custom staging w/esync patches).

Seem to be higher cpu load with vkd3d/d3d12 (6-8 threads 70+% frequently) vs
dxvk, so not sure how it ties together tbh.

I get 60-70 fps in Boralus (Alliance), but if very crowded i can dip down
toward 50. From initial testing it seems slightly higher fps than dxvk, but
dxvk have higher max fps when "nothing happens" i guess.

PS. At times horrible serverlagg tho, so kinda hard to judge "performance"
after 8.1 vs. before.

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #9 from Steve Ebey  ---
my terrible fps was due to an addon, and not anything wine or vkd3d related. 
Also looked up the new MT cvars for wow, and added them to config.wtf.  My
system has very smooth graphics now, and insanely high fps, at or above Windows
10.  I am very pleased with how it works now, using DX12, and pure wine and
vkd3d. I can not overstate how happy I am, and thank everyone who gives up the
time needed to do this so that others can enjoy Linux and get clear of
Microsoft for all that we enjoy.  May all of the people involved have a
wonderful holiday season, and a prosperous new year.   Thank you all for the
work you do.  add the following lines to your config.wtf and see if you notice
a change in the overall performance now.

SET gxMTPrepass "1"
SET gxMTOpaque "1"
SET gxMTDisable "0"
SET gxMTBeginDraw "1"
SET gxMTShadow "1"

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #10 from Sveinar Søpler  ---
Probably making too much noise using this bugreport as a wow support page, but
the settings

SET gxMTPrepass "1"
SET gxMTOpaque "1"
SET gxMTDisable "0"
SET gxMTBeginDraw "1"
SET gxMTShadow "1"

Is (or should be) the default when enabling D3D12 for WoW.
They are automatically removed from the Config.wtf, and you can check the
setting active ingame by typing eg. /dump GetCVar("gxMTPrepass") (And you will
see its 1).

But WoW w/d3d12 actually works quite well atm (and these vkd3d patches), so
lets hope it wont suddenly break from some random Blizzard patch then :)

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from [e-mail] ---
Doesnt seem to be working on AMDGPU with stable version builds of
mesa/vulkan-radeon (18.3). Thou havent managed to get my Opensource AMD drivers
to launch any title with DX12 so problem might be lying more on there.
Upgrading to more recent gits might help there.

If anyone have tried to run vkd3d or even wow with AMD. Sharing some results
would be lovely.

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #12 from Sveinar Søpler  ---
I havent been able to run anything but WoW with vkd3d, so i cant give any other
examples to get it working.

AMD have so many different types of drivers mentioned, so i dunno what is
"good" when it comes to Vulkan tho, but are you running WoW with DXVK now?
And does the "gears-vkd3d" demo from the vkd3d package work?

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #13 from [e-mail] ---
(In reply to Sveinar Søpler from comment #12)
> I havent been able to run anything but WoW with vkd3d, so i cant give any
> other examples to get it working.
>
> AMD have so many different types of drivers mentioned, so i dunno what is
> "good" when it comes to Vulkan tho, but are you running WoW with DXVK now?
> And does the "gears-vkd3d" demo from the vkd3d package work?

Hmm ran gears-vkd3d and it appears to be running just fine without any errors.
Kind of an odd thing. Case it might not be vulkan/driver issue. Might also be
problem with game itself. Game keeps launching me for dx11 even i try to force
it dx12 mode. And i have all settings right win10 chosen etc. Blizzard support
have replied at forums that they are facing issues with people trying to enable
on it.

Atleast partly AMD side for me seems that i need to wait either one push fixes
for the issue. Thanks for the gears-vkd3d tip.

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #14 from Steve Ebey  ---
since this is the only way to report, some games, including WoW, are not seeing
the Nvidia Driver Version, so they think I am running an old driver. Can this
be fixed?

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #15 from Sveinar Søpler  ---
I have this in my /_retail_/Logs/Gx.log

12/30 17:08:51.833  <IsGPUDriverOutOfDate> No
12/30 17:08:57.748  <IsGPUDriverOutOfDate> No
12/30 17:08:57.788  <IsGPUDriverOutOfDate> No
12/30 17:12:52.962  <IsGPUDriverOutOfDate> No
12/30 18:00:17.007  <IsGPUDriverOutOfDate> No
12/30 18:50:23.705  <IsGPUDriverOutOfDate> No
12/30 18:50:23.911  D3d12 Device Destroy

I am using the nVidia 415.22.01 driver tho.

Do you get a different message? And if so: What driver are you using?

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #16 from Steve Ebey  ---
12/31 20:36:55.069  Nvidia driver version: r337_00 (33788)
12/31 20:36:55.092  <IsGPUDriverOutOfDate> Yes
12/31 20:37:21.283  Nvidia driver version: r337_00 (33788)
12/31 20:37:21.302  <IsGPUDriverOutOfDate> Yes
12/31 20:37:21.544  Nvidia driver version: r337_00 (33788)
12/31 20:37:21.569  <IsGPUDriverOutOfDate> Yes
12/31 22:49:06.087  Nvidia driver version: r337_00 (33788)
12/31 22:49:06.760  <IsGPUDriverOutOfDate> Yes

Driver is 415.25

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from [e-mail] ---
Ryzen 2700X
Vega 64
wine-tkg-4.0rc4 from https://github.com/lutris/wine/commits/tkg
Kernel 4.20.0
Mesa master, a week old
LLVM 8.0.0svn, two weeks old
vkd3d master + two patches

With the two patches on this ticket, WoW will run in DX12 mode, let me log in,
let me choose a character and then crash on the loading screen with an error
#132 - ACCESS_VIOLATION.

Weirdly, if I use VKD3D_DEBUG="trace" it brings up the login screen and
immediately crashes with error #132 - unknown exception.

I'll attach my log.

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #18 from [e-mail] ---
Created attachment 63150
  --> https://bugs.winehq.org/attachment.cgi?id=63150
Crash with Vega 64

Log with VKD3D_DEBUG="trace" from crash on Vega 64

[Bug 46291] Blizzard update WoW to use DX12 and Multithread.

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #19 from Sveinar Søpler  ---
@Steve Ebey
This driver "version" probably comes from the nvapi.dll (staging patches).

ref.
    NvAPI_ShortString build_str =
{'r','3','3','7','_','0','0','-','1','8','9',0};
    NvAPI_ShortString adapter = {'G','e','F','o','r','c','e',' ','9','9','9','
','G','T','X', 0};

You could try to disable nvapi, nvapi64, nvcuda, nvcuvid, nvencodeapi and
nvencodeapi64 on your wow prefix.

I have not done that tho, so not sure why WoW would complain about this when it
does not for me. Weird. But i use a slightly older driver version than you tho.

[Bug 46291] WoW needs d3d12_command_queue_GetPrivateData()

https://bugs.winehq.org/show_bug.cgi?id=46291

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
            Summary|Blizzard update WoW to use  |WoW needs
                   |DX12 and Multithread.       |d3d12_command_queue_GetPriv
                   |                            |ateData()
      Fixed by SHA1|                            |d18360a8b77d6f6be6d48f8207b
                   |                            |18fdd70d7ff8f

--- Comment #20 from Józef Kucia  ---
The original issue should be fixed
https://source.winehq.org/git/vkd3d.git/commit/d18360a8b77d6f6be6d48f8207b18...

Please open separate bug reports for remaining issues.

[Bug 46291] WoW needs d3d12_command_queue_GetPrivateData()

https://bugs.winehq.org/show_bug.cgi?id=46291

--- Comment #21 from Steve Ebey  ---
close.  had to use the patch, to fix the screen flash.  Crashed if I went to
pandaria also. Error 132

[Bug 46291] WoW needs d3d12_command_queue_GetPrivateData()

https://bugs.winehq.org/show_bug.cgi?id=46291

Steve Ebey  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #22 from Steve Ebey  ---
had to apply the patch that fixes the screen flash.

[Bug 46291] WoW needs d3d12_command_queue_GetPrivateData()

https://bugs.winehq.org/show_bug.cgi?id=46291

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #23 from Józef Kucia  ---
(In reply to Steve Ebey from comment #22)
> had to apply the patch that fixes the screen flash.

Please open a separate bug report.

[Bug 46291] WoW needs d3d12_command_queue_GetPrivateData()

https://bugs.winehq.org/show_bug.cgi?id=46291

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #24 from [e-mail] ---
I am having this same issue using the current vkd3d master branch (commit
c8e05a93b4e6680bcf82b0fbe7e81c8b5020b44b) -- Black screen after logging in
although I can move the cursor around. I've applied the "Update descriptors"
patch but the WIP patch no longer applies. I'm on an AMD RX580 with Mesa 18.3.2
and wine-staging 4.0. Let me know if I can provide any other information that
would be helpful.

[Bug 46291] WoW needs d3d12_command_queue_GetPrivateData()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46291

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #25 from Nikolay Sivov  ---
Closing bugs fixed in 1.10.