[Bug 35024] New: FEAR Combat (SEC2) installer doesn't display cd key/serial field

http://bugs.winehq.org/show_bug.cgi?id=35024

Bug #: 35024
           Summary: FEAR Combat (SEC2) installer doesn't display cd
                    key/serial field
           Product: Wine
           Version: 1.7.7
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Hello folks,

reported in WineHQ forums: http://forum.winehq.org/viewtopic.php?f=8&t=20420

This is not a dupe of bug 20456 ("FEAR's installer will not let me enter the
serial number due to wrong font").

The field is not displayed at all.

Regards

[Bug 35024] FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/serial field

http://bugs.winehq.org/show_bug.cgi?id=35024

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, Installer
                URL|                            |http://fear-community.org/d
                   |                            |ownloads/
            Summary|FEAR Combat (SEC2)          |FEAR Combat (SEC2) v1.1
                   |installer doesn't display   |community full installer
                   |cd key/serial field         |doesn't display cd
                   |                            |key/serial field

--- Comment #1 from Anastasius Focht  2013-11-30 16:10:14 CST ---
Hello folks,

filling fields...

$ sha1sum fear_combat_110_community_en_full.exe 
53e38d3d11620b22d46ff2596f62fe4a11461e1c  fear_combat_110_community_en_full.exe

$ du -sh fear_combat_110_community_en_full.exe 
1.4G    fear_combat_110_community_en_full.exe

$ wine --version
wine-1.7.7-230-g2507330

Regards

[Bug 35024] FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/serial field

http://bugs.winehq.org/show_bug.cgi?id=35024

--- Comment #2 from Anastasius Focht  2013-11-30 16:15:56 CST ---
Created attachment 46684
  --> http://bugs.winehq.org/attachment.cgi?id=46684
Screenshot showing invisible serial input field highlighed using Winspector

Hello folks,

attached is a screenshot which shows the invisible field highlighted using
Spy++ like 'Winspector' tool
(http://appdb.winehq.org/objectManager.php?sClass=application&iId=9148).
Right click the static field -> 'highlight' -> red rectangle will start to
flash, indicating the control position.

Regards

[Bug 35024] FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/serial field (no PIDTemplate property provided)

http://bugs.winehq.org/show_bug.cgi?id=35024

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |msi
            Summary|FEAR Combat (SEC2) v1.1     |FEAR Combat (SEC2) v1.1
                   |community full installer    |community full installer
                   |doesn't display cd          |doesn't display cd
                   |key/serial field            |key/serial field (no
                   |                            |PIDTemplate property
                   |                            |provided)

--- Comment #3 from Anastasius Focht  2013-11-30 17:42:47 CST ---
Hello folks,

it seems the msi based installer uses a masked edit field for serial number but
doesn't provide a "PIDTemplate" property.

"Control" table dumped with "ORCA":

--- snip ---
Dialog_    Control    Type    X    Y    Width    Height    Attributes   
Property    Text    Control_Next    Help
...
CDKeyDlg    Title    Text    11    9    220    18    196611        {\Title}New
Dialog    GlobalProgress    
CDKeyDlg    Next    PushButton    368    372    56    17    3       
[ButtonText_Next]    Cancel    
CDKeyDlg    Back    PushButton    312    372    56    17    3       
[ButtonText_Back]    Title    
CDKeyDlg    Cancel    PushButton    436    372    56    17    3       
[ButtonText_Cancel]    Back    
CDKeyDlg    Background    Bitmap    0    0    525    395    1048577       
[Background]    Next    
CDKeyDlg    CDKeyEdit    MaskedEdit    177    125    220    18    3    PIDKEY  
 [PIDTemplate]    Intro    
CDKeyDlg    Intro    Text    177    101    280    14    196611       
{\Intro}Enter your FEAR-Community.org cd-key:    Text_1    
CDKeyDlg    GlobalProgress    Bitmap    14    88    14    86    1048577       
[Collecting]    CollectingLabel    
CDKeyDlg    CollectingLabel    Text    35    90    104    11    65539       
{\Labels}Collecting information    PreparingLabel    
CDKeyDlg    PreparingLabel    Text    35    114    104    11    65539       
{\Labels}Preparing installation    InstallingLabel    
CDKeyDlg    InstallingLabel    Text    35    138    104    11    65539       
{\Labels}Installing    FinalizingLabel    
CDKeyDlg    FinalizingLabel    Text    35    162    104    11    65539       
{\Labels}Finalizing installation    CDKeyEdit    
CDKeyDlg    Text_1    Text    177    163    197    11    65539   
TEXT_1_PROP_1_1_1    Note: A free cd-key can be obtained by registering at   
Hyperlink_1    
CDKeyDlg    Hyperlink_1    Hyperlink    374    161    111    11    65539   
HYPERLINK_1_PROP_1    <a
href="http://fear-community.org">http://fear-community.org</a>    Background    
--- snip ---

Control in question: "CDKeyEdit"

Type: MaskedEdit
Attributes: 3
Property: PIDKEY
Text: [PIDTemplate]

Relevant trace log:

--- snip ---
...
0024:trace:msi:msi_get_property property L"PIDTemplate" not found
0024:trace:msi:msiobj_release object 0x1aada8 destroyed
0024:trace:msi:msi_dialog_parse_groups masked control, template L""
0024:trace:msi:msi_dialog_parse_groups 0 characters in 0 groups
0024:trace:msi:msi_dialog_add_control L"Static", L"CDKeyEdit", 00000003,
L"[PIDTemplate]", 1002000d
0024:trace:msi:MSI_DatabaseOpenViewW L"SELECT * FROM `EventMapping` WHERE
`Dialog_` = 'CDKeyDlg' AND `Control_` = 'CDKeyEdit'" 0x33f27c 
...
0024:trace:msi:msi_get_property property L"PIDTemplate" not found
0024:trace:msi:msiobj_release object 0x213ba0 destroyed
0024:trace:win:WIN_CreateWindowEx L"" L"Static" ex=00000000 style=5002000d
236,167 293x24 parent=0x5006c menu=(nil) inst=(nil) params=(nil)
0024:trace:win:dump_window_styles style: WS_CHILD WS_VISIBLE WS_GROUP 0000000d
0024:trace:win:dump_window_styles exstyle:
0024:trace:win:WIN_SetWindowLong 0x7006e -12 0 W 
...
0024:trace:win:WIN_CreateWindowEx created window 0x7006e
0024:trace:msi:dialog_create_window Dialog L"CDKeyDlg" control L"[PIDTemplate]"
hwnd 0x7006e
0024:trace:win:WIN_SetWindowLong 0x7006e 0 50043 W
0024:trace:win:RedrawWindow 0x7006e whole window flags: RDW_INVALIDATE
RDW_ERASE RDW_ALLCHILDREN RDW_UPDATENOW 
...
0024:trace:msi:msi_get_property returning L"1111-2222-3333-4444" for property
L"PIDKEY"
0024:trace:msi:msiobj_release object 0x1aacf0 destroyed
0024:trace:msi:MSI_ViewFetch 0x1a12f8 0x33f3d0
0024:trace:msi:msi_view_get_row 0x129708 0x1aaec8 6 0x33f3d0
0024:trace:msi:msi_dialog_text_control 0x1a2060 0x1aacf0 
--- snip ---

I passed 'PIDKEY=1111-2222-3333-4444' property to msi installer by command line
for better indication.
During debugging I injected a non-empty PIDTemplate and the field was shown.
Sadly modifying .msi with ORCA is not possible with Wine.

Regards

[Bug 35024] FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/serial field (no PIDTemplate property provided)

http://bugs.winehq.org/show_bug.cgi?id=35024

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |3271b982632e7730d6cee373f4c
                   |                            |9a4af37012036
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Anastasius Focht  2013-12-02 15:03:55 CST ---
Hello folks,

this is fixed by commit
http://source.winehq.org/git/wine.git/commitdiff/3271b982632e7730d6cee373f4c...

Thanks Hans.

The cd key/serial number input field is now properly shown.
Though I don't have a valid serial to check with.

Regards

[Bug 35024] FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/serial field (no PIDTemplate property provided)

http://bugs.winehq.org/show_bug.cgi?id=35024

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2013-12-06 13:44:37 CST ---
Closing bugs fixed in 1.7.8.

[Bug 35024] FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/serial field (no PIDTemplate property provided)

https://bugs.winehq.org/show_bug.cgi?id=35024

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.6.x

[Bug 35024] FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/serial field (no PIDTemplate property provided)

https://bugs.winehq.org/show_bug.cgi?id=35024

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.6.x                       |---

--- Comment #6 from Alexandre Julliard  ---
Removing 1.6.x milestone from bugs included in 1.6.2.

[Bug 35024] FEAR Combat (SEC2) v1.1 community full installer doesn't display cd key/serial field (no PIDTemplate property provided)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=35024

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://fear-community.org/d |https://web.archive.org/web
                   |ownloads/                   |/20140305012707/http://down
                   |                            |load2.fear-combat.org/fear_
                   |                            |combat_110_community_en_ful
                   |                            |l.exe

--- Comment #7 from Anastasius Focht  ---
Hello folks,

adding stable download via Internet Archive for documentation.

https://web.archive.org/web/20131114234049/http://fear-community.org/downloa...

https://web.archive.org/web/20140305012707/http://download2.fear-combat.org/...

$ sha1sum fear_combat_110_community_en_full.exe 
53e38d3d11620b22d46ff2596f62fe4a11461e1c  fear_combat_110_community_en_full.exe

$ du -sh fear_combat_110_community_en_full.exe 
1.4G    fear_combat_110_community_en_full.exe

Regards