[Bug 52236] New: Performance regression in Eden's Ritter - Chapter 2 (demo) - wine-bugs

List overview All Threads

newer

[Bug 52236] New: Performance regression in Eden's Ritter - Chapter 2 (demo)

older

[Bug 46915] New: Black boder...

[Bug 52503] New: CCextractor 0.94...

WineHQ Bugzilla

18 Dec 2021 18 Dec '21

12:36 p.m.

https://bugs.winehq.org/show_bug.cgi?id=52236

Bug ID: 52236 Summary: Performance regression in Eden's Ritter - Chapter 2 (demo) Product: Wine Version: 7.0-rc2 Hardware: x86-64 URL: https://web.archive.org/web/20191215150009if_/http://s ample9.dmm.co.jp/digital/pcgame/waffle_0102/waffle_010 2t.zip OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs@winehq.org Reporter: sagawa.aki+winebugs@gmail.com Regression SHA1: 4261369e5d8f1d71e8d207474751585fe9f90cc5 Distribution: Ubuntu

Eden's Ritter - Chapter 2[1] is a NSFW visual novel released by Waffle in Japan. I started its trial version with wine 6.0-rc2, and noticed its performance was poorer than before. My git bisecting shows commit 4261369e5d8[2] causes the issue.

[1] https://vndb.org/v24582 [2] https://source.winehq.org/git/wine.git/commit/4261369e5d8f1d71e8d20747475158...

After the commit, window update is too slow to play the game. My desktop environment is also sometimes unresponsive. However, WINEDEBUG=fps shows very high value, approx 120.

Before the commit, I can play the game without this issue. WINEDEBUG=fps is nearly 60fps.

This issue might be a duplicate of Bug 51848, but the FPS is still low.

SHA1(waffle_0102t.zip) = 1e6345f82f1ed772163005ad63c5ca778ba9128e

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Show replies by date

WineHQ Bugzilla

18 Dec 18 Dec

12:39 p.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

--- Comment #1 from Sagawa sagawa.aki+winebugs@gmail.com --- Created attachment 71341 --> https://bugs.winehq.org/attachment.cgi?id=71341 WINEDEBUG=fps,timestamp,d3d,d3d8 with Wine 6.17

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

12:40 p.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

--- Comment #2 from Sagawa sagawa.aki+winebugs@gmail.com --- Created attachment 71342 --> https://bugs.winehq.org/attachment.cgi?id=71342 WINEDEBUG=fps,timestamp,d3d,d3d8 with Wine 7.0rc2

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4:37 p.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

Zebediah Figura z.figura12@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

19 Dec 19 Dec

2:54 a.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

Sagawa sagawa.aki+winebugs@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, performance

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

21 Dec 21 Dec

5:13 a.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

Conor McCarthy cmccarthy@codeweavers.com changed:

--- Comment #3 from Conor McCarthy cmccarthy@codeweavers.com --- Definitely a duplicate of 51848. In both cases the problem doesn't occur if context_choose_pixel_format() is prevented from choosing a pixel format with swap method WGL_SWAP_COPY_ARB.

*** This bug has been marked as a duplicate of bug 51848 ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

24 Dec 24 Dec

7:32 a.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #4 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Closing Duplicate.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

4 Jan 4 Jan

1:48 p.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

--- Comment #5 from Henri Verbeet hverbeet@gmail.com --- Does the patch attached to bug 51848 help here as well?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

5 Jan 5 Jan

1:23 p.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

Sagawa sagawa.aki+winebugs@gmail.com changed:

--- Comment #6 from Sagawa sagawa.aki+winebugs@gmail.com --- I've tested bug 51848 patch. Unfortunately, it doesn't work for ER2. With the patch, wine shows the following X11 error: --- X Error of failed request: BadWindow (invalid Window parameter) Major opcode of failed request: 7 (X_ReparentWindow) Resource id in failed request: 0x4c00063 Serial number of failed request: 267 Current serial number in output stream: 268 ---

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

1:25 p.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

Sagawa sagawa.aki+winebugs@gmail.com changed:

--- Comment #7 from Sagawa sagawa.aki+winebugs@gmail.com --- Created attachment 71512 --> https://bugs.winehq.org/attachment.cgi?id=71512 WINEDEBUG=fps,wgl,timestamp,d3d,d3d8

Tested with 9ef5c9c0090f17df5bfd794485019fb8bf9a7e25 + bug 51848 patch.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

1:34 p.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

--- Comment #8 from Sagawa sagawa.aki+winebugs@gmail.com --- I forgot to mention additional trace messages. To show whether the patch works, I added the following messages in the branches: "wglSetPixelFormatWINE with 0" for wined3d_context_gl_cleanup, "!format && allow_change" for set_pixel_format.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

7 Jan 7 Jan

3:24 p.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

--- Comment #9 from Henri Verbeet hverbeet@gmail.com --- Created attachment 71548 --> https://bugs.winehq.org/attachment.cgi?id=71548 patch

It looks like that happens because destroy_gl_drawable() ends up destroying "gl->window", but doesn't clear the "client_window" field in the x11drv_win_data structure.

The attached patch gets around it, but I'm not at all confident it's reasonable or correct. It's probably going to require either me reading up on how the OpenGL parts of winex11 work these days, or a look from someone that already understands that code.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

9 Jan 9 Jan

1:09 p.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

Sagawa sagawa.aki+winebugs@gmail.com changed:

--- Comment #10 from Sagawa sagawa.aki+winebugs@gmail.com --- The issue is fixed after applying the attached patch. It works nearly 60fps, again. Thanks, Henri.

*** This bug has been marked as a duplicate of bug 51848 ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

2 Feb 2 Feb

6:19 a.m.

New subject: [Bug 52236] Performance regression in Eden's Ritter - Chapter 2 (demo)

https://bugs.winehq.org/show_bug.cgi?id=52236

Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #11 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Closing Duplicate.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1058

Age (days ago)

1104

Last active (days ago)

wine-bugs@winehq.org

13 comments

1 participants

tags (0)

participants (1)

WineHQ Bugzilla