http://bugs.winehq.org/show_bug.cgi?id=21668
Summary: Regression -?> Unable to Play Rise of Nations Thrones and Patriots Product: Wine Version: 1.1.38 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: marcelo_javier_ruiz@yahoo.com.ar
Following the instructions in WineAppDb I was able to install and run with no problems Rise of Nations Thrones & Patriots. After upgrading to wine 1.1.38 the program would not start giving the following message:
wine BHGRTS runtime fatal failed to locate basic building graphic key: HOUSE35
rolling back version to 1.1.37 solves the problem.
http://bugs.winehq.org/show_bug.cgi?id=21668
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Summary|Regression -?> Unable to |Unable to Play Rise of |Play Rise of Nations |Nations Thrones and |Thrones and Patriots |Patriots
--- Comment #1 from Vitaliy Margolen vitaliy@kievinfo.com 2010-02-09 19:43:46 --- Post results of regression testing as described here: http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=21668
Matej Spindler matej.spindler@auspuh.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |matej.spindler@auspuh.com
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #2 from Matej Spindler matej.spindler@auspuh.com 2010-02-20 11:36:10 --- Confirming this one !
Regression testing showed two commits are to blame.
Frst: 4f1d040eaf7ecdd519848f75485b7844dda2b82b is first bad commit commit 4f1d040eaf7ecdd519848f75485b7844dda2b82b Author: Nikolay Sivov bunglehead@gmail.com Date: Wed Feb 3 03:49:37 2010 +0300
Add stub msxml4.dll.
:100755 100755 2cd384dea6f82c450a4606b7db769f5381f942b3 f60272d1e8b90999a2467a8936293c76a4846218 M configure :100644 100644 8016dd712571ed484ce979fb91fbc77e2c5ac017 24aac13662259086fa3b89f49ccffdfb1ed3fbb9 M configure.ac :040000 040000 d577f23e42adaed4f396cc0f9f2ab0bfc93aeea2 6a04444316e68741127577cf7430df52ca921822 M dlls
After that commit game crashes because of unimplemented function in msxml4.
Second: bc3153affa78ee62742a81fb224da13cb6e67810 is first bad commit commit bc3153affa78ee62742a81fb224da13cb6e67810 Author: Nikolay Sivov bunglehead@gmail.com Date: Wed Feb 3 22:34:45 2010 +0300
msxml4: Add self-registration for CLSID_DOMDocument40, accept it in classfactory.
:040000 040000 c50760d9ee289c0ba4274d0756b54a4608f28eaa c3fc2006d930b702c5a4be51f93b1c6d88dd6042 M dlls :040000 040000 6d391ab6229619a4301124ca8f4fa6a1788c7a18 2a47c99dca26a42cff3c574c91286400b7d3891b M include :040000 040000 bb44fe8411909a71255310fff857f64a694481f9 f4b15d6791b8ec6256a17b43a8d442c6eb70a997 M tools
Here we get to error message Marcelo R reported.
Setting msxml4 to native fixes the problems. So until msxml4 implementation gets more complete native dll will be required!
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com 2010-02-20 11:45:11 --- (In reply to comment #2)
Confirming this one !
Regression testing showed two commits are to blame.
How did you two commits as a bisect result? Did you run two regression tests?
Anyway update to 1.1.39, msxml4 should have these unimplemented calls now.
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #4 from Matej Spindler matej.spindler@auspuh.com 2010-02-20 12:13:19 --- (In reply to comment #3)
(In reply to comment #2)
Confirming this one !
Regression testing showed two commits are to blame.
How did you two commits as a bisect result? Did you run two regression tests?
Anyway update to 1.1.39, msxml4 should have these unimplemented calls now.
Yes two regression test. When I was testing i noticed I get two different behaviors.
Wine is updated to 1.1.39!
After some more digging with +msxml log I found:
... trace:msxml:domelem_Release (0x1af3f88) ref=2 trace:msxml:xmlnode_get_text (0x1af3f88, type 1)->(0x32f208) trace:msxml:xmlnode_get_text 0x1af3f88 L"HOUSE35\t" trace:msxml:domelem_Release (0x1af3f88) ref=1 ...
And the xml file really has tab after HOUSE35:
... <NAME>House</NAME> <TYPENAME>House F5</TYPENAME> <GRAPH>HOUSE35 </GRAPH> <OBJ_MASKS>R</OBJ_MASKS> <BUILD_FLAGS>ea</BUILD_FLAGS> ...
There i probably a bug in how wine handles special characters.
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com 2010-02-20 12:20:08 --- (In reply to comment #4)
(In reply to comment #3)
(In reply to comment #2)
Confirming this one !
Regression testing showed two commits are to blame.
How did you two commits as a bisect result? Did you run two regression tests?
Anyway update to 1.1.39, msxml4 should have these unimplemented calls now.
Yes two regression test. When I was testing i noticed I get two different behaviors.
Wine is updated to 1.1.39!
Ok, so it works with 1.1.39 or not?
After some more digging with +msxml log I found:
... trace:msxml:domelem_Release (0x1af3f88) ref=2 trace:msxml:xmlnode_get_text (0x1af3f88, type 1)->(0x32f208) trace:msxml:xmlnode_get_text 0x1af3f88 L"HOUSE35\t" trace:msxml:domelem_Release (0x1af3f88) ref=1 ...
And the xml file really has tab after HOUSE35:
... <NAME>House</NAME> <TYPENAME>House F5</TYPENAME> <GRAPH>HOUSE35 </GRAPH> <OBJ_MASKS>R</OBJ_MASKS> <BUILD_FLAGS>ea</BUILD_FLAGS> ...
Note that I know nothing about your, and its conf files.
There i probably a bug in how wine handles special characters.
I don't know what expected behaviour is here. Please remove your .wine, install this app with 1.1.39 and let's start at this point (report any failures running clean configuration).
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #6 from Matej Spindler matej.spindler@auspuh.com 2010-02-20 12:51:52 --- OK as you wish.
I'm on ubuntu 9.10. Now I'm using wine from Scott Ritchie's PPA. Version is wine-1.1.39.
Installed the game in new wineprefix. Installer insist in installing msxml4 redistributable. The game installs fine no errors or anything!
When I start the game a window pops up saying: failed to locate basic building graphic key: HOUSE35. I'm attaching the screenshot from the game startup.
So the bottom line is new and clean wineprefix, new install, latest wine from a PPA and the game DOES NOT RUN!
Now some more testing:
WINEDLLOVERRIDES=msxml4=native wine patriots.exe WORKS OK WINEDLLOVERRIDES=msxml4=builtin wine patriots.exe DOES NOT WORK
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #7 from Matej Spindler matej.spindler@auspuh.com 2010-02-20 12:56:30 --- Created an attachment (id=26346) --> (http://bugs.winehq.org/attachment.cgi?id=26346) Screenshot of the game starting
http://bugs.winehq.org/show_bug.cgi?id=21668
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |msxml4
--- Comment #8 from Nikolay Sivov bunglehead@gmail.com 2010-02-20 13:07:26 --- (In reply to comment #6)
Installed the game in new wineprefix. Installer insist in installing msxml4 redistributable. The game installs fine no errors or anything!
This really deserves a separate report, we need to figure out why check for msxml4 failed. Probably it looks at version resource and we don't have any yet.
When I start the game a window pops up saying: failed to locate basic building graphic key: HOUSE35. I'm attaching the screenshot from the game startup.
Ok, this is what this bug is about. Attach +msxml please running this game until error message. It's also interesting to check this way - use clean .wine and install native msxml4 before game installation, install a game and compare xml files that are created with native and builtin msxml4 (probably we're failing to properly write files too if this is created during installation).
http://bugs.winehq.org/show_bug.cgi?id=21668
Pavel Ondracka drakkk@centrum.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |drakkk@centrum.cz
--- Comment #9 from Pavel Ondracka drakkk@centrum.cz 2010-02-20 13:14:25 --- There is a demo version showing this issue: http://www.gamershell.com/download_5641.shtml
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #10 from Matej Spindler matej.spindler@auspuh.com 2010-02-20 13:32:17 --- Created an attachment (id=26349) --> (http://bugs.winehq.org/attachment.cgi?id=26349) +msxml log
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #11 from Matej Spindler matej.spindler@auspuh.com 2010-02-20 13:41:20 --- (In reply to comment #8)
It's also interesting to check this way - use clean .wine and install native msxml4 before game installation, install a game and compare xml files that are created with native and builtin msxml4 (probably we're failing to properly write files too if this is created during installation).
Files aren't created during installation. All xml files are on the CD and installer just copies them.
http://bugs.winehq.org/show_bug.cgi?id=21668
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.gamershell.com/d | |ownload_5641.shtml
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #12 from Nikolay Sivov bunglehead@gmail.com 2010-02-20 14:06:09 --- Looks like a unimplemented *_preserveWhiteSpace functionality or something related. We already have tests that still fail on such nodes.
As a workaround please try to remove tab char from your file and try again.
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #13 from Matej Spindler matej.spindler@auspuh.com 2010-02-20 14:37:19 --- Removing the tab char from xml file does let the game run normal.
p.s. HOUSE35 key is in: PATH_TO_RON/Thrones\ and\ Patriots/data/buildingrules.xml
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #14 from Nikolay Sivov bunglehead@gmail.com 2010-10-04 15:22:21 CDT --- Please test with 1.3.4.
Commit 49fa9de580814028e3224e9d9eb6472bf11092be added a white space handler.
http://bugs.winehq.org/show_bug.cgi?id=21668
Keldon Jones keldon@keldon.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |keldon@keldon.net
--- Comment #15 from Keldon Jones keldon@keldon.net 2010-10-09 12:50:26 CDT --- Bug still exists in 1.3.4.
The change in commit 49fa9de580814028e3224e9d9eb6472bf11092be would only have an effect in the entire string passed was whitespace. But it is called with a string of "HOUSE35\t..." and a len of 8. Currently, the entire "HOUSE35\t" is passed unchanged to xmlSAX2characters().
Something like the patch in http://www.winehq.org/pipermail/wine-patches/2010-August/092802.html (which seems to not have been applied) would work in this case, except that it only trims nodes of type XML_TEXT_NODE, but the node here is of type XML_ELEMENT_NODE instead.
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #16 from Adam Martinson amartinson@codeweavers.com 2010-11-03 14:34:00 CDT --- Created an attachment (id=31711) --> (http://bugs.winehq.org/attachment.cgi?id=31711) Patch
Try with this on top of current git please. If it doesn't work, please attach a +msxml log.
http://bugs.winehq.org/show_bug.cgi?id=21668
--- Comment #17 from Keldon Jones keldon@keldon.net 2010-11-03 15:16:46 CDT --- (In reply to comment #16)
Try with this on top of current git please. If it doesn't work, please attach a +msxml log.
This does appear to fix the problem for me.
http://bugs.winehq.org/show_bug.cgi?id=21668
Adam Martinson amartinson@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #31711|0 |1 is obsolete| |
--- Comment #18 from Adam Martinson amartinson@codeweavers.com 2010-11-04 17:24:04 CDT --- (From update of attachment 31711) See commit 85ced167bd68e882900085ea50f25897e8457172
http://bugs.winehq.org/show_bug.cgi?id=21668
Adam Martinson amartinson@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |amartinson@codeweavers.com
--- Comment #19 from Adam Martinson amartinson@codeweavers.com 2010-11-08 14:02:43 CST --- (In reply to comment #17)
This does appear to fix the problem for me.
This fixed for everyone on current git?
http://bugs.winehq.org/show_bug.cgi?id=21668
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED CC| |mstefani@redhat.com Resolution| |FIXED
--- Comment #20 from Michael Stefaniuc mstefani@redhat.com 2010-11-15 17:12:24 CST --- Tested it with the demo and it works for me. Cross checked that 85ced167bd68e882900085ea50f25897e8457172 is indeed the patch that fixes this: 85ced167bd68e882900085ea50f25897e8457172^ - BAD 85ced167bd68e882900085ea50f25897e8457172 - GOOD Thanks Adam!
http://bugs.winehq.org/show_bug.cgi?id=21668
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #21 from Alexandre Julliard julliard@winehq.org 2010-11-26 13:14:25 CST --- Closing bugs fixed in 1.3.8.
http://bugs.winehq.org/show_bug.cgi?id=21668
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shiningarcanine@gmail.com
--- Comment #22 from Austin English austinenglish@gmail.com 2010-11-26 14:47:17 CST --- *** Bug 25303 has been marked as a duplicate of this bug. ***
-
wine-bugs＠winehq.org