https://bugs.winehq.org/show_bug.cgi?id=44334
Bug ID: 44334 Summary: 'start /W "" notepad' does not wait as on native. Product: Wine Version: 3.0-rc5 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: cmd Assignee: wine-bugs@winehq.org Reporter: bernhardu@mailbox.org Distribution: ---
Created attachment 60210 --> https://bugs.winehq.org/attachment.cgi?id=60210 cmd: Avoid having first parameter to start.exe ignored.
Tried to have a look into #44236. There a batch script is executed but the start commands did not wait until the started processes did end.
Example line: --- start /W " " "%SFDIR%automesh" wr2300 ---
As far as I see this is because when WCMD_start encounters an title parameter, it removes the executable from the cmdline parameter to CreateProcessW. --- start /W "" notepad 002f:trace:process:create_process_impl app L"C:\windows\command\start.exe" cmdline L"/W "\"\"" notepad" --- This get not recognized much, because usually the title is the first parameter and is therefore ignored by start.exe. But start.exe get executed because it is also in the file parameter to CreateProcessW.
Attached is a patch that tries to maintain the executable as first parameter in the cmdline parameter to CreateProcessW.
https://bugs.winehq.org/show_bug.cgi?id=44334
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de Status|UNCONFIRMED |NEW Keywords| |patch Ever confirmed|0 |1
--- Comment #1 from Fabian Maurer dark.shadow4@web.de --- Looks fine to me. If possible, add a test case, too. Do you sent it to the mailing list after codefreeze?
https://bugs.winehq.org/show_bug.cgi?id=44334
--- Comment #2 from Bernhard Übelacker bernhardu@mailbox.org --- Created attachment 60229 --> https://bugs.winehq.org/attachment.cgi?id=60229 md/tests: Test if start really waits when /W is first parameter.
Adding a test case. Should I hold it back until freeze is over? Or is it that small and/or important to try to get it integrated in 3.0?
https://bugs.winehq.org/show_bug.cgi?id=44334
Bernhard Übelacker bernhardu@mailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #60229|md/tests: Test if start |cmd/tests: Test if start description|really waits when /W is |really waits when /W is |first parameter. |first parameter.
https://bugs.winehq.org/show_bug.cgi?id=44334
--- Comment #3 from Fabian Maurer dark.shadow4@web.de --- Did you already send it in? Since code-freeze is over, it would make sense now.
https://bugs.winehq.org/show_bug.cgi?id=44334
--- Comment #4 from Bernhard Übelacker bernhardu@mailbox.org --- Patch sent: https://www.winehq.org/pipermail/wine-devel/2018-January/121756.html
https://bugs.winehq.org/show_bug.cgi?id=44334
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Fixed by SHA1| |f95b85a856d06c93b316aca40a1 | |481b4af6e814e
--- Comment #5 from Dmitry Timoshkov dmitry@baikal.ru --- The patch was finally accepted, thanks Bernhard.
https://bugs.winehq.org/show_bug.cgi?id=44334
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 3.8.
https://bugs.winehq.org/show_bug.cgi?id=44334
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x
https://bugs.winehq.org/show_bug.cgi?id=44334
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |---
--- Comment #7 from Michael Stefaniuc mstefani@winehq.org --- Removing the 3.0.x milestone from bugs included in 3.0.3.