[Bug 28691] New: Korg M1 DLE main display corrupted in later versions of Wine (eg 1.3.29)

http://bugs.winehq.org/show_bug.cgi?id=28691

Bug #: 28691
           Summary: Korg M1 DLE main display corrupted in later versions
                    of Wine (eg 1.3.29)
           Product: Wine
           Version: 1.3.29
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Main display is corrupted as per attachment.  This was OK in Wine Version
1.2.21.

[Bug 28691] Korg M1 DLE main display corrupted in later versions of Wine (eg 1.3.29)

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #1 from Tony Austin  2011-10-13 06:17:39 CDT ---
Created attachment 36877
  --> http://bugs.winehq.org/attachment.cgi?id=36877
Display has black streaks diagonally

[Bug 28691] Korg M1 DLE main display corrupted in later versions of Wine (eg 1.3.29)

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #2 from Tony Austin  2011-10-13 06:18:56 CDT ---
Sorry, I should have said - was OK in Version 1.3.15.

[Bug 28691] Korg M1 DLE main display corrupted in later versions of Wine (eg 1.3.29)

http://bugs.winehq.org/show_bug.cgi?id=28691

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

--- Comment #3 from Dmitry Timoshkov  2011-10-13 08:53:50 CDT ---
http://bugs.winehq.org/page.cgi?id=fields.html#bug_severity

Please post the results of your regression testing:
http://wiki.winehq.org/RegressionTesting

[Bug 28691] Korg M1 DLE main display corrupted in later versions of Wine (eg 1.3.29)

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #4 from Tony Austin  2011-10-13 09:08:05 CDT ---
Dmitry: Please can you explain exactly what you would like me to do.  I don't
understand what you mean by "regression testing" in this instance.

[Bug 28691] Korg M1 DLE main display corrupted in later versions of Wine (eg 1.3.29)

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #5 from Tony Austin  2011-10-13 09:14:57 CDT ---
Created attachment 36882
  --> http://bugs.winehq.org/attachment.cgi?id=36882
Main display as it should be

Suddenly, I think I know what you meant.

Attached is screenshot of how the Korg M1 main screen should look.

[Bug 28691] Korg M1 DLE main display corrupted in later versions of Wine (eg 1.3.29)

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #6 from Dmitry Timoshkov  2011-10-13 09:39:03 CDT ---
(In reply to comment #4)
> Dmitry: Please can you explain exactly what you would like me to do.  I don't
> understand what you mean by "regression testing" in this instance.

The wiki page referenced above has all the details.

[Bug 28691] Korg M1 DLE main display corrupted in later versions of Wine (eg 1.3.29)

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #7 from Tony Austin  2011-10-13 09:52:55 CDT ---
I sorry that is all way over my head - I am an Ubuntu end user and I use
Synaptic Package Manager to install software.  That's about as technical as it
gets for me.

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Korg M1 DLE main display    |Korg M1 DLE main display
                   |corrupted in later versions |corrupted
                   |of Wine (eg 1.3.29)         |

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #8 from Austin English  2011-10-13 13:21:42 CDT ---
(In reply to comment #7)
> I sorry that is all way over my head - I am an Ubuntu end user and I use
> Synaptic Package Manager to install software.  That's about as technical as it
> gets for me.

Use the forum for help.

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #9 from Tony Austin  2011-10-20 02:20:41 CDT ---
Using winetricks gdiplus with 1.3.30 eliminates the corrupted display reported
in this bug.

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |gdiplus

--- Comment #10 from Austin English  2011-10-20 16:33:12 CDT ---
(In reply to comment #9)
> Using winetricks gdiplus with 1.3.30 eliminates the corrupted display reported
> in this bug.

Please attach a +gdiplus trace with builtin gdiplus.

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #11 from Tony Austin  2011-10-21 08:12:15 CDT ---
Austin
> Please attach a +gdiplus trace with builtin gdiplus.

I'm not quite sure what it is that you are asking me for.  When I launch Korg
M1 from a terminal I get a whole pile of messages like these:

fixme:gdiplus:GdipDrawLine graphics object has no HDC
fixme:gdiplus:GdipDrawLine graphics object has no HDC
fixme:gdiplus:GdipDrawRectangle graphics object has no HDC
fixme:gdiplus:GdipDrawRectangle graphics object has no HDC
fixme:gdiplus:GdipDrawRectangle graphics object has no HDC

I don't know if there is a different error right up the top 'cos it's vanished
out the buffer.

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #12 from Vincent Povirk  2011-10-21 10:44:49 CDT ---
Those messages are probably not the cause of this bug.

For instructions on getting a debug trace, see
http://wiki.winehq.org/FAQ#head-16da35b6327024d6ea576e3678488b16862d0f5e

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #13 from Tony Austin  2011-10-21 14:45:08 CDT ---
Created attachment 37043
  --> http://bugs.winehq.org/attachment.cgi?id=37043
from debug trace +gdiplus

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #14 from Tony Austin  2011-10-23 01:41:13 CDT ---
The bug was introduced between Wine 1.3.15 and 1.3.16.  It seems to be a
problem in gdiplus since replacing this dll in Winetricks cures the problem.

I am studying the regression test instructions with some dread.  Is this still
necessary?

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #15 from Vincent Povirk  2011-10-23 10:26:36 CDT ---
I think you've provided enough information that it's not necessary. The
log/screenshot/versions suggest the bad commit was
2ce5be2ce3e36250c588523dfc27261283fcab41, which made the GdipFillPie function
work when it wouldn't have before. (And it almost works correctly, as you can
see the "PAN" and other circular indicators are now filled in, and they weren't
before. The shape just has some incorrect points for some reason.)

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |2ce5be2ce3e36250c588523dfc2
                   |                            |7261283fcab41

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

Tony Austin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.29                      |1.3.31

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.31                      |1.3.29

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #16 from Vincent Povirk  2011-11-02 10:27:42 CDT ---
Created attachment 37259
  --> http://bugs.winehq.org/attachment.cgi?id=37259
fix calculation of the center of a pie

Does this patch fix it?

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #17 from Tony Austin  2011-11-02 10:33:10 CDT ---
Vincent, thanks for that.

Presumably I have to compile the dll.  Where can I find instructions on how to
do this.?

Sorry I'm as not much of a geek as you might wish me to be.  ;-)

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #18 from Austin English  2011-11-02 12:22:23 CDT ---
(In reply to comment #17)
> Vincent, thanks for that.
>
> Presumably I have to compile the dll.  Where can I find instructions on how to
> do this.?
>
> Sorry I'm as not much of a geek as you might wish me to be.  ;-)

http://wiki.winehq.org/FAQ#head-ce0f398b298dc31add49d49671b302b020e234bb /
http://wiki.winehq.org/Patching

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #19 from Tony Austin  2011-11-03 18:48:49 CDT ---
Vincent, your patch seems to fix the problem.

I downloaded wine-1.3.31.tar.bz2 and ran the patch against that, compiled and
tested.  I think I did it right and the display corruption is fixed.

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #20 from Frédéric Delanoy  2013-06-30 18:38:37 CDT ---
Is this bug fixed in current wine (1.4-rc6 or later)?

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

--- Comment #21 from Frédéric Delanoy  2013-06-30 18:39:15 CDT ---
(In reply to comment #20)
> Is this bug fixed in current wine (1.4-rc6 or later)?

I mean, 1.6-rc4

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |006e2d97b3ca33d6140e24308a4
                   |                            |3c37b54dfe402
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #22 from Bruno Jesus  2013-06-30 21:10:56 CDT ---
Fixed long ago by
http://source.winehq.org/git/wine.git/commitdiff/006e2d97b3ca33d6140e24308a4...

[Bug 28691] Korg M1 DLE main display corrupted

http://bugs.winehq.org/show_bug.cgi?id=28691

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #23 from Alexandre Julliard  2013-07-12 13:47:26 CDT ---
Closing bugs fixed in 1.6-rc5.