[Bug 18734] New: DlgDirList(DDL_DRIVES|DDL_DIRECTORY) on 16-bits displays files on listbox in Windows but not Wine.
http://bugs.winehq.org/show_bug.cgi?id=18734
Summary: DlgDirList(DDL_DRIVES|DDL_DIRECTORY) on 16-bits displays files on listbox in Windows but not Wine. Product: Wine Version: 1.1.22 Platform: PC OS/Version: Linux Status: NEW Keywords: download, patch, source, win16 Severity: normal Priority: P2 Component: user32 AssignedTo: wine-bugs@winehq.org ReportedBy: a_villacis@palosanto.com
Created an attachment (id=21484) --> (http://bugs.winehq.org/attachment.cgi?id=21484) Screenshot of problem (QEMU virtual session and Wine, side by side)
When an 16-bit Windows application displays a listbox and manually fills it with DlgDirList (not as a part of a Common Dialog), the flag combination DDL_DRIVES|DLL_DIRECTORY should make files appear according to the set filter. Wine does not do this, as it (incorrectly) appends DDL_EXCLUSIVE to the bitmask of flags before delegating to 32-bit code.
http://bugs.winehq.org/show_bug.cgi?id=18734
--- Comment #1 from Alex Villacís Lasso a_villacis@palosanto.com 2009-06-01 11:50:00 --- Created an attachment (id=21485) --> (http://bugs.winehq.org/attachment.cgi?id=21485) Test program used to generate screenshot (source plus 16-bit binary)
This is a test program I created to see the actual behavior of DlgDirList in 16-bits. The program allows to modify the flags passed into DlgDirList, as well as the filter. The default state of the program is the one that exhibits the bug. The previous screenshot shows the Wine execution of the program, as well as a QEMU virtual machine running Windows 98, and a run of the test program from a Samba share into the host machine.
Program was compiled with the Watcom compiler.
http://bugs.winehq.org/show_bug.cgi?id=18734
--- Comment #2 from Alex Villacís Lasso a_villacis@palosanto.com 2009-06-01 11:52:36 --- Created an attachment (id=21486) --> (http://bugs.winehq.org/attachment.cgi?id=21486) Add DLL_EXCLUSIVE flag only when flagset equals DDL_DRIVES
This is a possible patch that fixes the behavior for me. The patch adds the DDL_EXCLUSIVE flag only if the original bitmask is exactly equal to DDL_DRIVES. This makes the program behavior match the one on Windows 98.
http://bugs.winehq.org/show_bug.cgi?id=18734
--- Comment #3 from Dmitry Timoshkov dmitry@codeweavers.com 2009-06-02 04:52:39 --- It should be possible to add an apropriate test case for this behaviour.
http://bugs.winehq.org/show_bug.cgi?id=18734
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com
--- Comment #4 from Bruno Jesus 00cpxxx@gmail.com 2011-10-07 18:08:53 CDT --- Still present in 1.3.29.
http://bugs.winehq.org/show_bug.cgi?id=18734
--- Comment #5 from Bruno Jesus 00cpxxx@gmail.com --- Still in wine 1.7.12. Patch in comment 2 still fixes it.
https://bugs.winehq.org/show_bug.cgi?id=18734
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #6 from super_man@post.com --- still an issue 1.8.rc4. Didnt try the patch.
https://bugs.winehq.org/show_bug.cgi?id=18734
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=18734
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED CC| |dmitry@baikal.ru, | |erich.e.hoover@wine-staging | |.com, michael@fds-team.de Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/user.exe16-Dlg | |DirList
https://bugs.winehq.org/show_bug.cgi?id=18734
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/user.exe16-Dlg |er/patches/user.exe16-DlgDi |DirList |rList
https://bugs.winehq.org/show_bug.cgi?id=18734
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |RESOLVED Fixed by SHA1| |0a788caf8b4665d7f56443fc2c6 | |d7790edf9defb Resolution|--- |FIXED
--- Comment #7 from Gijs Vermeulen gijsvrm@gmail.com --- Staging patch was upstreamed as: 0a788caf8b4665d7f56443fc2c6d7790edf9defb Marking FIXED.
https://bugs.winehq.org/show_bug.cgi?id=18734
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 3.13.
https://bugs.winehq.org/show_bug.cgi?id=18734
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x
https://bugs.winehq.org/show_bug.cgi?id=18734
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |---
--- Comment #9 from Michael Stefaniuc mstefani@winehq.org --- Removing the 3.0.x milestone from bugs included in 3.0.3.
-
wine-bugs＠winehq.org