[Bug 42179] New: Better detect which tests need to be rerun

https://bugs.winehq.org/show_bug.cgi?id=42179

Bug ID: 42179
           Summary: Better detect which tests need to be rerun
           Product: Wine-Testbot
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The TestBot sometimes does not always know which tests need to be rerun and
thus tries to run the test executable with no argument. This typically happens
in the following circumstances:
* When a non-C file is patched, such as a resource or JavaScript file.
* When a test file is removed. This case is actually similar to the previous
case where the non-C file is the Makefile.in file.

Note however that if there is only one test file this works anyway because in
that case the test executable just runs that one test by default.
I added some test cases for this in the TestBot test suite:
https://github.com/fgouget/wine/tree/wtbsuite

[Bug 42179] Better detect which tests need to be rerun

https://bugs.winehq.org/show_bug.cgi?id=42179

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31789

[Bug 42179] Better detect which tests need to be rerun

https://bugs.winehq.org/show_bug.cgi?id=42179

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from François Gouget  ---
This is fixed. If a non-C file is patched, all the tests in that directory are
re-run.

commit 049ee751f8e742f2488de2b1a2bed438d47500c9
Author: Francois Gouget 
Date:   Thu May 18 06:58:29 2017 +0200

testbot/WineRunReconfig: Don't update the TestList if the Reconfig failed.

If we failed to update/rebuild Wine then we will stick with the old Wine
    and we should still use the old test list.

Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

commit 2e7a90c1568a9d77d5bca80c7342e537e732a22b
Author: Francois Gouget 
Date:   Mon Apr 3 01:50:27 2017 +0200

testbot: Don't rerun the tests if only the makefile was modified.

Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

commit 83dc05b3eb3244bd6de4ce41d46834ccd73f2edf
Author: Francois Gouget 
Date:   Mon Apr 3 01:50:23 2017 +0200

testbot: Rerun all of a module's test units when a non-C file is modified.

This typically happens when a resource file is modified or a test unit
    is deleted.

Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

[Bug 42179] Better detect which tests need to be rerun

https://bugs.winehq.org/show_bug.cgi?id=42179
Bug 42179 depends on bug 31789, which changed state.

Bug 31789 Summary: Fix handling of jscript/vbscript tests
https://bugs.winehq.org/show_bug.cgi?id=31789

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

[Bug 42179] Better detect which tests need to be rerun

https://bugs.winehq.org/show_bug.cgi?id=42179

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Austin English  ---
Closing.