[Bug 42873] New: Need for Speed: The Run crashes when getting a d3d context

https://bugs.winehq.org/show_bug.cgi?id=42873

Bug ID: 42873
           Summary: Need for Speed: The Run crashes when getting a d3d
                    context
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 57989
  --> https://bugs.winehq.org/attachment.cgi?id=57989
possible solution

When running "Need for Speed: The Run", it crash on an invalid context.

[Bug 42873] Need for Speed: The Run crashes when getting a d3d context

https://bugs.winehq.org/show_bug.cgi?id=42873

--- Comment #1 from Alistair Leslie-Hughes  ---
Created attachment 57990
  --> https://bugs.winehq.org/attachment.cgi?id=57990
Log file

[Bug 42873] Need for Speed: The Run crashes when getting a d3d context

https://bugs.winehq.org/show_bug.cgi?id=42873

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 42873] Need for Speed: The Run crashes when getting a d3d context

https://bugs.winehq.org/show_bug.cgi?id=42873

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Józef Kucia  ---
(In reply to Alistair Leslie-Hughes from comment #0)
> Created attachment 57989 [details]
> possible solution

The condition in the patch should be "if (!context || ...".
> When running "Need for Speed: The Run", it crash on an invalid context.

It happens because the context which was used to issue the query is destroyed
with the associated swapchain. I think it's fine to do a NULL check in
context_reacquire().

[Bug 42873] Need for Speed: The Run crashes when getting a d3d context

https://bugs.winehq.org/show_bug.cgi?id=42873

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57989|0                           |1
        is obsolete|                            |

--- Comment #3 from Alistair Leslie-Hughes  ---
Created attachment 58001
  --> https://bugs.winehq.org/attachment.cgi?id=58001
Update Patch

[Bug 42873] Need for Speed: The Run crashes when getting a d3d context

https://bugs.winehq.org/show_bug.cgi?id=42873

--- Comment #4 from Alistair Leslie-Hughes  ---
Is there an example test I could use/copy to reproduce this behaviour?

[Bug 42873] Need for Speed: The Run crashes when getting a d3d context

https://bugs.winehq.org/show_bug.cgi?id=42873

--- Comment #5 from Józef Kucia  ---
Created attachment 58004
  --> https://bugs.winehq.org/attachment.cgi?id=58004
Test case

(In reply to Alistair Leslie-Hughes from comment #4)
> Is there an example test I could use/copy to reproduce this behaviour?

The attached test reproduced this crash.

[Bug 42873] Need for Speed: The Run crashes when getting a d3d context

https://bugs.winehq.org/show_bug.cgi?id=42873

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/wined3d-contex
                   |                            |t_reacquire
             Status|NEW                         |STAGED
                 CC|                            |[e-mail],
                   |                            |erich.e.hoover@wine-staging
                   |                            |.com, [e-mail],
                   |                            |[e-mail]

[Bug 42873] Need for Speed: The Run crashes when getting a d3d context

https://bugs.winehq.org/show_bug.cgi?id=42873

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c9ea06e7a8fef557bd781c2b56c
                   |                            |d81a3629ec839
         Resolution|---                         |FIXED
             Status|STAGED                      |RESOLVED

--- Comment #6 from Alistair Leslie-Hughes  ---
Fixed by 
http://source.winehq.org/git/wine.git/?a=commit;h=c9ea06e7a8fef557bd781c2b56...

[Bug 42873] Need for Speed: The Run crashes when reacquiring query context

https://bugs.winehq.org/show_bug.cgi?id=42873

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Need for Speed: The Run     |Need for Speed: The Run
                   |crashes when getting a d3d  |crashes when reacquiring
                   |context                     |query context

[Bug 42873] Need for Speed: The Run crashes when reacquiring query context

https://bugs.winehq.org/show_bug.cgi?id=42873

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 2.9.