[Bug 57319] New: Painting in a proprietary application is broken with vulkan renderer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57319

Bug ID: 57319
           Summary: Painting in a proprietary application is broken with
                    vulkan renderer
           Product: Wine
           Version: 9.19
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: winex11.drv
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 21a0c158b94bfc65d4baa95095307a1db396db0c
      Distribution: ---

The following commit broke repainting in the proprietary application that I
have here:

commit 21a0c158b94bfc65d4baa95095307a1db396db0c
Author: Rémi Bernon 
Date:   Tue Sep 10 10:01:57 2024 +0200

winex11: Implement vulkan DPI scaling and child window rendering.

dlls/winex11.drv/vulkan.c | 91 +++++++++++++++++++++++++++++++++++++++++++----
 dlls/winex11.drv/window.c |  2 +-
 dlls/winex11.drv/x11drv.h |  1 +
 3 files changed, 86 insertions(+), 8 deletions(-)

The application uses D3D11 for rendering its windows contents. Broken painting
could be reproduced by creating 2 MDI like windows, switching to 1st MDI child,
and then moving main window by dragging it using window WM caption, this makes
contents of the 2nd MDI child visible instead of current 1st MDI child. When
using opengl renderer this particular bug doesn't exist, but there are other
problems that make vulkan renderer preferrable.

The application doesn't have a demo. I'll provide the requested logs if
desired.

[Bug 57319] Painting in a proprietary application is broken with vulkan renderer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57319

--- Comment #1 from Rémi Bernon  ---
We didn't support vulkan child window rendering at all before that change, was
it actually working with the vulkan renderer?

[Bug 57319] Painting in a proprietary application is broken with vulkan renderer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57319

--- Comment #2 from Dmitry Timoshkov  ---
(In reply to Rémi Bernon from comment #1)
> We didn't support vulkan child window rendering at all before that change,
> was it actually working with the vulkan renderer?

Yes, the application worked correctly.

[Bug 57319] Painting in a proprietary application is broken with vulkan renderer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57319

--- Comment #3 from Rémi Bernon  ---
Maybe that's the same as bug 57503, I created
https://gitlab.winehq.org/wine/wine/-/merge_requests/6998 which should fix that
one if you want to try it.

[Bug 57319] Painting in a proprietary application is broken with vulkan renderer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57319

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Dmitry Timoshkov  ---
This bug seems to be fixed in wine-10.0-rc2. However a new one has appeared: on
exit an application asks with a MessageBox like window whether to save the
changes, and only contents of the upper left part of the MessageBox are
visible.

Regression test points to

commit ce7b293c5b29111d256f5416bb44a6c77d6ef673
Author: Rémi Bernon 
Date:   Tue Dec 10 15:18:40 2024 +0100

win32u: Copy the shape from the old surface when surface is recreated.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57285

and this is bug 57551.

Marking this bug as fixed.

[Bug 57319] Painting in a proprietary application is broken with vulkan renderer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57319

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 10.0-rc3.