[Bug 51340] New: d3d10core:d3d10core test_texture_compressed_3d() fails on Nvidia (cw-gtx560)
https://bugs.winehq.org/show_bug.cgi?id=51340
Bug ID: 51340 Summary: d3d10core:d3d10core test_texture_compressed_3d() fails on Nvidia (cw-gtx560) Product: Wine Version: 6.10 Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
test_texture_compressed_3d() fails systematically on cw-gtx560, the TestBot's only Nvidia test configuration:
https://test.winehq.org/data/patterns.html#d3d10core:d3d10core
d3d10core.c:19081: Test failed: Got unexpected colour 0xff00006a at (251, 9, 0), expected 0xff00006d.
This failure happens on all Windows versions and with the 353.82 (win81), 388.13 (win 10 1709 & 1809) and 391.35 (win10 1909 & 2009) driver versions. Also this failure does not happen on any of the other GPUs (cw-rx460 and QEmu VMs).
The failing test was introduced in this commit:
commit 2aeab85c27a202d0ef7b1e01d7ccab32d9d53c93 Author: Henri Verbeet hverbeet@codeweavers.com Date: Tue Jun 22 14:36:00 2021 +0200
wined3d: Add decompression information for BC4_UNORM.
Signed-off-by: Henri Verbeet hverbeet@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=51340
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |2aeab85c27a202d0ef7b1e01d7c | |cab32d9d53c93 Keywords| |source, testcase
https://bugs.winehq.org/show_bug.cgi?id=51340
--- Comment #1 from Henri Verbeet hverbeet@gmail.com --- (In reply to François Gouget from comment #0)
test_texture_compressed_3d() fails systematically on cw-gtx560, the TestBot's only Nvidia test configuration:
https://test.winehq.org/data/patterns.html#d3d10core:d3d10core
d3d10core.c:19081: Test failed: Got unexpected colour 0xff00006a at (251, 9, 0), expected 0xff00006d.
It would be fine to bump the tolerance on the compare_color() call from 2 to e.g. 4. I'd expect the same issue to happen with the corresponding d3d11 test as well.
https://bugs.winehq.org/show_bug.cgi?id=51340
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|d3d10core:d3d10core |d3d10core:d3d10core, |test_texture_compressed_3d( |d3d11:d3d11 |) fails on Nvidia |test_texture_compressed_3d( |(cw-gtx560) |) fails on Nvidia | |(cw-gtx560)
--- Comment #2 from François Gouget fgouget@codeweavers.com --- On cw-gtx560 d3d11:d3d11 usually crashes before it gets that far but when it makes it to test_texture_compressed_3d() it does indeed have the same failure.
https://bugs.winehq.org/show_bug.cgi?id=51340
--- Comment #3 from François Gouget fgouget@codeweavers.com --- Created attachment 70211 --> https://bugs.winehq.org/attachment.cgi?id=70211 Increase the tolerance in test_texture_compressed_3d().
I get the same results for d3d10core:c3d10core and d3d11:d3d11. In both cases increasing the tolerance to 4 is not sufficient:
4: d3d10core.c:19081: Test failed: Got unexpected colour 0xff00003b at (2, 240, 9), expected 0xff000040. 5: d3d10core.c:19081: Test failed: Got unexpected colour 0xff000048 at (2, 32, 12), expected 0xff00004e. 6: d3d10core.c:19081: Test failed: Got unexpected colour 0xff000057 at (2, 160, 14), expected 0xff00005e.
With a tolerance of 7 there is no failure anymore, at least on Windows 10 1507 with the 391.35 driver. So if rounding that to 8 is acceptable then the attached patch could fix this issue in both cases.
https://bugs.winehq.org/show_bug.cgi?id=51340
--- Comment #4 from Henri Verbeet hverbeet@gmail.com --- (In reply to François Gouget from comment #3)
With a tolerance of 7 there is no failure anymore, at least on Windows 10 1507 with the 391.35 driver. So if rounding that to 8 is acceptable then the attached patch could fix this issue in both cases.
That's fine.
https://bugs.winehq.org/show_bug.cgi?id=51340
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Fixed by SHA1| |5e065c3c70ab5d3d4d8ea3631a1 | |d6204f4130c37
--- Comment #5 from François Gouget fgouget@codeweavers.com --- This is fixed:
commit 5e065c3c70ab5d3d4d8ea3631a1d6204f4130c37 Author: Francois Gouget fgouget@codeweavers.com Date: Tue Jun 29 09:11:18 2021 +0200
d3d10core/tests: Increase the tolerance in test_texture_compressed_3d().
This fixes failures on Nvidia GeForce GTX 560 graphics cards.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51340 Signed-off-by: Francois Gouget fgouget@codeweavers.com Signed-off-by: Henri Verbeet hverbeet@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
And also for d3d11:d3d11:
commit 42fc1dcda539864468fb4b743b4233f15cf189fc Author: Francois Gouget fgouget@codeweavers.com Date: Tue Jun 29 09:11:18 2021 +0200
d3d11/tests: Increase the tolerance in test_texture_compressed_3d().
This fixes failures on Nvidia GeForce GTX 560 graphics cards.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51340 Signed-off-by: Francois Gouget fgouget@codeweavers.com Signed-off-by: Henri Verbeet hverbeet@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=51340
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.13.
-
WineHQ Bugzilla