[Bug 52613] New: mIRC: text from clipboard is pasted twice in text boxes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52613

Bug ID: 52613
           Summary: mIRC: text from clipboard is pasted twice in text
                    boxes
           Product: Wine
           Version: 7.3
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

OS: Linux Mint 20.3 Cinnamon

The issue: After updating winehq-devel from 7.2 to 7.3 (from official ppa), any
text that I paste in text boxes appears twice. As if I had pressed Ctrl+V or
Shift+Insert twice instead of once. I can reproduce the bug in a fresh
wineprefix and with the latest mIRC v7.67.

Steps to reproduce the issue:

1. Install mIRC 7.67 (you can freely download the installer from
https://www.mirc.com/get.html )

wine » sha1sum mirc767.exe
6b2509d3064f6fd618d6387636835a2387df144f  mirc767.exe

2. At end of installer, [Check] Run mIRC and click "Finish".
3. The "About mIRC" window will show up. Click "Continue", then wait and click
"Continue" again.
4. Close the "mIRC Options" window.
5. Click in the status window text box, the text cursor will appear.
6. Select text from a different window, and copy it to the clipboard.
7. Return to the mIRC window and paste the text in the text box.

I'll be happy to provide more feedback.

[Bug 52613] mIRC: text from clipboard is pasted twice in text boxes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52613

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
                 CC|                            |[e-mail]
                URL|                            |https://www.mirc.com/get.ht
                   |                            |ml

--- Comment #1 from Fabian Maurer  ---
Do you think you can do a regression test to find out which change broke that?
See https://wiki.winehq.org/Regression_Testing

[Bug 52613] mIRC: text from clipboard is pasted twice in text boxes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52613

Meredith Johnson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Meredith Johnson  ---
A bisect blamed the following commit:

commit d9f21fcca5376f47b842f3d061674898eb0db310
Author: Jacek Caban 
Date:   Fri Feb 25 16:02:46 2022 +0100

win32u: Move call_hooks implementation from user32.

I also built Wine 7.3 with that commit reverted, and confirmed that fixed the
issue.

[Bug 52613] mIRC: text from clipboard is pasted twice in text boxes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52613

Meredith Johnson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |d9f21fcca5376f47b842f3d0616
                   |                            |74898eb0db310

[Bug 52613] mIRC: text from clipboard is pasted twice in text boxes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52613

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Severity|minor                       |normal
                URL|https://www.mirc.com/get.ht |https://www.mirc.com/downlo
                   |ml                          |ads/mirc/35/mirc767.exe
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #3 from Gijs Vermeulen  ---
Adding direct URL, CC'ing Jacek, confirming.

[Bug 52613] mIRC: text from clipboard is pasted twice in text boxes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52613

--- Comment #4 from Jacek Caban  ---
Does it still happen with current git? This commit may be related:
https://source.winehq.org/git/wine.git/commitdiff/3bfbdc6d11dc5a90a625dd2d5f...

[Bug 52613] mIRC: text from clipboard is pasted twice in text boxes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52613

--- Comment #5 from Meredith Johnson  ---
It does not still happen with current git (HEAD at 824a7eed). I can verify that
the commit you mention is that one that fixed the issue?

[Bug 52613] mIRC: text from clipboard is pasted twice in text boxes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52613

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |3bfbdc6d11dc5a90a625dd2d5f4
                   |                            |bfc95c0790d15

--- Comment #6 from Jacek Caban  ---
Thanks for testing and for the report. I think it's safe to assume that
mentioned commit was the one that fixed the bug.

[Bug 52613] mIRC: text from clipboard is pasted twice in text boxes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52613

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 7.5.