[Bug 22434] New: Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Summary: Hype - The Time Quest crashes when the game should
                    come up (looks like null pointer dereference to me)
           Product: Wine
           Version: 1.1.43
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=27475)
 --> (http://bugs.winehq.org/attachment.cgi?id=27475)
terminal output + backtrace

Hi,

This is a really ancient game (1998 I believe) and it uses DirectX 6 for
rendering. Unfortunately, the game crashes at the point at which the "Ubisoft"
screen should come up. I'm no C expert (scratch that, I know nothing of it at
all), but judging from the backtrace it looks like a null pointer dereference
error in dlls/wined3d/context.c, which is caused by these two errors:
fixme:ddraw:device_parent_CreateSwapChain (0x134324) CreateSwapChain failed,
returning 0x8876086a
err:ddraw:IDirectDrawImpl_CreateSurface IDirectDrawImpl_AttachD3DDevice failed,
hr = 8876086a

$ wine --version
wine-1.1.43-78-ga551dfe (latest git, to my knowledge)

$ uname -a
Linux pc-van-cesko 2.6.33.2-41.fc13.i686 #1 SMP Mon Apr 12 14:45:33 UTC 2010
i686 i686 i386 GNU/Linux

$ gcc -v
Ingebouwde specs worden gebruikt. (translation: using built-in specs)
Target: i686-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
--infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla
--enable-bootstrap --enable-shared --enable-threads=posix
--enable-checking=release --with-system-zlib --enable-__cxa_atexit
--disable-libunwind-exceptions --enable-gnu-unique-object
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada --enable-java-awt=gtk
--disable-dssi --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre
--enable-libgcj-multifile --enable-java-maintainer-mode
--with-ecj-jar=/usr/share/java/eclipse-ecj.jar --disable-libjava-multilib
--with-ppl --with-cloog --with-tune=generic --with-arch=i686
--build=i686-redhat-linux
Thread model: posix
gcc versie 4.4.3 20100409 (Red Hat 4.4.3-16) (GCC)

CFLAGS are set to "-O3 -gdwarf-2"

I'd appreciate any help.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Wylda   2010-04-22 13:10:52 ---

This one took me a lot of time, but finally i was able to start it (at least).

1. Confirming, please consider UNCONFIRMED->NEW and KEYWORDS: +REGRESSION,
+DOWNLOAD

2. I did a regression test between 0.9.58 and 0.9.59:

commit 8662bd7555593fe010b02e0f2f0bd80fd858ed41
Author: Stefan Dösinger 
Date:   Fri Mar 21 19:16:20 2008 +0100

ddraw: Fix some Z buffer formats.

:040000 040000 3db9e99b38699021df8818b16972cfff94d130a0
13289128d587ba1da45ca3623f71bf396db0d070 M      dlls

3. No other bug report suffers from this commit.

4. Revert of this patch on top of wine-1.1.12 makes that problem go away. This
patch can be reverted up to 1.1.29, but since 1.1.13 there is another
regression.

5. Adding author of this patch to CC.

--private keyword: bisected

Demo is affected the same way. Download:
http://www.megagames.com/download/hypedemo.exe

Side note: To be able to compile 0.9.58 on recent kernel and OpenSSL, i need to
inject two commits for 0.9.58:

* 7c616799894faa48ee3277bc276a39bed55780e0 wininet: Include openssl/ssl.h
before Windows headers.

* 3499cb96b69d0c99da5ae68f5f7052c2ce8e66be ntdll: Add local defines for VIF
and VIP flags.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Stefan Dösinger   2010-04-22 13:31:45 ---
A question to the original reporter: What GPU do you use? The problem seems
like the game requests a pixel format that your GL implementation rejects. Can
you attach a +ddraw,+d3d7 log?

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #3 from [e-mail]  2010-04-22 13:56:43 ---
Created an attachment (id=27513)
 --> (http://bugs.winehq.org/attachment.cgi?id=27513)
with WINEDEBUG=+ddraw,+d3d7,+d3d6

My videocard is an Intel 865g. Old as fart, supports OpenGL up to a whopping
version 1.3 (unfortunately that's not a typo), but it works for me. I don't
know what OpenGL API version Wine uses, but if it's above 1.3, there's a good
chance that that's my real problem.

When I started the game this time (freshly updated Wine and newly-created
wineprefix) it didn't crash with a null pointer dereference as it did before
(at least, I think that was what it was). Instead, it just terminated. No "the
program has generated an error and needs to close"-dialogue this time.

I've attached a +ddraw,+d3d7,+d3d6 log. (I added the d3d6 because, according to
the installer, that's the version the game uses and I thought you might want
that info as well, I apologize if I overanticipated here.)

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Vitaliy Margolen   2010-04-22 22:29:18 ---
Confirming per comment 1.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #5 from Stefan Dösinger   2010-04-23 02:31:09 ---
I suspect that your card doesn't support D24S8 depth buffers. I recently
accidentally broke the ability to fall back to a different format. It wasn't
the patch Wylda found, but rather a fairly recent one.

You can confirm this by editing dlls/wined3d/swapchain.c.  Somewhere around
line 815 there's a line like this:
swapchain->ds_format = getFormatDescEntry(WINED3DFMT_D24_UNORM_S8_UINT,
gl_info);

You can try to replace WINED3DFMT_D24_UNORM_S8_UINT with WINED3DFMT_D16_UNORM
and see if this fixes the problem.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #6 from Wylda   2010-04-23 02:49:54 ---
(In reply to comment #5)
> I suspect that your card doesn't support D24S8 depth buffers.

Hi Stefan, i own nvidia 8600GT v195.36.15.

The situation is, that when you run the game in 1.1.43, it immediately goes
back to console. This can be "fixed" by reverting:

* 8662bd7555593fe010b02e0f2f0bd80fd858ed41
 * ddraw: Fix some Z buffer formats.

That's not possible for version higher than 1.1.29, so i made my own hack:

--- a/dlls/ddraw/utils.c.orig
+++ b/dlls/ddraw/utils.c
-            DDPixelFormat->u1.dwZBufferBitDepth = 32;
+            DDPixelFormat->u1.dwZBufferBitDepth = 24;

-            DDPixelFormat->u1.dwZBufferBitDepth = 32;
+            DDPixelFormat->u1.dwZBufferBitDepth = 24;

-            DDPixelFormat->u1.dwZBufferBitDepth = 32;
+            DDPixelFormat->u1.dwZBufferBitDepth = 24;

Than the game starts and displays white screen with crash. This is regression
since 1.1.13 caused by commit:

* efcecb9b99331a39f2f96d456df280a15a9557ca
 * ddrawex: Implement a wrapper around IDirectDraw.

Revering this one on top of 1.1.43 fails, but i did that anyway and than rip
dlls/ddrawex/Makefile.in so it successfully compiles.

Since that, Hype - The time quest starts again on 1.1.43 :-D

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #7 from [e-mail]  2010-04-23 09:48:17 ---
Following Wylda's instructions in comment 1, the game now starts on Wine
1.1.12! On that version it's still unplayable because it doesn't recognize
keyboard input, but the original bug has now been worked around :-)
I will file a separate bug report for the keyboard problem once a resolution to
the original bug has made it to the git tree - the things Wylda's doing in
comment 6 are a bit beyond me, I'm afraid, and I wouldn't want to file a bug
report without being on the latest git (to make sure I'm not reporting
something that's already been fixed).

Thank you all very much for all your help.

Is there anything the developers need me to do now or will a fix for this bug
now gradually be written and make it in a following Wine release?

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #8 from Wylda   2010-04-23 10:35:43 ---
(In reply to comment #7)
> Following Wylda's instructions in comment 1, the game now starts on Wine
> 1.1.12!

Good to know, proves that affected code needs more love for nvidia & intel
cards.

I'm also glad, that it wasn't wasted, because i thought i will compile my 8core
CPU to death :-) ...well there is also a keyboard issue, but that definitely
should go to another report. This one carries two regression already ~ no good.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #9 from Stefan Dösinger   2010-04-30 07:14:03 ---
Hi,
Those who have problems on Intel cards, can you try attachment 27629 from bug
22523?

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #10 from [e-mail]  2010-04-30 07:28:00 ---
I don't think that will make much of a difference as it's already been proven
that the problems causing this game to not start are not card-specific. Wylda's
instructions made the game start for me too. (I can't get past the main menu
because of the keyboard-bug, but that's not related to this bug).

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

--- Comment #11 from [e-mail]  2010-05-08 10:51:09 ---
Bug is still present in Wine 1.1.44

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #12 from Wylda   2010-05-10 14:06:26 ---

This regression (bisected) is still present in wine-1.1.44-72-g658209b

Console log is quite short (+search engine carrot):

fixme:d3d:swapchain_init Add OpenGL context recreation support to
context_validate_onscreen_formats

err:d3d:wined3d_unregister_window Window 0xa005e is not registered with
wined3d.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #13 from [e-mail]  2010-06-22 06:48:31 ---
The regression is still present in wine-1.2-rc4-48-g58a6988
The console output has unchanged from comment 12.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #14 from Wylda   2010-08-22 10:02:59 ---

This regression (bisected) is still present in wine-1.3.1.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #15 from [e-mail] 2010-10-01 08:30:57 CDT ---
It's still present in wine-1.3.3-417-g536fc57.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #16 from [e-mail] 2011-02-04 07:21:14 CST ---
This bisected regression is still present in wine-1.3.11
The terminal output is still the same:

fixme:d3d:swapchain_init Add OpenGL context recreation support to
context_validate_onscreen_formats
err:d3d:wined3d_unregister_window Window 0x60096 is not registered with
wined3d.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #17 from [e-mail] 2011-04-24 03:21:11 CDT ---
This bisected regression is still present in wine-1.3.18-170-gfa2e4bb.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #18 from Stefan Dösinger  2011-04-24 04:24:16 CDT ---
I wish I had written some tests for the Z buffer formats along with the patch.
If my memory serves me correctly Windows drivers didn't accept the 24 Z bits +
8 stencil bits formats and instead wanted 32+8, and the bitmasks then signalted
that it was in fact the common D24S8 format.

It seems that the game wants a depth buffer format with 24 z bits and fails
otherwise. Does it still work on Windows, especially on Intel GPUs? If it does
it is possible that windows gives older games(or this specific one) different
enum values, or that my patch was simply broken.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #19 from [e-mail] 2011-04-24 04:44:58 CDT ---
The game has worked on Windows all the way from Windows 98 (I don't know what
GPU our ancient Windows 98 computer had but it certainly wasn't anything fancy)
up to Windows XP (with the Intel GPU). I believe my mom's 32-bit Vista was also
able to run it.

On my new computer (64-bits, Windows 7 & Gentoo Linux, ATI Radeon HD 5450 &
Intel integrated i5 GPU), the game still does not run on Wine with exactly the
same problem as before:

fixme:win:EnumDisplayDevicesW ((null),0,0x33f518,0x00000000), stub!
fixme:win:EnumDisplayDevicesW ((null),0,0x33f614,0x00000000), stub!
fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to
16
fixme:d3d:swapchain_init Add OpenGL context recreation support to
context_validate_onscreen_formats

This is from my Intel GPU. If I run the game on my Radeon GPU I get some more
errors related to wine not particularly liking gallium3d and gallium3d not
supporting some things wine wants, etc. That's not a problem on wine's end. (Of
course I'd happily plug my monitor into my Intel GPU if it means being able to
play this game again).

To make things a bit more complicated, this game does not run on my new Windows
OS: the game doesn't appear to play nice with 64 bits Windows. However, I still
have my old computer with the Intel GPU and Windows XP (32-bit), and the game
still works on that box. I'd happily dig it up again for testing purposes if
you need me to.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #20 from [e-mail] 2011-06-02 10:39:39 CDT ---
Bump, this regression is still in wine-1.3.21-92-gb6484cc

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |8662bd7555593fe010b02e0f2f0
                   |                            |bd80fd858ed41

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #21 from Stefan Dösinger  2011-08-17 15:32:00 CDT ---
I ran some (long) overdue tests on Windows 7, Nvidia 9600, and they show that
the patch that broke this game is essentially correct. D24S8 is reported as
zBitDepth 32, StencilBitDepth 8. The Z bitmask has 24 bits set, the stencil
bitmasks 8. D24X8(WINED3DFMT_R24_UNORM_X8_TYPELESS in wined3d) is reported as
zBitDepth 32, the Z bitmask has 24 bits set, the stencil mask 0.

However, this card also enumerates a format I'd call WINED3DFMT_D24_UNORM in
wined3d-speak. This format should make the game happy. Supporting a format like
that is no problem, opengl will probably just use the normal 24 bit stencil
with 8 bit padding format.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #22 from Stefan Dösinger  2011-08-17 16:06:34 CDT ---
I just noticed that Windows XP on my radeon X1600 GPU doesn't enumerate this
D24 format(but the Radeon HD 5750 on Windows 7 does), I'll give the game demo a
try on this XP machine.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #23 from Stefan Dösinger  2011-08-17 16:13:56 CDT ---
Never mind that idea, the demo doesn't install on WinXP. It says it needs
something other than Windows NT, even if I run it in compatibility mode.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #24 from Stefan Dösinger  2011-08-17 17:20:57 CDT ---
Created an attachment (id=36025)
 --> (http://bugs.winehq.org/attachment.cgi?id=36025)
ddraw: Emulate a 24 bit depth format without stencil or padding

This patch adds a D24_UNORM format in addition to the already supported D24X8,
D24S8 and D32 formats. I think it should fix this bug, but I haven't tested the
app myself yet.

What's missing in this patch is a small test that makes sure that pixels are
really 3 byte long in this format and that the surface pitch is width * 3 with
alignment padding at the end of a row.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Cesko Voeten  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27475|0                           |1
        is obsolete|                            |
  Attachment #27513|0                           |1
        is obsolete|                            |

--- Comment #25 from Cesko Voeten  2011-08-18 02:56:40 CDT ---
Created an attachment (id=36032)
 --> (http://bugs.winehq.org/attachment.cgi?id=36032)
new backtrace

Hi Stefan,

We've (or rather: you've, because I haven't really done anything :P) made
excellent progress! With your patch on top of wine-1.3.26 (which is latest git)
and when installed with native WinXP 32-bit advpack.dll with windows version
set to 98, the game launches! Well, almost. It gets up to the main UbiSoft
loading screen (which is a darn lot further than it used to get :-D) and then
crashes. This MAY be the second regression Wylda found in comment #6, but since
that commit is no longer (easily (for a layman such as myself)) revertible, I
could not check that.

I've attached the backtrace produced now. (There is a lot of terminal output
generated above the backtrace but that's mostly a few hundred lines of whining
about quartz, which is used to play the intro movie (which works, BTW). I've
omitted that.)
I noticed the debugging information provided isn't all that useful (or is it
and am I just ignorant?). If you need me to recompile Wine at a lower
optimization level I'll be happy to oblige. FYI, my current CFLAGS are
"-march=native -O2 -combine -fno-omit-frame-pointer -gdwarf-2 -mfpmath=sse
-floop-interchange -floop-strip-mine -floop-block" which may be a bit
excessive.

Thanks so much for your great work!

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #26 from Stefan Dösinger  2011-08-18 04:15:10 CDT ---
Yes, please recompile Wine with lower optimization(preferably the default -O2
-g) and attach a new backtrace. I'd also prefer if you compiled Wine manually
rather than with Gentoo's ebuild because Gentoo strips debug symbols away after
compilation(this can be turned off I think).

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Cesko Voeten  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36032|0                           |1
        is obsolete|                            |

--- Comment #27 from Cesko Voeten  2011-08-18 04:55:17 CDT ---
Created an attachment (id=36035)
 --> (http://bugs.winehq.org/attachment.cgi?id=36035)
new new backtrace

I've now recompiled with CFLAGS="-O2 -gdwarf-2 -fno-omit-frame-pointer" and
FEATURES=nostrip and the backtrace is much more informative.
Regarding Portage stripping binaries: I usually have FEATURES=splitdebug set,
which tells Portage to install unstripped binaries to /usr/lib/debug, then to
strip the binaries and insert some ELF mumbo-jumbo into the stripped binary's
header which tells GDB where to find its debugging symbols. Can Wine follow
that too or should I set FEATURES=nostrip in Wine's Portage environment file?

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #28 from Stefan Dösinger  2011-08-18 05:13:51 CDT ---
(In reply to comment #27)
> I've now recompiled with CFLAGS="-O2 -gdwarf-2 -fno-omit-frame-pointer" and
> FEATURES=nostrip and the backtrace is much more informative.

The line numbers are still missing
> Can Wine follow
> that too or should I set FEATURES=nostrip in Wine's Portage environment file?

I have no idea. I didn't even know this feature existed.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #29 from Stefan Dösinger  2011-08-18 05:15:25 CDT ---
If you compile Wine yourself and run it out of the source tree(to avoid
screwing up your system-wide installation) you have the source code around at
the time you run Wine, so winedbg will include the line of code where the crash
occurs. That's useful in case you have a different source tree than I do and
our line numbers are slightly off.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #30 from Henri Verbeet  2011-08-18 05:56:40 CDT ---
(In reply to comment #27)
> Created an attachment (id=36035)

--> (http://bugs.winehq.org/attachment.cgi?id=36035) [details]
> new new backtrace

Depending on actual line numbers and function arguments,
http://bugs2.winehq.org/attachment.cgi?id=35962 may help for this.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Cesko Voeten  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #31 from Cesko Voeten  2011-08-18 10:25:29 CDT ---
It's fixed.

The combination of Stefan's and Henri's patches did the trick.

Still no keyboard, but that's for a new bug. For now ,maybe I can get this to
work using WineD3D on Windows in a virtual machine :-)

Thanks so much for your perseverance. Now I can (hopefully, if VirtualBox isn't
going to be difficult) indulge in some nostalgia :-)

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #32 from Henri Verbeet  2011-08-18 10:31:38 CDT ---
A bug isn't fixed until the patches make it into the winehq git repository.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #33 from Cesko Voeten  2011-08-18 10:45:49 CDT ---
Apologies, I wasn't aware of that.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #34 from Stefan Dösinger  2011-08-18 12:15:11 CDT ---
There's another problem with PBOs: The game uses GetDC on render targets, and
the memcpy between the PBO and dib section fails for some reason. You probably
don't see it if your driver doesn't support GL_ARB_pixel_buffer_object.

I'll send my patch to wine-patches once Alexandre is back. I spotted some
issues in it in the meantime, mostly that the tests fail on Wine because we
enumerate formats not supported on Windows, and some formats have wrong
bitmasks(X8D24 has depth mask 0x00ffffffff rather than 0x00ffffff for example)

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #35 from Henri Verbeet  2011-08-22 13:54:07 CDT ---
(In reply to comment #30)
> Depending on actual line numbers and function arguments,
> http://bugs2.winehq.org/attachment.cgi?id=35962 may help for this.

This patch is now in current git as commit
34b2956e23a03458ed4c13d7556eb5438cb3fa1d.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #36 from Stefan Dösinger  2011-08-22 14:17:47 CDT ---
I just sent my patches to wine-patches

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #37 from Stefan Dösinger  2011-08-29 11:56:53 CDT ---
My patch is in Wine now, this bug should be fixed. Please retest.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Cesko Voeten  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #38 from Cesko Voeten  2011-08-29 14:27:23 CDT ---
It's fixed :-D

Thanks again to everyone involved.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #39 from Alexandre Julliard  2011-09-09 12:54:21 CDT ---
Closing bugs fixed in 1.3.28.

[Bug 22434] Hype - The Time Quest crashes when the game should come up (looks like null pointer dereference to me)

http://bugs.winehq.org/show_bug.cgi?id=22434

--- Comment #40 from Wylda  2011-12-09 22:52:24 CST ---

Interesting demo starts up for me under 1.3.28 and wine-1.3.34-202-gb0f704d,
but full version crashes when run in both of this versions.