http://bugs.winehq.org/show_bug.cgi?id=9715
Summary: winecfg should allow display resolution beyond 200dpi Product: Wine Version: 0.9.45. Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: wine-programs AssignedTo: wine-bugs@winehq.org ReportedBy: jjk3@msstate.edu
My screen is 133dpi, but winecfg only allows me to set it up to 120dpi. This should be changed.
http://bugs.winehq.org/show_bug.cgi?id=9715
Joel Parker jjk3@msstate.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jjk3@msstate.edu Summary|winecfg should allow display|winecfg should allow display |resolution beyond 200dpi |resolution beyond 120dpi
--- Comment #1 from Joel Parker jjk3@msstate.edu 2007-09-18 22:07:46 --- Corrected summary
http://bugs.winehq.org/show_bug.cgi?id=9715
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #2 from Lei Zhang thestig@google.com 2008-03-03 18:40:17 --- This is a simple one line change. What should the new maximum value be? 150 dpi?
http://bugs.winehq.org/show_bug.cgi?id=9715
--- Comment #3 from Austin English austinenglish@gmail.com 2008-03-03 22:29:42 --- I've sent a patch in to raise it to 160 to wine-patches.
http://bugs.winehq.org/show_bug.cgi?id=9715
--- Comment #4 from Joel Parker jjk3@msstate.edu 2008-03-04 09:27:42 --- Windows XP allows values from 19-480 (20%-500% of 96). Vista allows 96-480.
http://bugs.winehq.org/show_bug.cgi?id=9715
L. Rahyen mail@science.su changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@science.su
--- Comment #5 from L. Rahyen mail@science.su 2008-03-04 14:11:42 --- (In reply to comment #3)
I've sent a patch in to raise it to 160 to wine-patches.
Sorry but your patch isn't correct: it doesn't work well with anything higher than 127 DPI. I already explained this in wine-devel list in more details. In short, there was better patch by Nigel Liang some time ago: http://www.winehq.org/pipermail/wine-patches/2007-October/044977.html . But it wasn't accepted (without any feedback) and Nigel didn't try to resend it.
I will resend his patch to wine-patches in few minutes...
http://bugs.winehq.org/show_bug.cgi?id=9715
Lei Zhang thestig@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ncliang@gmail.com
--- Comment #6 from Lei Zhang thestig@google.com 2008-03-04 15:12:29 --- ok, I guess it was more than a 1 line change.
http://bugs.winehq.org/show_bug.cgi?id=9715
--- Comment #7 from L. Rahyen mail@science.su 2008-03-04 16:05:31 --- Patch by Austin English was committed (I guess I sent better patch by Nigel Liang too late - right before "commit wave"). As I already said Austin's patch is wrong because it allows to set DPI values that winecfg cannot handle correctly (bigger than 127).
I've sent a patch with a fix (with it winecfg works fine with DPI values more than 127).
http://bugs.winehq.org/show_bug.cgi?id=9715
--- Comment #8 from Austin English austinenglish@gmail.com 2008-03-04 20:57:43 --- (In reply to comment #7)
Patch by Austin English was committed (I guess I sent better patch by Nigel Liang too late - right before "commit wave"). As I already said Austin's patch is wrong because it allows to set DPI values that winecfg cannot handle correctly (bigger than 127).
I've sent a patch with a fix (with it winecfg works fine with DPI values more than 127).
Yes, I saw the e-mail after it had already been committed. I sent a mail to wine-devel asking Alexandre to apply Nigel's patch instead (and/or revert mine). If he doesn't in the next day or two, I'll send a revert patch.
http://bugs.winehq.org/show_bug.cgi?id=9715
--- Comment #9 from L. Rahyen mail@science.su 2008-03-06 15:16:40 --- Well, I think there is no reason to revert your patch because it is possible to fix winecfg properly without reverting it with exactly same size of the patch. So I just sent new patch (hopefully correct now) that makes DPI interval in winecfg to be the same as in Windows (and of course it also fixes winecfg so it can display DPI values more than 127 correctly after restarting winecfg). After the patch will be committed users who own displays with resolutions like 1680x1050 or 2048x1536 can easily set DPI values like 150 or 170 (in fact this is what I actually use with those resolutions) with winecfg without any problems (instead of editing the registry directly).
http://bugs.winehq.org/show_bug.cgi?id=9715
--- Comment #10 from L. Rahyen mail@science.su 2008-03-10 19:38:12 --- My patch has been committed so this bug should be marked as FIXED.
http://bugs.winehq.org/show_bug.cgi?id=9715
James Hawkins truiken@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #11 from James Hawkins truiken@gmail.com 2008-03-10 19:42:04 --- Fixed.
http://bugs.winehq.org/show_bug.cgi?id=9715
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Alexandre Julliard julliard@winehq.org 2008-03-21 10:54:24 --- Closing bugs fixed in 0.9.58.
http://bugs.winehq.org/show_bug.cgi?id=9715
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com Status|CLOSED |REOPENED Resolution|FIXED |
--- Comment #13 from Dan Kegel dank@kegel.com 2008-04-26 18:20:30 --- This change had to be reverted because too many people were setting DPI to crazy values and then getting stuck.
Perhaps 200 would be a safe max value, though.
http://bugs.winehq.org/show_bug.cgi?id=9715
--- Comment #14 from Austin English austinenglish@gmail.com 2008-04-26 18:26:22 --- (In reply to comment #13)
This change had to be reverted because too many people were setting DPI to crazy values and then getting stuck.
Perhaps 200 would be a safe max value, though.
A warning like the one I posted to wine-devel or one detecting a DPI > 150 then popping up a warning may be a better compromise.
http://bugs.winehq.org/show_bug.cgi?id=9715
--- Comment #15 from Dan Kegel dank@kegel.com 2008-04-26 20:11:47 --- Incidentally, Ubuntu tried using the monitor's autodetected resolution, and went back to hard-coding a default of 96: https://bugs.launchpad.net/ubuntu/+source/libgnome/+bug/118745
Here's how Mozilla handles it: http://www.mozilla.org/unix/dpi.html
Here's how Java handles it: http://www.javaresearch.org/source/jdk150/com/sun/java/swing/plaf/gtk/PangoF...
http://bugs.winehq.org/show_bug.cgi?id=9715
--- Comment #16 from Dan Kegel dank@kegel.com 2008-04-26 21:20:59 --- I looked at this a bit more. Even the current conservative max dpi is unsafe; at 800x600, setting the max DPI gets users into a state where they can't change CPI anymore.
That suggests a solution. The upper bound on DPI should not be hardcoded. Instead, it should be whatever DPI setting would cause the winecfg window to fill the whole screen! Bada bing bada boom, user is safe, and can always revert to lower DPI. (Assuming they can start winecfg again, anyway.)
http://bugs.winehq.org/show_bug.cgi?id=9715
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Keywords| |download, source Resolution| |FIXED
--- Comment #17 from Austin English austinenglish@gmail.com 2008-10-24 13:22:44 --- http://source.winehq.org/git/wine.git/?a=commitdiff;h=727eef4e4fe4642419c047...
Fixed a long time ago.
http://bugs.winehq.org/show_bug.cgi?id=9715
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #18 from Alexandre Julliard julliard@winehq.org 2008-11-07 10:45:39 --- Closing bugs fixed in 1.1.8.
-
wine-bugs＠winehq.org