[Bug 57102] New: Textbox-border is missing if textbox is on topmost layer of e. g. a TabControl.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57102

Bug ID: 57102
           Summary: Textbox-border is missing if textbox is on topmost
                    layer of e. g. a TabControl.
           Product: Wine
           Version: 9.16
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 76984
  --> https://bugs.winehq.org/attachment.cgi?id=76984
First tabpage of an .NET-application

Since 9.16 some textboxes have no rendered border. It happens only on topmost
layer of an .NET-Control.

See .NET-example as attachment.

Stable 9.0 works fine. And with 9.15 I didn´t notice this effect, too.

[Bug 57102] Textbox-border is missing if textbox is on topmost layer of e. g. a TabControl.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57102

--- Comment #1 from AndyF  ---
Created attachment 76985
  --> https://bugs.winehq.org/attachment.cgi?id=76985
second tabpage, all is fine.

[Bug 57102] Textbox-border is missing if textbox is on topmost layer of e. g. a TabControl.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57102

--- Comment #2 from AndyF  ---
.NET-Textboxes and Datetimepicker directly drawn on Mainform are affected, too
- until Mainform is minimized and restored.
So it seems to be a buffer/refresh-issue?

[Bug 57102] Textbox-border is missing if textbox is on topmost layer of e. g. a TabControl.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57102

--- Comment #3 from AndyF  ---
Wine's editor is affected, too. At search-window, textbox has no border.

[Bug 57102] Textbox-border is missing if textbox is on topmost layer of e. g. a TabControl.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57102

--- Comment #4 from AndyF  ---
Created attachment 76987
  --> https://bugs.winehq.org/attachment.cgi?id=76987
Wine's editor, "search"-window.

[Bug 57102] Textbox-border is missing if textbox is on topmost layer of e. g. a TabControl.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57102

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

--- Comment #5 from Austin English  ---
Please run a regression test:
https://wiki.winehq.org/Regression_Testing

[Bug 57102] Textbox-border is missing if textbox is on topmost layer of e. g. a TabControl.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57102

William Horvath  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from William Horvath  ---
Regression commit:

cb1c03b926ca01619be02f835f382c1dd7d4a478
win32u: Move visible rect computation out of the drivers.

[Bug 57102] Textbox-border is missing if textbox is on topmost layer of e. g. a TabControl.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57102

--- Comment #7 from William Horvath  ---
Created attachment 76995
  --> https://bugs.winehq.org/attachment.cgi?id=76995
A patch to work around the issue (GCC only)

This patch seems to prevent the issue from occurring when compiled with GCC
14.2.1 (-O2 or -O1). However, Clang 18.1.8 still exhibits the issue at any
optimization level.
It's not the correct way to fix it, but it should at least give a pointer in
the right direction as to where the problem lies.

[Bug 57102] Textbox-border is missing if textbox is on topmost layer of e. g. a TabControl.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57102

William Horvath  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76995|A patch to work around the  |A patch to work around the
        description|issue (GCC only)            |issue

--- Comment #8 from William Horvath  ---
Comment on attachment 76995
  --> https://bugs.winehq.org/attachment.cgi?id=76995
A patch to work around the issue
> --- a/dlls/win32u/window.c
> +++ b/dlls/win32u/window.c
> @@ -1842,7 +1842,7 @@ done:
> }
>
> -static RECT get_visible_rect( HWND hwnd, BOOL shaped, UINT style, UINT ex_style, const struct window_rects *rects )
> +static RECT __attribute__((optnone)) get_visible_rect( HWND hwnd, BOOL shaped, UINT style, UINT ex_style, const struct window_rects *rects )
> {
>     UINT dpi = get_dpi_for_window( hwnd ), style_mask, ex_style_mask;
>     RECT visible_rect, rect = {0};

[Bug 57102] Textbox-border is missing if textbox is on topmost layer of e. g. a TabControl.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57102

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
    Regression SHA1|                            |cb1c03b926ca01619be02f835f3
                   |                            |82c1dd7d4a478
      Fixed by SHA1|                            |531671cd20ee426dfc1c80e4c0c
                   |                            |f64260eda4af1
                 CC|                            |[e-mail]
         Resolution|---                         |FIXED

--- Comment #9 from Rémi Bernon  ---
Should be fixed with 531671cd20ee426dfc1c80e4c0cf64260eda4af1

[Bug 57102] Textbox-border is missing if textbox is on topmost layer of e. g. a TabControl.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57102

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  ---
Closing bugs fixed in 9.17.