[Bug 46441] New: Steam shows an extra icon when minimizing window

https://bugs.winehq.org/show_bug.cgi?id=46441

Bug ID: 46441
           Summary: Steam shows an extra icon when minimizing window
           Product: Wine
           Version: 4.0-rc5
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 63223
  --> https://bugs.winehq.org/attachment.cgi?id=63223
screenshot

Steps to reproduce:

1. Enable virtual desktop
2. Launch Steam
3. Minimize window

wine-4.0-rc5-14-g0ff7fd1259

[Bug 46441] Steam shows an extra icon when minimizing window

https://bugs.winehq.org/show_bug.cgi?id=46441

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Olivier F. R. Dierick  ---
Isn't that the desktop shortcut in the top left corner?

[Bug 46441] Steam shows an extra icon when minimizing window

https://bugs.winehq.org/show_bug.cgi?id=46441

--- Comment #2 from Andrey Gusev  ---
I mean an icon with a black background and misplaced text.

[Bug 46441] Steam shows an extra icon when minimizing window

https://bugs.winehq.org/show_bug.cgi?id=46441

--- Comment #3 from Olivier F. R. Dierick  ---
Created attachment 63226
  --> https://bugs.winehq.org/attachment.cgi?id=63226
Minimized icon and misplaced text in virtual desktop mode.

I got it too.

My observations:
- The minimized icon top left corner is placed at the same X, Y coordinates
than the original window;
- The label is wrongly placed relative as if the top left corner of the icon
was at 0, 0;
- The icon has the right-click window menu (restore, etc.) and reacts to
clicking (double left click restores the window).
- The label doesn't react to mouse.
- Moving the icon (hold left click - move - release) does move the icon and the
label is rightly placed under the icon;
- Restoring the window put it at its original position;

Except for the misplaced label, this is mostly consistent with Win 3.x
behavior.

When there is no icon in the systray, the taskbar hides itself.
If there were no minimized icon you would have no way to restore the window.
The minimized icon allows for restoring the window when the taskbar is hidden.

Steam adds an icon to the systray so the minimized icon is not useful for it,
but it's not the common case.
Fixing this would require making the 'minimize to icon' feature conditional to
the visibility of the taskbar.
I guess it qualifies as a UI enhancement.

[Bug 46441] Steam shows an extra icon when minimizing window

https://bugs.winehq.org/show_bug.cgi?id=46441

--- Comment #4 from Olivier F. R. Dierick  ---
I tested with notepad alone :
- There is no taskbar.
- Minimizing notepad puts an icon with its label in the bottom right corner.
- Notepad can be restored through the icon.

I tested Notepad + Steam:
- Minimizing notepad doesn't display any icon.
- While the taskbar is visible, one can restore notepad by clicking on the
window button on the taskbar.
- After closing Steam, the taskbar hides itself;
- Notepad still doesn't minimize to an icon.
- The only way to restore notepad is to launch taskmgr(or any app that puts an
icon in the systray) in the same wineserver instance, and the taskbar will
reappear.

I think there is more than one issue with the 'minimize to icon' handling.

[Bug 46441] Steam shows an extra icon when minimizing window

https://bugs.winehq.org/show_bug.cgi?id=46441

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Zebediah Figura  ---
I also have patches in the works that get rid of "minimize to icon" behaviour
altogether; see bug 7287 and associated Wine-Staging patch. I haven't tested
but that probably solves this bug as well. As far as I'm aware this is probably
the best way forward, as I don't think current Windows (or even as far back as
XP) has any way to configure minimizing to icons, but I'd certainly welcome
criticisms in that respect.

[Bug 46441] Steam shows an extra icon when minimizing window

https://bugs.winehq.org/show_bug.cgi?id=46441

--- Comment #6 from Olivier F. R. Dierick  ---
(In reply to Zebediah Figura from comment #5)
> I also have patches in the works that get rid of "minimize to icon"
> behaviour altogether; see bug 7287 and associated Wine-Staging patch. I
> haven't tested but that probably solves this bug as well. As far as I'm
> aware this is probably the best way forward, as I don't think current
> Windows (or even as far back as XP) has any way to configure minimizing to
> icons, but I'd certainly welcome criticisms in that respect.

We need a way to restore the minimized windows when the taskbar is not visible. 
The "minimize to icon" feature can't be removed unless this is fixed first.

I think that the simplest fix is to remove the current auto-hide/auto-show
linked to the numbers of icons in the systray and make the taskbar always
visible. Now that the taskbar is always under other window, there should no be
any issue.

An actual 'auto-hide' option could be added as an enhancement, after the
taskbar option from bug 46437 is implemented.

[Bug 46441] Steam shows an extra icon when minimizing window

https://bugs.winehq.org/show_bug.cgi?id=46441

pattietreutel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 46441] Steam shows an extra icon when minimizing window

https://bugs.winehq.org/show_bug.cgi?id=46441

--- Comment #7 from Zebediah Figura  ---
Even with the (somewhat) recent patches this isn't really fixed. There's still
a phantom window, but now it's a different shape.

[Bug 46441] Steam shows an extra icon when minimizing window

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46441

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
           Severity|normal                      |trivial

--- Comment #8 from Ken Sharp  ---
Please retry in Wine 7.9 (or later).

[Bug 46441] Steam shows an extra icon when minimizing window

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46441

--- Comment #9 from Andrey Gusev  ---
Still valid with 7.9-285-gc1e793f1119