[Bug 46055] New: FL Studio 20: Built-in file browser incorrectly shows image files alongside plugins in plugin database
https://bugs.winehq.org/show_bug.cgi?id=46055
Bug ID: 46055 Summary: FL Studio 20: Built-in file browser incorrectly shows image files alongside plugins in plugin database Product: Wine Version: 3.18 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: ajduck@outlook.com Distribution: ---
Created attachment 62640 --> https://bugs.winehq.org/attachment.cgi?id=62640 What it should look like (on Windows)
FL Studio has a built-in file browser on the left. It can be used to load plugins in a folder called "plugin database". The plugins can have images associated with them that show as thumbnails.
A basic description of how this works: when FL is installed or first used a folder called "plugin database" is created (the default location is ~/Documents/Image-Line/FL Studio/Presets/Plugin database/). In either "Effects" or "Generators", for each plugin there is a set of 3 files: .fst, .png and .nfo.
The .fst is a FL Studio state file and is the file that loads the plugin. The .png is the thumbnail for the plugin. The .nfo (which has the same name as the .fst) basically points to the image and probably all of them contain only "Bitmap=Plugin.png".
On Windows, the plugin database folder viewed from FL's file browser only lists the .fst files (with the pictures shown as a thumbnail for the .fst file) and hides the actual .png files that are referred to in the .nfo. See "What it should look like (on Windows)" image attached.
On Wine, the plugin database folder doesn't replicate this behaviour and lists the .png files alongside the .fst files. See "What it shouldn't look like (on Wine)" image.
Steps to reproduce:
1. Download FL Studio (link at bottom of this post) and install it. Skip ASIO4ALL installation if it comes up. 2. Open FL. It will load a project file on first startup. You can either just stay on that or go to File > New (if there's no text, press F12 -> F3 -> n, if a prompt comes up press n again). 3. On the left is the file browser sidebar. Click the button that has a plug icon (the last button of three) at the top of that sidebar. 4. Click on either the "Effects" or "Generators" folders, and then click on one of the subfolders. The .png files will be in the list, which doesn't happen on Windows.
Tested in a clean wineprefix.
OS: elementary OS 5.0 Juno (based on Ubuntu 18.04) Tested on Wine 3.19 but 3.18 also had this bug.
----------
Download link: http://demodownload.image-line.com/flstudio/flstudio_win_20.0.5.681.exe
$ sha1sum flstudio_win_20.0.5.681.exe 11901b66a65c526203dacbab7ec6a3c61edb1553 flstudio_win_20.0.5.681.exe
https://bugs.winehq.org/show_bug.cgi?id=46055
ajduck@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://demodownload.image-l | |ine.com/flstudio/flstudio_w | |in_20.0.5.681.exe
https://bugs.winehq.org/show_bug.cgi?id=46055
--- Comment #1 from ajduck@outlook.com --- Created attachment 62641 --> https://bugs.winehq.org/attachment.cgi?id=62641 What it shouldn't look like (on Wine)
https://bugs.winehq.org/show_bug.cgi?id=46055
--- Comment #2 from ajduck@outlook.com --- Still happening as of Wine 4.2 (Staging).
---
I figured out a workaround in the meantime if anyone uses FL's file browser to load plugins. Repeat these steps separately for the Effects and Generators folders:
1. Make a folder in the parent Effects/Generators folder called Images. Alongside it make an empty file called Images.nfo file and write:
Visible=False
in it. This hides the Images folder in FL's file browser.
2. Move all .png files for all the plugins in the parent folder and any child folders into the Images folder.
You can also sort them folder-wise in the same way as the parent folder so you can easily move everything back in if/when this bug is fixed (e.g. Generators/Images/SomeCategory/Plugin.png), but this is not strictly necessary.
3. Rewrite the path in each plugin's .nfo file to point to the .png in the Images folder. For example, this .nfo is located in Generators/FL/Sytrus.nfo and the .png is in Generators/Images/FL/Sytrus.png:
Bitmap=../Images/FL/Sytrus.png
I recommend writing a script to do these steps if you have a lot of .nfos because manually doing all this would take a while to do. If anyone wants my fish script that moves the images and writes to the .nfos automatically please comment.
https://bugs.winehq.org/show_bug.cgi?id=46055
ajduck@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED
--- Comment #3 from ajduck@outlook.com --- I have figured out the cause of this.
It turns out this isn't a Wine bug. Wine is working correctly. It's to do with Windows/DOS file attributes.
----
So basically what I was doing was adding my own .png files and putting them in the plugin database folder. Partially this was out of necessity, because some plugins don't correctly get screenshotted in FL Studio's plugin picture making feature (namely ones that use the graphics acceleration, this I believe is possibly a Wine bug) and so I had to make my own screenshots of them and then crop them.
FL Studio's own plugin picture making feature takes a screenshot of the plugin and creates a .png of it. But what it does when it saves that picture is not immediately apparent: it adds DPI information to the png attributes and it also adds Archive and Hidden attributes to the file.
The first one I found out because when I was adding my own manually screenshotted and edited images to the plugin database folder my images were showing up way too big in the plugin database compared to the already included images with a similar resolution.
But the second one was not as apparent because by the time I realised the issue with the images not hiding in the browser I had already applied the "workaround" I stated in the last comment (using a separate Images folder and then hiding it). I realised there was possibly some missing attribute when I used FL's "Add [plugin] to plugin database" feature which automatically screenshots a plugin and adds it into the plugin database/browser and the .png FL created was appearing correctly. Eventually (thanks to using exa as a replacement for ls) I found out about extended attributes and that there was extended attributes to the files FL was creating.
As said earlier, FL adds the Windows attributes "Archive" and "Hidden" to the .png file. Wine/GNU+Linux environments represent this using extended attributes:
user.DOSATTRIB="0x22"
With "0x20" being Archive and "0x2" being Hidden. If the .png file doesn't have this attribute it will show up in FL's browser.
----
So if you're doing something similar to me, making manual screenshots of plugins in order to workaround the FL screenshot bug with graphically accelerated plugins, you need to add this extended attribute to the file (the escaping of the quotes is necessary as the value needs to be a string):
setfattr -n user.DOSATTRIB -v '"0x22"' File.png
To check the file now has the attribute:
getfattr -n user.DOSATTRIB File.png
Anyway, this issue is not a Wine bug. It's a weird thing FL does that's not obvious, especially in a Wine environment. Mystery solved.
Thank you to the Wine team for your ongoing work!
https://bugs.winehq.org/show_bug.cgi?id=46055
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #4 from Ken Sharp imwellcushtymelike@gmail.com --- Closing bugs marked as invalid.
https://bugs.winehq.org/show_bug.cgi?id=46055
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL|http://demodownload.image-l |https://web.archive.org/web |ine.com/flstudio/flstudio_w |/20180930122250/http://demo |in_20.0.5.681.exe |download.image-line.com/fls | |tudio/flstudio_win_20.0.5.6 | |74.exe CC| |focht@gmx.net
--- Comment #5 from Anastasius Focht focht@gmx.net --- Hello folks,
adding stable download link via Internet Archive for documentation.
https://web.archive.org/web/20180930122250/http://demodownload.image-line.co...
$ sha1sum flstudio_win_20.0.5.674.exe 521e8558d3cbc54d5f42add5658efe44eaec4a5f flstudio_win_20.0.5.674.exe
$ du -sh flstudio_win_20.0.5.674.exe 673M flstudio_win_20.0.5.674.exe
Regards
-
wine-bugs＠winehq.org -
WineHQ Bugzilla