https://bugs.winehq.org/show_bug.cgi?id=48697
Bug ID: 48697 Summary: New msvcrt inlines fail to compile on armv7hl due to non-AAPCS variadic function calls Product: Wine Version: 5.3 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msvcrt Assignee: wine-bugs@winehq.org Reporter: mike@cchtml.com Distribution: ---
Two of the new msvcrt inlines added in 5.3 need to be fixed to compile on armv7hl.
- ee02f93cc90d4ffeff6aab1ad63e40024fe01276 - 6bc15730457b780c47374d3e922287cafd36b233
One possible solution is to use WINAPIV on the function instead of __cdecl.
Compiler output from ARM build:
In file included from ../../include/msvcrt/stdio.h:11, from ../../include/wine/debug.h:25, from ../d3dx9_36/d3dx9_private.h:27, from ../d3dx9_36/animation.c:22: ../../include/msvcrt/corecrt_wstdio.h: In function '_snwprintf_s': ../../include/msvcrt/corecrt_wstdio.h:119:1: error: variadic functions must use the base AAPCS variant 119 | { | ^ In file included from ../../include/wine/debug.h:25, from ../d3dx9_36/d3dx9_private.h:27, from ../d3dx9_36/animation.c:22: ../../include/msvcrt/stdio.h: In function '_snprintf_s': ../../include/msvcrt/stdio.h:178:1: error: variadic functions must use the base AAPCS variant 178 | { | ^
https://bugs.winehq.org/show_bug.cgi?id=48697
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jacek@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=48697
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Hardware|x86 |arm
https://bugs.winehq.org/show_bug.cgi?id=48697
Jacek Caban jacek@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |ee02f93cc90d4ffeff6aab1ad63 | |e40024fe01276
--- Comment #1 from Jacek Caban jacek@codeweavers.com --- Yes, those should use WINAPIV, it's a typo. I will send a patch. Thanks for the report.
https://bugs.winehq.org/show_bug.cgi?id=48697
Vijay Kamuju infyquest@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |d34ae79dddd750523304a615c8a | |aaa2745a19adc Status|UNCONFIRMED |RESOLVED CC| |infyquest@gmail.com
--- Comment #2 from Vijay Kamuju infyquest@gmail.com --- fixed by https://source.winehq.org/git/wine.git/commitdiff/d34ae79dddd750523304a615c8...
https://bugs.winehq.org/show_bug.cgi?id=48697
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #3 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.4.