[Bug 47486] New: GsView draws one menu item with white background

https://bugs.winehq.org/show_bug.cgi?id=47486

Bug ID: 47486
           Summary: GsView draws one menu item with white background
           Product: Wine
           Version: 4.11
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 64866
  --> https://bugs.winehq.org/attachment.cgi?id=64866
Screenshot on wine

See screenshot.

[Bug 47486] GsView draws one menu item with white background

https://bugs.winehq.org/show_bug.cgi?id=47486

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://ghostgum.com.au/down
                   |                            |load/gsv50w32.exe
           Keywords|                            |download
           See Also|                            |https://jira.reactos.org/br
                   |                            |owse/CORE-13935

[Bug 47486] GsView draws one menu item with white background

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47486

--- Comment #1 from Fabian Maurer  ---
Issue still present in wine-6.16

[Bug 47486] GsView draws one menu item with white background

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47486

--- Comment #2 from Fabian Maurer  ---
Turns out the problem are the used bitmaps that are displayed in the menu.
It works when the bitmap has the color table {0x000000, 0xffffff} but it breaks
with the color table {0xffffff, 0x000000}.

On windows, the white is in both cases replaced with the background color, in
Wine it only works in the first case.

[Bug 47486] GsView draws one menu item with white background

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47486

--- Comment #3 from Fabian Maurer  ---
Created attachment 70630
  --> https://bugs.winehq.org/attachment.cgi?id=70630
Patch to allow white as first in color table

Attaching a patch to allow white as first in color table.

Quote from the code I changed:
> - Note : If the first color in the color table is white followed by
> -
>    black, we can't convert it to a monochrome DDB with
> -
>    SetDIBits, because black and white would be inverted.

Not sure what exactly that means, it works for this usecase at least. Would
probably need some adjustments...

[Bug 47486] GsView draws one menu item with white background

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47486

--- Comment #4 from Fabian Maurer  ---
I need to write some tests, I'll be coming back to this.

[Bug 47486] GsView draws one menu item with white background

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47486

--- Comment #5 from Fabian Maurer  ---
Still present as of wine-7.7. Might also affect gdi32, which also uses a
"is_dib_monochrome" function. Needs tests though.

[Bug 47486] GsView draws one menu item with white background

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47486

--- Comment #6 from Fabian Maurer  ---
Still present in wine-9.11, but you need to disable the Light theme