[Bug 42937] New: Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

Bug ID: 42937
           Summary: Multiply games stuck with stack overflow when using
                    OffscreenRenderingMode=backbuffer
           Product: Wine
           Version: 2.7
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 58088
  --> https://bugs.winehq.org/attachment.cgi?id=58088
log_bad

This is actually a regression caused by:

cad4badbcf25992e0c61521aa15e639c2611f5d6
wined3d: Get rid of wined3d_select_blitter()

Attaching 2 log files with WINEDEBUG="+d3d9,+d3d_shader,+d3d_surface,+seh,+tid"
One at cad4badbcf25992e0c61521aa15e639c2611f5d6 (the bad one)
Another at 4b8c0d8784593d2830f66407a51e88934ad7adb4 (the good one)

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |cad4badbcf25992e0c61521aa15
                   |                            |e639c2611f5d6
           Keywords|                            |regression
                 CC|                            |[e-mail]

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

--- Comment #1 from [e-mail] ---
Created attachment 58089
  --> https://bugs.winehq.org/attachment.cgi?id=58089
log_good

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

--- Comment #2 from Henri Verbeet  ---
Could you recreate those logs with WINEDEBUG="+d3d9,+d3d,+seh,+tid"? Does any
of the affected applications have a demo that can be used to reproduce the
issue? Also, any particular reason for using "backbuffer" ORM? It's generally
just worse than using "fbo".

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

--- Comment #3 from [e-mail] ---
> Does any of the affected applications have a demo that can be used to reproduce the issue?

None that I'm aware of, sorry. Though one of the affected games is "King's
Bounty: Легенда о рыцаре" (cd version 1.7). Simply starting the new game should
reproduce the issue.

But I'm willing to provide any logs, backtraces and test patches of course.
> Also, any particular reason for using "backbuffer" ORM?

Yes, at least one of those games doesn't work with "fbo", it spams tons of:
err:d3d:wined3d_debug_callback 0x15fc3d8: "GL_INVALID_OPERATION in
glBlitFramebuffer(bad src/dst multisample region sizes)" 
etc.

But it's another issue I guess.

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58088|0                           |1
        is obsolete|                            |

--- Comment #4 from [e-mail] ---
Created attachment 58095
  --> https://bugs.winehq.org/attachment.cgi?id=58095
log_bad

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58089|0                           |1
        is obsolete|                            |

--- Comment #5 from [e-mail] ---
Created attachment 58096
  --> https://bugs.winehq.org/attachment.cgi?id=58096
log_good

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

--- Comment #6 from [e-mail] ---
Created attachment 58100
  --> https://bugs.winehq.org/attachment.cgi?id=58100
Hack fix

Here is a small hack fix. This is obviously not how it should be fixed, but
hopefully it will give an idea of what is going wrong here.

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

--- Comment #7 from Henri Verbeet  ---
Created attachment 58223
  --> https://bugs.winehq.org/attachment.cgi?id=58223
patch #1

Does this patch help?

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

--- Comment #8 from Henri Verbeet  ---
Created attachment 58224
  --> https://bugs.winehq.org/attachment.cgi?id=58224
patch #2

And how about this one?

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

--- Comment #9 from [e-mail] ---
patch #1 is somewhat an improvement as I get ~3 seconds of gameplay, but it
still crashes with stack overflow

While the patch #2 definitely helps!

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |d37146885801ae384a1cae54ede
                   |                            |a426b7b58a6a9

--- Comment #10 from Henri Verbeet  ---
Should be fixed by commit d37146885801ae384a1cae54edea426b7b58a6a9.

[Bug 42937] Multiply games stuck with stack overflow when using OffscreenRenderingMode =backbuffer

https://bugs.winehq.org/show_bug.cgi?id=42937

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  ---
Closing bugs fixed in 2.9.