http://bugs.winehq.org/show_bug.cgi?id=10544
Summary: treeview scrolling on collapsing is broken on windows Product: Wine Version: unspecified Platform: PC-x86-64 OS/Version: Windows XP Status: UNCONFIRMED Severity: normal Priority: P2 Component: wine-comctl32 AssignedTo: wine-bugs@winehq.org ReportedBy: timo.kreuzer@web.de
when using comctl32.dll on windows and use for example regedit with it, then collapsing of treeview items messes up the treeview. This is due to not using any ClipRegion in ScrollWindowEx when collapsing. Maybe there's also a bug in ScrollWindowEx.
To fix, simply replace
ScrollWindowEx (infoPtr->hwnd, 0, scrollDist, &scrollRect, NULL, NULL, NULL, SW_ERASE | SW_INVALIDATE);
with
ScrollWindowEx (infoPtr->hwnd, 0, scrollDist, &scrollRect, &scrollRect, NULL, NULL, SW_ERASE | SW_INVALIDATE);
in TREEVIEW_Collapse()
http://bugs.winehq.org/show_bug.cgi?id=10544
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial OS/Version|Windows XP |other
--- Comment #1 from Vitaliy Margolen vitaliy@kievinfo.com 2007-11-23 02:16:48 --- What Wine version?
when using comctl32.dll on windows and use for example regedit with it, then collapsing of treeview items messes up the treeview.
Elaborate.
http://bugs.winehq.org/show_bug.cgi?id=10544
--- Comment #2 from Timo Kreuzer timo.kreuzer@web.de 2007-11-26 14:13:43 --- wine-0.9.49
The line is comctl32/treeview.c:3230
ScrollWindowEx will scroll the whole content of the scrollRect up by scrolldist pixels. At that point scrollRect covers the whole area below the collapsed item. ScrollWindowEx will draw outside the scrollRect, if no clipping rect is set, so the area below the collapsed item will be scrolled up and drawn over the upper part of the treeview.
btw: Windows regedit doesn't show this (don't know why), but ReactOS regedit does on windows xp+wine comctl32.dll, it works correctly with windows comctl32.dll
http://bugs.winehq.org/show_bug.cgi?id=10544
--- Comment #3 from Timo Kreuzer timo.kreuzer@web.de 2007-11-26 14:20:23 --- Created an attachment (id=9359) --> (http://bugs.winehq.org/attachment.cgi?id=9359) drawing error
This is how the treeview looks after collapsing HKEY_LOCAL_MACHINE. The part above it is overdrawn with the contents that have previously been subnodes of HKLM.
http://bugs.winehq.org/show_bug.cgi?id=10544
Avenger bgp@cs.elte.hu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bgp@cs.elte.hu
--- Comment #4 from Avenger bgp@cs.elte.hu 2008-05-10 14:43:39 --- Similar things happen on expanding a treeview, if the expansion requires scrolling. It is possible to 'shake' the content in shape, but initially it draws the content incorrectly.
http://bugs.winehq.org/show_bug.cgi?id=10544
Gabriel Rodriguez g_the_master@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |g_the_master@hotmail.com
--- Comment #5 from Gabriel Rodriguez g_the_master@hotmail.com 2008-06-09 10:21:36 --- Could somebody please apply this patch?
http://bugs.winehq.org/show_bug.cgi?id=10544
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #6 from Dan Kegel dank@kegel.com 2008-06-09 10:44:18 --- Please submit it as a patch to wine-patches. See http://www.winehq.org/site/sending_patches
It would be nice if you could write a test case for it, though I imagine that might be difficult.
http://bugs.winehq.org/show_bug.cgi?id=10544
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=10544
Colin Finck mail@colinfinck.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@colinfinck.de
--- Comment #7 from Colin Finck mail@colinfinck.de 2008-06-09 17:06:18 --- A patch was submitted to wine-patches: http://www.winehq.org/pipermail/wine-patches/2008-June/055675.html
http://bugs.winehq.org/show_bug.cgi?id=10544
Paul Sanders p.sanders@alpinesoft.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |p.sanders@alpinesoft.co.uk
--- Comment #8 from Paul Sanders p.sanders@alpinesoft.co.uk 2008-10-08 04:51:26 --- Colin, your patch got lost in the post: "A non-text attachment was scrubbed...". Could you resubmit it? It is important to me that this gets into the official source tree (no pun intended) sooner rather than later. Thanks.
And greetings to all. I am new here. I am a one-man-band Windows developer and I hope to get my app (by modifying my own source code, mostly) to run acceptably well under Wine. Specifically, I hope to be able to produce a saleable product that will run on CrossOver Mac. Wish me luck! (might need it)
http://bugs.winehq.org/show_bug.cgi?id=10544
--- Comment #9 from Dmitry Timoshkov dmitry@codeweavers.com 2008-10-08 05:09:37 --- That patch has been committed to git at the same day when it was submitted.
http://bugs.winehq.org/show_bug.cgi?id=10544
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #10 from Dmitry Timoshkov dmitry@codeweavers.com 2008-10-08 05:12:37 --- The bug should be fixed.
http://bugs.winehq.org/show_bug.cgi?id=10544
--- Comment #11 from Dmitry Timoshkov dmitry@codeweavers.com 2008-10-08 05:16:37 --- (In reply to comment #8)
And greetings to all. I am new here. I am a one-man-band Windows developer and I hope to get my app (by modifying my own source code, mostly) to run acceptably well under Wine.
Your best bet is to open a bug for each problem you face with, preferably providing small test cases since obviously you have the source of your app and can easily isolate each problem.
http://bugs.winehq.org/show_bug.cgi?id=10544
--- Comment #12 from Paul Sanders p.sanders@alpinesoft.co.uk 2008-10-08 05:36:25 --- Thank you Dmitry. This information (both bits) is much appreciated, and no slur on your excellent product was intended.
I might communicate with you privately, if I may, to learn a little more on how and when changes like this make it into the shipping version (or beta builds - I have been talking to James Ramey) of CrossOver Mac. There's no urgency as I have barely started on my journey; I'd just like to understand (at some level) how things work. I imagine this is the sort of thing that CodeWeavers would want to get to their customers ASAP.
http://bugs.winehq.org/show_bug.cgi?id=10544
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org 2008-10-10 10:09:04 --- Closing bugs fixed in 1.1.6.
-
wine-bugs＠winehq.org