[Bug 28776] New: Korean Text don't shown.(in 2011-11-18 git)

http://bugs.winehq.org/show_bug.cgi?id=28776

Bug #: 28776
           Summary: Korean Text don't shown.(in 2011-11-18 git)
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 36971
  --> http://bugs.winehq.org/attachment.cgi?id=36971
error screen capture

winecfg& regedit etc don't show korean Text.

I downgraded 2011-10-7 git version
No Error.

[Bug 28776] Korean Text don't shown.(in 2011-11-18 git)

http://bugs.winehq.org/show_bug.cgi?id=28776

--- Comment #1 from YunSong Hwang  2011-10-18 03:18:12 CDT ---
Created attachment 36973
  --> http://bugs.winehq.org/attachment.cgi?id=36973
No Error Screen Capture

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.3.30
            Summary|Korean Text don't shown.(in |Korean text isn't shown
                   |2011-11-18 git)             |

--- Comment #2 from Dmitry Timoshkov  2011-10-18 05:20:22 CDT ---
What's your locale? What font links do you have installed in the registry?

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #3 from Austin English  2011-10-18 12:26:03 CDT ---
Could you please run a regression test?
http://wiki.winehq.org/RegressionTesting

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

YunSong Hwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |gdi32

--- Comment #4 from YunSong Hwang  2011-10-19 06:50:12 CDT ---
I changed gdi32.so old gdi32.so(2011-10-7-git)
No Error.

Changed file 
-->
dlls/gdi32/freetype.c

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Austin English  2011-10-19 13:08:41 CDT ---
That narrows it down a bit, presumably a recent DIB engine change, but an exact
commit would be more helpful.

CC'in Huw.

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

--- Comment #6 from YunSong Hwang  2011-10-20 04:11:07 CDT ---
Changed file is gdi32/freetype.c

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

--- Comment #7 from Dmitry Timoshkov  2011-10-20 04:41:50 CDT ---
(In reply to comment #6)
> Changed file is gdi32/freetype.c

Please perform a proper regression test you were asked about. See wiki page
referenced above for instructions.

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

--- Comment #8 from YunSong Hwang  2011-10-21 06:58:16 CDT ---
I guess
wine don't use freetype.
-----
I edit system.reg
"MS Shell Dlg"="Gulim"
-->
"MS Shell Dlg"="\xc740 \xb3cb\xc6c0"
korean text is shown..
-----
But,wine 2011-10-7 git version don't need to fix system.reg

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

--- Comment #9 from Huw Davies  2011-10-21 09:43:25 CDT ---
Could you remove that change from system.reg and generate a +font log with
the new (broken) version of Wine and then the old (working) version?

Thanks

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

--- Comment #10 from YunSong Hwang  2011-10-31 06:33:54 CDT ---
I test wine-a155292f98f62c10eaf3b9328cbd8c085b8818e9-dll/gdi32/freetype.c
WineEngInit fuction.
No Error.

My Fix..
-----
BOOL WineEngInit(void)
{
    HKEY hkey_font_cache;
    DWORD disposition;
    HANDLE font_mutex;

/* update locale dependent font info in registry */
    update_font_info();

if(!init_freetype()) return FALSE;

if((font_mutex = CreateMutexW(NULL, FALSE, font_mutex_nameW)) == NULL)
    {
        ERR("Failed to create font mutex\n");
        return FALSE;
    }
    WaitForSingleObject(font_mutex, INFINITE);

create_font_cache_key(&hkey_font_cache, &disposition);

//    if(disposition == REG_CREATED_NEW_KEY)//make error
        init_font_list();
  //  else//make error
    //    load_font_list_from_cache(hkey_font_cache);//make error.

RegCloseKey(hkey_font_cache);

reorder_font_list();

DumpFontList();
    LoadSubstList();
    DumpSubstList();
    LoadReplaceList();

//    if(disposition == REG_CREATED_NEW_KEY)//wine-a155292 don't have
        update_reg_entries();

update_system_links();
    init_system_links();

ReleaseMutex(font_mutex);
    return TRUE;
}
--

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Jerome Leclanche  2011-11-02 05:26:25 CDT ---
What's up with this bug?

OP, can you run the regression test you were asked to run?
http://wiki.winehq.org/RegressionTesting

Does "git revert 17e72c816b9cbc17aeaae1c2ecf2ba230083817d" help?

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

YunSong Hwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
           Severity|normal                      |enhancement

--- Comment #12 from YunSong Hwang  2011-12-18 07:11:53 CST ---
2011-12-18 git version is no problem

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  2011-12-30 12:55:34 CST ---
Closing bugs fixed in 1.3.36.

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

YunSong Hwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
            Version|1.3.30                      |1.5.10
         Resolution|FIXED                       |

--- Comment #14 from YunSong Hwang  2012-08-07 08:25:00 CDT ---
I updated fedora15(use freetype-2.4.8-3.fc17)..
and git update..

this error has occurred again..

I test git versions
wine-286854f->error.
wine-c683ad7->No error..

I edit function of freetype.c.

func name is
static HFONT freetype_SelectFont( PHYSDEV dev, HFONT hfont ).
My fix is
---
4656,4660c4656,4658
< if(csi.fs.fsCsb[0] & (face->fs.fsCsb[0] | face->fs.fsCsb[0])) //add
< //            if(face->vertical == want_vertical &&
< //               (csi.fs.fsCsb[0] & face->fs.fsCsb[0] 
< //||              (font_link != NULL && csi.fs.fsCsb[0] &
font_link->fs.fsCsb[0]))) 
< {
---
>         if(face->vertical == want_vertical &&
>            (csi.fs.fsCsb[0] & face->fs.fsCsb[0] ||
>             (font_link != NULL && csi.fs.fsCsb[0] & font_link->fs.fsCsb[0]))) {

---
I attached fixed gdi32-freetype.c

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

--- Comment #15 from YunSong Hwang  2012-08-07 08:27:14 CDT ---
Created attachment 41310
  --> http://bugs.winehq.org/attachment.cgi?id=41310
fixed gdi32-freetype.c

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Qian Hong  2012-08-07 09:25:37 CDT ---
(In reply to comment #14)
> I updated fedora15(use freetype-2.4.8-3.fc17)..
> and git update..
>
> this error has occurred again..

Hi, YunSong

I suggest to create a new bug report for it, I thinks this might be a separate
bug.

I tried on Ubuntu 11.10 with `LC_ALL=ko_KR.utf8 winecfg` but can't reproduce,
please open a new bug and CC me, let's discuss there.

Regards!

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #17 from Austin English  2012-08-07 14:14:57 CDT ---
Please file a new bug.

[Bug 28776] Korean text isn't shown

http://bugs.winehq.org/show_bug.cgi?id=28776

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Austin English  2012-08-07 14:15:02 CDT ---
Closing.