https://bugs.winehq.org/show_bug.cgi?id=48308
Bug ID: 48308 Summary: KERNEL32.dll.SetEnvironmentStringsW function needed for GoG Galaxy Product: Wine-staging Version: 5.0-rc1 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: berillions@gmail.com CC: leslie_alistair@hotmail.com, z.figura12@gmail.com Distribution: ---
Created attachment 66020 --> https://bugs.winehq.org/attachment.cgi?id=66020 Crash dialog box
Hi,
The open beta for GoG Galaxy 2 is available to replace Galaxy 2. The launcher works with Wine and it's possible to install/update games with it but it's not possible to launch a game.
Each time you launch a game, a crash report box appears. In the output console, i have this line which appears each time a game is launched :
------ 2019-12-18 23:29:24.624 [Information][ (0)] [TID 9][galaxy_client]: Launching the game: Beyond Good and Evil (gog_1207658746). wine: Call from 0x7bc94bf9 to unimplemented function KERNEL32.dll.SetEnvironmentStringsW, aborting 2019-12-18 23:29:24.627 [Information][ (0)] [TID 9][galaxy_client]: The game 'gog_1207658746' is pending launch. ------
Thanks for your help
https://bugs.winehq.org/show_bug.cgi?id=48308
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |kernel32 CC|leslie_alistair@hotmail.com | |, z.figura12@gmail.com | Product|Wine-staging |Wine
--- Comment #1 from Zebediah Figura z.figura12@gmail.com --- Not a Staging bug; moving to the Wine product.
https://bugs.winehq.org/show_bug.cgi?id=48308
--- Comment #2 from Berillions berillions@gmail.com --- (In reply to Zebediah Figura from comment #1)
Not a Staging bug; moving to the Wine product.
I choose wine-staging instead of Wine because GoG Galaxy 2 does not work oob with plain Wine. Staging patches are needed to use correctly the launcher.
https://bugs.winehq.org/show_bug.cgi?id=48308
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
--- Comment #3 from Zebediah Figura z.figura12@gmail.com --- (In reply to Berillions from comment #2)
(In reply to Zebediah Figura from comment #1)
Not a Staging bug; moving to the Wine product.
I choose wine-staging instead of Wine because GoG Galaxy 2 does not work oob with plain Wine. Staging patches are needed to use correctly the launcher.
Sure, and that's useful to mention. But we reserve the Staging product for bugs *caused* or introduced by Staging patches.
https://bugs.winehq.org/show_bug.cgi?id=48308
--- Comment #4 from Berillions berillions@gmail.com --- Created attachment 66029 --> https://bugs.winehq.org/attachment.cgi?id=66029 SetEnvironmentStringsW stub patch
Hello,
With the help from Gverm (Gijs Vermeulen) on VKx Discord, i create a patch to add stub function for SetEnvironmentStringsW.
I can confirm that the patch works in my case and all my games can be launched directly from the launcher.
https://bugs.winehq.org/show_bug.cgi?id=48308
Beta Version betaversiondot@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |betaversiondot@gmail.com
--- Comment #5 from Beta Version betaversiondot@gmail.com --- (In reply to Berillions from comment #4)
Created attachment 66029 [details] SetEnvironmentStringsW stub patch
Hello,
With the help from Gverm (Gijs Vermeulen) on VKx Discord, i create a patch to add stub function for SetEnvironmentStringsW.
I can confirm that the patch works in my case and all my games can be launched directly from the launcher.
Hi. Any ideas when this patch will be added to Wine?
https://bugs.winehq.org/show_bug.cgi?id=48308
--- Comment #6 from Nikolay Sivov bunglehead@gmail.com --- I don't think it makes sense to have a stub, proper implementation with tests does not look too hard. It's a new function, so it won't make it to 5.0 most likely.
https://bugs.winehq.org/show_bug.cgi?id=48308
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|KERNEL32.dll.SetEnvironment |KERNEL32.dll.SetEnvironment |StringsW function needed |StringsW function needed |for GoG Galaxy |for GoG Galaxy 2 beta CC| |o.dierick@piezo-forte.be
https://bugs.winehq.org/show_bug.cgi?id=48308
--- Comment #7 from Berillions berillions@gmail.com --- (In reply to Nikolay Sivov from comment #6)
I don't think it makes sense to have a stub, proper implementation with tests does not look too hard. It's a new function, so it won't make it to 5.0 most likely.
it's hard for me :D you're free to do that if you want
https://bugs.winehq.org/show_bug.cgi?id=48308
Vijay Kamuju infyquest@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |infyquest@gmail.com
--- Comment #8 from Vijay Kamuju infyquest@gmail.com --- This might need tests due to https://github.com/MicrosoftDocs/feedback/issues/2235
https://bugs.winehq.org/show_bug.cgi?id=48308
maniikarabera@protonmail.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |maniikarabera@protonmail.ch
https://bugs.winehq.org/show_bug.cgi?id=48308
Evgenii Burmentev [:virus_found] vir.found@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vir.found@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=48308
--- Comment #9 from Beta Version betaversiondot@gmail.com --- With WINE 5.1 that is still an issue. Can somebody add this stub provided by Berillions, so that GOG Galaxy could be used without waiting until somebody add a proper implementation?
https://bugs.winehq.org/show_bug.cgi?id=48308
krinkodot22@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |krinkodot22@hotmail.com
--- Comment #10 from krinkodot22@hotmail.com --- Still a problem in wine-5.3 (Staging).
https://bugs.winehq.org/show_bug.cgi?id=48308
Ernestas Kulik ernestas.kulik+wine@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ernestas.kulik+wine@gmail.c | |om
--- Comment #11 from Ernestas Kulik ernestas.kulik+wine@gmail.com --- Oh, good, and I was about to give this a stab myself: https://www.winehq.org/pipermail/wine-devel/2020-January/157715.html
https://bugs.winehq.org/show_bug.cgi?id=48308
wk@mailstation.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wk@mailstation.de
https://bugs.winehq.org/show_bug.cgi?id=48308
gardenapple goldenapplemc3@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |goldenapplemc3@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=48308
Alexandr Oleynikov sashok.olen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sashok.olen@gmail.com
--- Comment #12 from Alexandr Oleynikov sashok.olen@gmail.com --- Since that attempt at implementation was rejected upstream with no follow up, can at least the stub be staged? Thanks
https://bugs.winehq.org/show_bug.cgi?id=48308
Yaroslav Freeman arhangel3102@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |arhangel3102@gmail.com
--- Comment #13 from Yaroslav Freeman arhangel3102@gmail.com --- Wine 5.7 Staging. The same error appears. GOG Galaxy 2.0 itself works well. I can run it and install the game. However, there is no way to start the game from the client. A dialog box for sending an error message appears.
2020-04-29 17:47:54.704 [Information][ (0)] [TID 40][galaxy_client]: Launching the game: Risen 3: Titan Lords (gog_1454068042). wine: Call from 0x7bc92d79 to unimplemented function KERNEL32.dll.SetEnvironmentStringsW, aborting 2020-04-29 17:47:54.707 [Information][ (0)] [TID 40][galaxy_client]: The game 'gog_1454068042' is pending launch.
https://bugs.winehq.org/show_bug.cgi?id=48308
--- Comment #14 from Zebediah Figura z.figura12@gmail.com --- I can't get Galaxy 2 to install in either upstream Wine or Wine-Staging, using either the reported version of 5.0 or the current version of 5.7. In every case it gets stuck spinning on PeekMessage() and has an unresponsive UI and black text.
Are there workarounds which haven't been mentioned in the original report?
zeb@terabithia:~/Downloads$ sha1sum GOG_Galaxy_2.0.exe 1f0310b2adb6b6ad2e0ff968a20c232bb9bd6835 GOG_Galaxy_2.0.exe
https://bugs.winehq.org/show_bug.cgi?id=48308
--- Comment #15 from Yaroslav Freeman arhangel3102@gmail.com --- (In reply to Zebediah Figura from comment #14)
Я не могу заставить Galaxy 2 установить в любом восходящем Wine или Wine-Staging, используя либо сообщенную версию 5.0, либо текущую версию 5.7. В каждом случае он застревает вращаясь на PeekMessage () и имеет безответный пользовательский интерфейс и черный текст.
Существуют ли обходные пути, которые не были упомянуты в первоначальном отчете?
zeb@terabithia:~ / скачивает$ sha1sum GOG_Galaxy_2.0.exe 1f0310b2adb6b6ad2e0ff968a20c232bb9bd6835 GOG_Galaxy_2.0.exe
You need to install NET.Framework 4.7.1
https://bugs.winehq.org/show_bug.cgi?id=48308
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |877bf2a7a09b9fb21f1aeb7a576 | |a033bf5910f16 Resolution|--- |FIXED
--- Comment #16 from Zebediah Figura z.figura12@gmail.com --- Fixed by https://source.winehq.org/git/wine.git/commitdiff/877bf2a7a09b9fb21f1aeb7a576a033bf5910f16.
https://bugs.winehq.org/show_bug.cgi?id=48308
--- Comment #17 from Yaroslav Freeman arhangel3102@gmail.com --- (In reply to Zebediah Figura from comment #16)
Fixed by https://source.winehq.org/git/wine.git/commitdiff/ 877bf2a7a09b9fb21f1aeb7a576a033bf5910f16.
Will this fix be added to the next wine-staging release?
https://bugs.winehq.org/show_bug.cgi?id=48308
--- Comment #18 from Zebediah Figura z.figura12@gmail.com --- (In reply to Yaroslav Freeman from comment #17)
Will this fix be added to the next wine-staging release?
Yes, it will be released as part of wine and wine-staging 5.8.
https://bugs.winehq.org/show_bug.cgi?id=48308
--- Comment #19 from Yaroslav Freeman arhangel3102@gmail.com --- (In reply to Zebediah Figura from comment #18)
Yes, it will be released as part of wine and wine-staging 5.8.
Thank you so much.
https://bugs.winehq.org/show_bug.cgi?id=48308
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #20 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.8.
https://bugs.winehq.org/show_bug.cgi?id=48308
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|KERNEL32.dll.SetEnvironment |GoG Galaxy 2 Beta crashes |StringsW function needed |on unimplemented function |for GoG Galaxy 2 beta |kernel32.dll.SetEnvironment | |StringsW
-
WineHQ Bugzilla