[Bug 23510] New: Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

Summary: Google Talk error dialog when opening
           Product: Wine
           Version: 1.2-rc6
          Platform: x86
               URL: http://dl.google.com/googletalk/googletalk-setup.exe
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: minor
          Priority: P2
         Component: mshtml
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=29351)
 --> (http://bugs.winehq.org/attachment.cgi?id=29351)
Console output from opening google talk

When google talk is started after it is installed, a regression causes a dialog
box to be shown with the following message:
"Google Talk encountered an internal error, and must now close. Ok to report
this error to Google?"

Closing the dialog causes the application to exit.

I did a regression test and found the following commit caused the regression. 
Reverting the commit fixes the issue.

8c06ed96aeb737e5596e190efe785a2c2c97237e is the first bad commit
commit 8c06ed96aeb737e5596e190efe785a2c2c97237e
Author: Piotr Caban 
Date:   Mon Dec 7 14:54:33 2009 +0100

mshtml: Improved OleDocumentView_UIActivate implementation.

Google talk should at least open without an error, although bug 3254 prevents
it from keeping a stable connection after logging in, and bug 5162 prevents a
lot of text from being shown.

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

--- Comment #1 from Piotr Caban   2010-07-09 07:06:42 ---
This patch looks correct for me. It shows that builtin mshtml is not good
enough for this app yet.

If E_FAIL is returned early enough, google talk stops using mshtml. It's even
prepared to work (at least partially) without this dll (you can try setting
mshtml to disabled in winecfg).

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

--- Comment #2 from Dylan Smith   2010-07-09 07:51:04 ---
I can confirm that Google Talk seems to work around mshtml being disabled by
using:
WINEDLLOVERRIDES="mshtml=" wine googletalk.exe

That is a good workaround, and your patch may be correct, but unfortunately
there is still a bug. This this should probably be kept open, or marked as a
duplicate of another bug dependent on the same functionality.

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |8c06ed96aeb737e5596e190efe7
                   |                            |85a2c2c97237e

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Bruno Jesus  2011-08-29 18:29:53 CDT ---
Despite of several graphic issues I can open the application in a clean prefix
in 1.3.27. Can anyone else retest?

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from André H.  2011-10-05 12:46:56 CDT ---
(In reply to comment #3)
> Despite of several graphic issues I can open the application in a clean prefix
> in 1.3.27. Can anyone else retest?

sadly i can't in 1.3.29

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

--- Comment #5 from Bruno Jesus  2011-10-05 13:34:50 CDT ---
Still works for me, there is an infinite sequence of :

fixme:richedit:fnTextSrv_TxGetNaturalSize 0x1e2a88: STUB

But it works =)

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Austin English  2011-10-05 14:43:42 CDT ---
(In reply to comment #5)
> Still works for me, there is an infinite sequence of :
>
> fixme:richedit:fnTextSrv_TxGetNaturalSize 0x1e2a88: STUB
>
> But it works =)

Fixed.

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #7 from Austin English  2011-10-05 15:03:16 CDT ---
(In reply to comment #6)
> (In reply to comment #5)
> > Still works for me, there is an infinite sequence of :
> >
> > fixme:richedit:fnTextSrv_TxGetNaturalSize 0x1e2a88: STUB
> >
> > But it works =)
>
> Fixed.

Misinterpreted comment #4. Fails here as well in wine-1.3.29-198-gfc2dcd0.

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

--- Comment #8 from Austin English  2011-10-05 15:03:35 CDT ---
Created attachment 36731
  --> http://bugs.winehq.org/attachment.cgi?id=36731
terminal output

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW
                 CC|                            |[e-mail]

--- Comment #9 from Austin English  2011-10-05 15:03:46 CDT ---
Confirming.

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

--- Comment #10 from Bruno Jesus  2011-10-05 15:08:26 CDT ---
Do you guys get an error dialog? I don't, that's why I think it's "working" due
to the bug title.

Another bug should be opened regarding the screen corruption (one problem per
bug philosophy).

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

--- Comment #11 from Austin English  2011-10-05 15:37:21 CDT ---
(In reply to comment #10)
> Do you guys get an error dialog? I don't, that's why I think it's "working" due
> to the bug title.

Yes.
> Another bug should be opened regarding the screen corruption (one problem per
> bug philosophy).

Sure.

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

--- Comment #12 from André H.  2011-10-05 16:11:07 CDT ---
(In reply to comment #10)
> Do you guys get an error dialog? I don't, that's why I think it's "working" due
> to the bug title.

yes
> Another bug should be opened regarding the screen corruption (one problem per
> bug philosophy).

maybe that's already bug 5162 ?

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

--- Comment #13 from Bruno Jesus  2012-01-02 14:51:41 CST ---
Created attachment 38229
  --> http://bugs.winehq.org/attachment.cgi?id=38229
1.3.36 backtrace

Seems to be still present in 1.3.36. The attached backtrace shows the exact
point of the crash.

The crash happens in dlls/mshtml/htmlevent.c:985:
prev_event = doc->basedoc.window->event;

Because doc->basedoc.window = -1

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from joaopa  2013-04-20 14:25:55 CDT ---
still a bug in current wine?

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #15 from Bruno Jesus  2013-04-20 21:48:59 CDT ---
It seems fixed. No more crash or error dialog. The application does not work
correctly due to bug 5162. If anyone is still able to reproduce feel free to
reopen.

[Bug 23510] Google Talk error dialog when opening

http://bugs.winehq.org/show_bug.cgi?id=23510

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard  2013-04-26 13:14:41 CDT ---
Closing bugs fixed in 1.5.29.