[Bug 56177] New: The 64-bit uxtheme:system fails on Windows 10 2004+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56177

Bug ID: 56177
           Summary: The 64-bit uxtheme:system fails on Windows 10 2004+
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: uxtheme
          Assignee: [e-mail]
          Reporter: [e-mail]

The 64-bit uxtheme:system fails on Windows 10 2004+:

system.c:2735: Test failed: Expected value 0, got -1702550272

See http://winetest.dolphin/data/patterns.html#uxtheme:system

A bisect shows that this failure started with the commit below:

commit b5f4a6a4dbb6f4d7b9f182d0d551393558458712
Author: Louis Lenders 
Date:   Thu Oct 19 15:15:36 2023 +0200

uxtheme: Add ShouldAppsUseDarkMode.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55821

[Bug 56177] The 64-bit uxtheme:system fails on Windows 10 2004+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56177

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression, source,
                   |                            |testcase
    Regression SHA1|                            |b5f4a6a4dbb6f4d7b9f182d0d55
                   |                            |1393558458712

[Bug 56177] The 64-bit uxtheme:system fails on Windows 10 2004+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56177

--- Comment #1 from François Gouget  ---
Sorry, wrong URL
See https://test.winehq.org/data/patterns.html#uxtheme:system

[Bug 56177] The 64-bit uxtheme:system fails on Windows 10 2004+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56177

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 56177] The 64-bit uxtheme:system fails on Windows 10 2004+

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56177

--- Comment #2 from Louis Lenders  ---
Hi,

It seems that the undocumented dark-theme api's might possibly change from
windows version to windows version, as some sites mention (i mentioned a few of
those sites in the merge request thread). Also this site mentions even the
ordinal number might have changed:
 https://codereview.qt-project.org/c/qt/qtbase/+/357262

Quote: " Also there's two undocumented API from UxTheme.dll can help us get the
current theme: BOOL WINAPI ShouldAppsUseDarkMode() and BOOL WINAPI
ShouldSystemUseDarkMode(). They can only be resolved by ordinal name, the
former is 132, the latter is 138. Sadly ShouldAppsUseDarkMode() changed it's
ordinal number in some unknown version of Windows, so currently, only
ShouldSystemUseDarkMode() is usable."

->end quote

Long story short: in my opinion a reliable test is maybe not yet achievable, so
my suggestion would just be to comment out the failing test. Francois: what do
you think of that? Also: maybe Zhiyi could shed a light on this?