[Bug 26226] New: msxml3 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Summary: msxml3 emits too much xmlns attributes
           Product: Wine
           Version: 1.3.14
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When using www.wiso-kassenbuch.de initial registration checking fails

(free download:
http://update.buhl-finance.com/ESD/EUER%20und%20Kasse/WISO%20EUER%20und%20Ka...

trial code is: EUR2011TRY

)
reproduce:
Start the installer, enter EUR2011TRY in the field below "Ihr AKtions-Code) and
press "Weiter".
It will then report a "400" error in a messagebox.

The program sends a SOAP request to the on4u3.buhl.de server which is not
accepted by the server (likely not validating against a stylesheet).

I debugged this and using native MSXML3 it works, just our msxml3 will not.

I tooked a debug dump of the XML sent of both, will attach both versions.

[Bug 26226] msxml3 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Marcus Meissner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://update.buhl-finance.
                   |                            |com/ESD/EUER%20und%20Kasse/
                   |                            |WISO%20EUER%20und%20Kasse%2
                   |                            |02011%20Testversion.exe

[Bug 26226] msxml3 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #1 from Marcus Meissner  2011-02-24 01:54:25 CST ---
Created an attachment (id=33430)
 --> (http://bugs.winehq.org/attachment.cgi?id=33430)
native-msxml3.request.txt

request generated by native msxml3 (as debugprinted from wininet
httpsendrequest)

[Bug 26226] msxml3 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #2 from Marcus Meissner  2011-02-24 01:55:07 CST ---
Created an attachment (id=33431)
 --> (http://bugs.winehq.org/attachment.cgi?id=33431)
wine-msxml3.request.txt

request generated by Wine msxml3.

[Bug 26226] msxml3 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #3 from Marcus Meissner  2011-02-24 01:55:57 CST ---
if you compare both, native:

- no attributes within the Code tag: <Code>EUR2011TRY</Code>
- no attributes within SOAP-ENV:Body tag.

[Bug 26226] msxml3 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #4 from Marcus Meissner  2011-02-24 01:56:49 CST ---
also, following likely realted fixmes are printed:

fixme:msxml:domdoc_createNode nodes with namespaces currently not supported.
fixme:msxml:domelem_setAttributeNode (0x13dff8)->(0x13e164 0x33f6f8): semi-stub
(several of those two lines)

[Bug 26226] msxml3 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #5 from Marcus Meissner  2011-02-24 02:35:02 CST ---
Created an attachment (id=33432)
 --> (http://bugs.winehq.org/attachment.cgi?id=33432)
debug.patch

simple fprintf to print the xml request out

[Bug 26226] msxml3 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, Installer

[Bug 26226] msxml3 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #6 from Nikolay Sivov  2011-02-25 17:42:19 CST ---
I'm a bit confused with these logs. A first one native-msxml* has good and bad
parts, what's this about? Second one contains a formatted version of good?

Please attach a +tid,+msxml and two requests - one from native, one from
builtin.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Marcus Meissner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|msxml3 emits too much xmlns |msxml4 emits too much xmlns
                   |attributes                  |attributes

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #7 from Marcus Meissner  2011-02-27 04:06:31 CST ---
Created an attachment (id=33467)
 --> (http://bugs.winehq.org/attachment.cgi?id=33467)
builtin.log

WINEDEBUG=+msxml,+tid  with builtin msxml4

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #8 from Marcus Meissner  2011-02-27 04:07:16 CST ---
Created an attachment (id=33468)
 --> (http://bugs.winehq.org/attachment.cgi?id=33468)
native.log

with winetricks msxml4  installed, WINEDEBUG=+msxml,+tid

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #9 from Marcus Meissner  2011-02-27 04:08:11 CST ---
ah sorry, i had postedited the native one.

these are the two raw logfiles, unedited, as requested.

(I also confused msxml3 and msxml4, sorry. Later on the program has more
troubles with msxml3, but this is msxml4)

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #10 from Nikolay Sivov  2011-02-27 12:41:27 CST ---
At least one part of the problem looks as we (and libxml2) don't expect
something that application is doing, and this is weird by the way: it creates
unprefixed element with specified namespace uri, so we create default xmlns
definition for it, after that application manually adds attribute named "xmlns"
with the same namespace uri. Libxml2 clearly distinguishes namespace
definitions and attributes and doesn't cross check.

We need special case to workaround that, after some tests of course.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33430|0                           |1
        is obsolete|                            |

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33431|0                           |1
        is obsolete|                            |

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #11 from Nikolay Sivov  2011-02-27 14:40:26 CST ---
Created an attachment (id=33477)
 --> (http://bugs.winehq.org/attachment.cgi?id=33477)
patch

Try this one and update logs if it's still a problem.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #12 from Marcus Meissner  2011-02-27 15:17:04 CST ---
Created an attachment (id=33478)
 --> (http://bugs.winehq.org/attachment.cgi?id=33478)
newbuiltin.log

new trace with patch applied.

it has some xmlns attributes less

the remote server does not like it yet. :/

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #13 from Nikolay Sivov  2011-02-27 15:22:49 CST ---
It's better, I'll take care of the rest when first one gets in.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #14 from Nikolay Sivov  2011-02-28 11:30:31 CST ---
Default namespace attribute fix committed as
0c16c79c711129d077f05c8ca8af6387a21d7745.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33477|0                           |1
        is obsolete|                            |

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #15 from Nikolay Sivov  2011-02-28 16:43:46 CST ---
Created an attachment (id=33484)
 --> (http://bugs.winehq.org/attachment.cgi?id=33484)
patch

This one will fix duplicates I hope.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Marcus Meissner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33467|0                           |1
        is obsolete|                            |
  Attachment #33478|0                           |1
        is obsolete|                            |

--- Comment #16 from Marcus Meissner  2011-03-01 02:37:12 CST ---
Created an attachment (id=33489)
 --> (http://bugs.winehq.org/attachment.cgi?id=33489)
newbuiltin.log

new trace

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #17 from Marcus Meissner  2011-03-01 02:38:19 CST ---
I also get a MessageBox now with

OLE-Fehler 80020006

in it. (DISP_E_UNKNOWNNAME)

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #18 from Nikolay Sivov  2011-03-01 04:08:44 CST ---
Please change this:

---
-    if (!strcmpW(nameW, xmlnsW))
+    if (!strcmpW(nameW, xmlnsW) || strstrW(nameW, xmlnscW))
     {
         SysFreeString(nameW);
         return DISP_E_UNKNOWNNAME;
---

to return S_OK.

I don't have time now to test it, so attach a new log and server request.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Marcus Meissner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33489|0                           |1
        is obsolete|                            |

--- Comment #19 from Marcus Meissner  2011-03-01 10:49:42 CST ---
Created an attachment (id=33494)
 --> (http://bugs.winehq.org/attachment.cgi?id=33494)
newbuiltin.log

the file gets smaller ...

program says "400" again, aka server did not like us.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #20 from Nikolay Sivov  2011-03-01 10:52:42 CST ---
I see, so it's too much to reject everything. I need to reject only when
attribute tries to override already set element namespace, should be easy.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Marcus Meissner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.14                      |1.4-rc2

--- Comment #21 from Marcus Meissner  2012-02-09 15:31:06 CST ---
still open.

fixme:msxml:domdoc_createNode nodes with namespaces currently not supported.
fixme:msxml:domelem_setAttributeNode (0x150a80)->(0x150d2c 0x33f6d8): semi-stub
fixme:msxml:domdoc_createNode nodes with namespaces currently not supported.
fixme:msxml:domelem_setAttributeNode (0x150a80)->(0x150d3c 0x33f6d8): semi-stub
fixme:msxml:domdoc_createNode nodes with namespaces currently not supported.
fixme:msxml:domelem_setAttributeNode (0x150a80)->(0x150dd4 0x33f6d8): semi-stub
fixme:msxml:domdoc_createNode nodes with namespaces currently not supported.
fixme:msxml:domelem_setAttributeNode (0x150d90)->(0x150fec 0x33f6b0): semi-stub
fixme:msxml:domdoc_createNode nodes with namespaces currently not supported.
fixme:msxml:domelem_setAttributeNode (0x151008)->(0x1512ec 0x33f6cc): semi-stub

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Marcus Meissner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.4-rc2                     |1.3.14

--- Comment #22 from Marcus Meissner  2012-02-09 15:41:07 CST ---
(restore version to "first reported").

still there in 1.4-rc2

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #23 from Ulrik Dickow  2012-06-11 17:59:41 CDT ---
Created attachment 40498
  --> http://bugs.winehq.org/attachment.cgi?id=40498
Trace BridgeCentral 2.2.5 SOAP-request with wine-1.5.3-165-g10a7dc2

This is a trace of BridgeCentral 2.2.5 on 09-May-2012 with a wine somewhere
between 1.5.3 and 1.5.4, with just the official patch to use Gecko 1.6-beta
(unrelated to msxml).  The trace has been cut down to just the part where the
application uses msxml in order to make a SOAP-request to a server (login via
"DBf-kode").  The login fails to be built and is never sent on the network. 
After this I used 'winetricks msxml3' to install the native msxml3 (SP7).  That
made the SOAP-request work perfectly.

Short interpretation: wine msxml3 humps along with warnings and seems to almost
work until it reaches the point where it wants to use setAttributeNode to add
an attribute node with attribute "xmlns" and value
"http://www.wso2.org/php/xsd", but that fails.

I have looked further into the problem by creating two stand-alone test
programs to reproduce similar SOAP-requests in various ways
(tst-msxml_make_soap.c) or just small bits of interesting XML releated to this
(tst-msxml_xmlns_simple.c).  I add these, and diffs of their output, in the
following attachments.

Finally I found out how to improve the wine code to produce better, error-free
XML in this and several other cases, so that BridgeCentral now works without
winetricks.  I of course will attach my patch(es) too (split in two patches).

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #24 from Ulrik Dickow  2012-06-11 18:05:23 CDT ---
Created attachment 40499
  --> http://bugs.winehq.org/attachment.cgi?id=40499
tst-msxml_make_soap.c - tests many ways to make SOAP XML

In the comment in the beginning of the program you can see the SOAP request
generated when BridgeCentral 2.2.5 is run with 'winetricks msxml3' (native
msxml3), captured via tcpdump/wireshark and slightly reformatted for
readability and privacy.  Test results follow.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #25 from Ulrik Dickow  2012-06-11 18:13:59 CDT ---
Created attachment 40500
  --> http://bugs.winehq.org/attachment.cgi?id=40500
make_soap output as diff wine 1.5.5 built-in (BAD) vs. 1.5.3-xxx native (GOOD)

Cuts from terminal windows testing tst-msxml_make_soap.c with various
interesting flag values (determining e.g. whether to test setAttribute or
setAttributeNode) on these two platforms:

1) (left): Wine 1.5.5 pure, i.e. built-in msxml3, i.e. sometimes BAD XML.

2) (right): Wine 1.5.3-165-g10a7dc2 with native msxml3 (winetricks, SP7),
   i.e. mostly GOOD XML.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #26 from Ulrik Dickow  2012-06-11 18:22:02 CDT ---
Created attachment 40501
  --> http://bugs.winehq.org/attachment.cgi?id=40501
Small text file summary of make_soap results native vs. built-in vs. fixed

This small text file summarizes, with one line per flag value, the cases tested
and what the results are one the 2 aforementioned platforms (native vs. plain
wine 1.5.5), but now also wine 1.5.6 with my upcoming patches.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #27 from Ulrik Dickow  2012-06-11 18:25:25 CDT ---
Created attachment 40502
  --> http://bugs.winehq.org/attachment.cgi?id=40502
make_soap output as diff wine 1.5.5 built-in (BAD) vs. 1.5.6-fix-beta4 (BETTER)

The left side of the diff is plain wine 1.5.5 as before.
The right side is now wine 1.5.6 straight (as of only a couple of hours ago),
with my patches applied.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #28 from Ulrik Dickow  2012-06-11 18:28:17 CDT ---
Created attachment 40503
  --> http://bugs.winehq.org/attachment.cgi?id=40503
tst-msxml_xmlns_simple.c - simpler stand-alone test for playing with XML

This program has no option, just a few very simple tests.  Especially test 3 is
interesting.  Test output follows in the next attachments.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #29 from Ulrik Dickow  2012-06-11 18:35:54 CDT ---
Created attachment 40504
  --> http://bugs.winehq.org/attachment.cgi?id=40504
xmlns_simple output as diff wine 1.5.5 built-in (BAD) vs. 1.5.3-xxx native
(GOOD)

Yet another 'diff -u99', here as indicated for the simpler test program. 
Especially the test 03 behaviour is interesting.  I use most of that,
conceptually, in the upcoming patch for wine (the tests in
msxml3/tests/domdoc.c).  Test 04 output turned out to be rather boring.  I had
expected the native msxml3 to enforce the W3C requirements for the namespace
for the reserved "xmlns" attribute, but it doesn't, according to this test
(thus my patch won't test for it, only emit a tiny warning, only visible when
user debugs).

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #30 from Ulrik Dickow  2012-06-11 18:40:10 CDT ---
Created attachment 40505
  --> http://bugs.winehq.org/attachment.cgi?id=40505
xmlns_simple output as diff wine 1.5.5 built-in (BAD) vs. 1.5.6-fix-beta4
(BETTER)

Here's the simple test output again for plain wine 1.5.5 at the left, but now
wine 1.5.6 with my fix at the right.  This is the last attachment before the
promised patches to wine.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #31 from Ulrik Dickow  2012-06-11 18:45:45 CDT ---
Created attachment 40507
  --> http://bugs.winehq.org/attachment.cgi?id=40507
msxml3/tests: Reduce code duplication for the namespace change

This first patch changes no functionality.  It's just a cleanup of the testing
code.  I know that collapsing the duplicated code into a single function will
make the line numbers in the test output slightly less informative; but it
makes the code easier to grasp, and especially easier to enhance.  I didn't
want to have to double all my testing code (first for default document version,
then for version 60, as it is here).

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #32 from Ulrik Dickow  2012-06-11 19:04:56 CDT ---
Created attachment 40511
  --> http://bugs.winehq.org/attachment.cgi?id=40511
msxml3: Support xmlns[:*] attribute nodes intelligently.

This patch, number 2 of 2, is where the new code comes in.  The 2 patches here
are based on the latest Wine git master as of this moment (updated 4 hours ago
according to gitweb).  The "1.5.6-fix-beta4" mentioned in the earlier
attachments is the pure 1.5.6 with the same patches applied, tested earlier on
June 11, before anything newer than 1.5.6 was visible on gitweb (Sourceforge). 
Fortunately the official updates after 1.5.6 didn't touch the same files as my
patches, so the tests should still be valid.

About 4 hours ago I tested on the Wine testbot that 'msxml3_crosstest.exe
domdoc' didn't produce any errors with this latest version of my 2 patches
combined, appplied to pure 1.5.6.  (The testbot was helpful in revealing bugs
in my beta2 version earlier in the day).

The patch doesn't produce "optimal" XML, i.e. with a redundant xmlns suppressed
in children as seen from a parent, but it now produces fully valid XML, with
successful return code (S_OK), in many more cases than before.  It makes the
BridgeCentral SOAP login work (i.e. that server doesn't care about extra
whitespace and repeated xmlns:SOAP-ENV and xmlns in children, as long as they
aren't any more doubled in the same element/level).

I hope the patch will also make the financial app that originally triggered
this bug report work.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #33 from Marcus Meissner  2012-06-12 02:14:24 CDT ---
Ulrik, these two patches look good to me ... can you mail them to
[e-mail]  for review and inclusion?

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Ulrik Dickow  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #34 from Ulrik Dickow  2012-06-12 04:07:10 CDT ---
(In reply to comment #33)
> Ulrik, these two patches look good to me ... can you mail them to
> [e-mail]  for review and inclusion?

Ok, done.  I already got the automatic replies from the testbot with no errors
for the two mailed patches.  Nice system.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Ulrik Dickow  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40507|0                           |1
        is obsolete|                            |
  Attachment #40511|0                           |1
        is obsolete|                            |

--- Comment #35 from Ulrik Dickow  2012-07-08 05:59:51 CDT ---
Created attachment 40928
  --> http://bugs.winehq.org/attachment.cgi?id=40928
Trace BridgeCentral 2.2.5 vs. Buhl2012 diff wine-1.5.8-git1 (debug02b)

My patches (try 1 as well as try 2) fix the bug for BridgeCentral, but
unfortunately not for the Buhl app (neither 2011 nor 2012 version).

This attachment is a 'diff -u999' between slightly edited versions of
msxml-traces of the first SOAP request of BridgeCentral 2.2.5 (left) versus the
2012 version of the Buhl app
(http://www.buhl.de/produkte/alle/wiso-euer-und-kasse-2012/product.html#Testv...)
(right), running on a wine 1.5.8 patched with Marcus' one-line "fprinf full
request"-patch (attachment 33432) and try 2 of my "msxml3: Support
xmlns..."-patch
(http://www.winehq.org/pipermail/wine-devel/2012-June/096069.html , obsoletes
attachment 40511).  (Attachment 40507 was obsoleted by the improved version
included in Wine 1.5.7 via commit fc8ab63563663f5076d86fa814289d2e046e5125).

The "slight editing" was to wipe out: 1) all 6+ digit hex numbers (piped
through 'perl -pe "s/0x[0-9a-f]{6,}/0x.../g"' and 2) the login numbers/codes
for my bridge club.

We see that both apps use Borland SOAP 1.2 to generate exactly the same msxml
calls to create the SOAP-ENV:Envelope and SOAP-ENV:Body elements, including
xmlns attributes.  At the third level the only difference is the app specific
names and xmlns URIs of the elements (KlubLogin vs. CheckActionCode etc.).  But
at the fourth, innermost level, the Buhl app does some extra attribute node
list walking and strangely ends up using the URI of the xmlns:xsd attribute
instead of re-using the URI of the third level element
(https://on4u3.buhl.de/buhl/WebActionCode/).  This results in bad XML for the
Buhl app (wrong URI in innermost element), while BridgeCentral makes fully
valid XML (correct URIs, although child redundancies not optimized away).

The problem probably is that we don't create attribute nodes for the
"redundant" xmlns attributes.  A full fix would be to create all the attribute
nodes that the app asks for, but then use a much more intelligent set of
functions for creating final XML (*_get_xml).  At the same time that would
solve the minor problem of redundant xmlns attributes printed in children. 
However, this strategy is not as easy as the "skip attribute creation hack"
with the current libxml2.

Until a full fix is developed for either libxml2 or wine, my patch is useful as
a temporary solution to solve the problem for some, but not all applications.

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Kyle Auble  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Kyle Auble  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]     |

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |33347

[Bug 26226] msxml4 emits too much xmlns attributes

http://bugs.winehq.org/show_bug.cgi?id=26226

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]-kl.
                   |                            |de

--- Comment #36 from Anastasius Focht  ---
*** Bug 35577 has been marked as a duplicate of this bug. ***

[Bug 26226] msxml4 emits too much xmlns attributes

https://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #37 from Ulrik Dickow  ---
Created attachment 55394
  --> https://bugs.winehq.org/attachment.cgi?id=55394
My June 2012 fix ported to current wine (1.8 & 1.9.16+)

This is just my good old "try 2" patch from June 2012 forward-ported to current
wine.  I verified on December 15 2015 that wine-1.8-rc3-47-gd29dcec still
needed the patch to make the BridgeCentral app work correctly -- and that the
patch still wasn't sufficient to make neither the 2012 nor the 2011 Buhl WISO
programs accept the trial codes (hopefully not just because the codes
expired?).  The attached patch is based against wine git from August 13 2016
(wine-1.9.16-161-gd6d0d96).  It works fine with current BridgeCentral.

[Bug 26226] msxml4 emits too much xmlns attributes

https://bugs.winehq.org/show_bug.cgi?id=26226

JB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]-kl. |
                   |de                          |

[Bug 26226] msxml4 emits too much xmlns attributes

https://bugs.winehq.org/show_bug.cgi?id=26226

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #38 from [e-mail] ---
Please retest with current wine, the trial codes of another buhl program are
now accepted.

[Bug 26226] msxml4 emits too much xmlns attributes

https://bugs.winehq.org/show_bug.cgi?id=26226

--- Comment #39 from Ulrik Dickow  ---
Created attachment 60782
  --> https://bugs.winehq.org/attachment.cgi?id=60782
debug.patch from Marcus improved to only trigger if WINEDEBUG includes
"fullreq"

To rebe: Ok, I retested the Buhl 2012 app with current wine this Thursday
2018-03-15 (wine-3.3-235-g1c8c9308e7).  It still failed seriously with "Ole
fehler 0x..." and didn't send anything to the network according to Wireshark.

Yesterday I applied my 2016-08-18 patch to wine-3.4 (still applies cleanly with
'git am') and also the attached improved debug.patch.  Then the Buhl 2012 app
gets much closer to working, exactly as close as in July 2012 and Aug 2016: No
more OLE error, instead generation of a full SOAP request sent over the wire
via TLS, and of course the response that the trial code is invalid.  Even with
a non-expired trial code it probably wouldn't work, though, because the
namespace of the innermost element is still strangely wrong as described in
Comment 35.  All other namespace definitions are correct in the generated XML
request.  I still succesfully use my patch with current BridgeCentral (2.4.5),
no namespace problems there, apart from the now somewhat misleading
"setAttributeNode namespaces not supported" fixme messages.  With the patch,
namespaces are _partially_ supported, but I haven't bothered to adjust the
fixme text.

So your other tested Buhl program must have worked either because it didn't use
XML at all, or it generated the XML in a sufficiently different way to avoid
the unsupported features in current wine.

[Bug 26226] msxml4 emits too much xmlns attributes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=26226

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #40 from joaopa  ---
Download link is burst.
Does the bug still occur with wine-5.11?