[Bug 36704] New: wine cmd uses overwrite mode instead of insert mode

http://bugs.winehq.org/show_bug.cgi?id=36704

Bug ID: 36704
           Summary: wine cmd uses overwrite mode instead of insert mode
           Product: Wine
           Version: 1.7.19
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: cmd
          Assignee: [e-mail]
          Reporter: [e-mail]

When you start 'wine cmd' from gnome-terminal, it launches the wine command
interpreter embedded in gnome-terminal. When you use the arrow keys to modify a
command that you just typed, it is set to overwrite (replace characters)
instead of inserting inbetween. However, gnome-terminal uses insert mode and
that is what the user was using just moments before.

I believe Windows 7 also uses insert mode
(http://technet.microsoft.com/en-us/magazine/ff758104.aspx) and if there is not
a good reason against it, it would make sense to have it as default in wine, or
better to inherit such a setting from the shell/desktop environment.

For an example, see related topic in the forum:
http://forum.winehq.org/viewtopic.php?f=8&t=22727

[Bug 36704] wine cmd uses overwrite mode instead of insert mode

http://bugs.winehq.org/show_bug.cgi?id=36704

Hugh McMaster  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Hugh McMaster  ---
Created attachment 48777
  --> http://bugs.winehq.org/attachment.cgi?id=48777
Draft implementation of insert mode by Hugh McMaster

I've been looking into this issue for a while now and, like you, have been
somewhat frustrated by the lack of support for console insert mode.

The attached patch should do what you want. You will need to patch the source
tree using the -p1 flag.

[Bug 36704] wine cmd uses overwrite mode instead of insert mode

https://bugs.winehq.org/show_bug.cgi?id=36704

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from [e-mail] ---
Is there a chance this patch could be accepted? It would be good to have that
needed feature, rather than having it laying around but unused.

[Bug 36704] wine cmd uses overwrite mode instead of insert mode

https://bugs.winehq.org/show_bug.cgi?id=36704

--- Comment #3 from Hugh McMaster  ---
That patch needs to be revised before it can be submitted. I'll try to take a
look at it this week.

Of course, whether a patch is accepted largely depends on the maintainer.

[Bug 36704] wine cmd uses overwrite mode instead of insert mode

https://bugs.winehq.org/show_bug.cgi?id=36704

--- Comment #4 from Hugh McMaster  ---
This bug has become a problem. I personally prefer the benefits of console
InsertMode and I know other users do too.

Qian Hong, for one, has expressed the same sentiment in an email discussion of
console issues.

I have also spoken (i.e. emailed) with Jason Edmeades, a developer with
considerable knowledge of Wine's cmd implementation, and he said he had no
problem with enabling InsertMode.

---

I am currently writing conformance tests for InsertMode. Related patches are in
'pending' status.

[Bug 36704] wine cmd uses overwrite mode instead of insert mode

https://bugs.winehq.org/show_bug.cgi?id=36704

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 36704] wine cmd uses overwrite mode instead of insert mode

https://bugs.winehq.org/show_bug.cgi?id=36704

--- Comment #5 from Hugh McMaster  ---
Fixed in 1.7.43 by commit 27753f2ea606d75193efa1ddc1dd6261ef2342d7.

[Bug 36704] wine cmd uses overwrite mode instead of insert mode

https://bugs.winehq.org/show_bug.cgi?id=36704

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |27753f2ea606d75193efa1ddc1d
                   |                            |d6261ef2342d7
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Nikolay Sivov  ---
Fixed with 27753f2ea606d75193efa1ddc1dd6261ef2342d7.

[Bug 36704] wine cmd uses overwrite mode instead of insert mode

https://bugs.winehq.org/show_bug.cgi?id=36704

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.45.