[Bug 23723] New: Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

Summary: Multiple games from Sonalysts cannot play sound files
                    (stored in Sfx.agg)
           Product: Wine
           Version: 1.2
          Platform: x86
               URL: http://www.gamershell.com/download_8369.shtml
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=29727)
 --> (http://bugs.winehq.org/attachment.cgi?id=29727)
rzipped +file traces

This bug affects every game from the developer Sonalysts:
Jane's 688(I) Hunter-Killer
Fleet Command
Sub Command
Dangerous Waters

Symptom: all these games are missing sound effects and voices (only music
works). The games store their sound files (.wav) in a Sfx.agg archive. Running
the games in Wine with winedebug=+file reveals that Wine cannot find the
appropriate sound files. A typical line from the log:

warn:file:OpenFile (C:\Program Files\Sonalysts Combat Simulations\Dangerous
Waters Demo\Audio\Sfx\sfx.agg+pinged.wav): return = HFILE_ERROR error= 2

Notice the path to the relevant sound file: '\sfx.agg+pinged.wav'.

Apparently in a native Windows environment it doesn't cause problems, but does
in Wine.

A 'dirty' workaround is to extract the .wavs using an utility called agg.exe,
and placing them into a directory named: sfx.agg+.

You can test the issue using the demo of Dangerous Waters, link added to URL.

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

Pawel Stolowski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Pawel Stolowski  2010-10-17 03:24:52 CDT ---
The workaround with placing the wavs in sfx.agg+ subdirectory didn't work for
me in Dangerous Waters. For Dangerous Waters the trick is to rename all the
wavs so that each name has "sfx.agg+" prefix. This can be done en masse with:
$ for p in *.WAV *.wav ; do mv "$p" "sfx.agg+$p"; done
(it has to be executed in each directory that has sfx.agg file).

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |t

--- Comment #2 from Jörg Höhle  2010-10-23 01:15:33 CDT ---
This is likely a bug in Wine's MMIO component, see mmioOpen and mmioInstallProc
http://msdn.microsoft.com/en-us/library/ms712181(VS.85).aspx
"When an application calls mmioOpen with a file name such as "two.xyz+part",
the I/O procedure associated with the four-character code "XYZ" is called to
open the "part" element of the file "two.xyz"

A +file trace is probably useless, a +mmio trace might help somebody
knowledgeable with mmio.

This bug also affects "Harry Hops auf dem Bauernhof", which crashes after
an error about "not in baggage file" according to my notes from wine-0.9.x
times.
trace:file:OpenFile D:\DATA\BAUER.M14+ANFANG.DIB OF_READ OF_SHARE_COMPAT
trace:file:OpenFile D:\DATA\BAUER.M14+ANFANG.DIB 0000
Wine didn't look into the file cdrom\data\bauer.m14.

This equally affects "Harry Hops auf Schatzsuche" which IMHO is one of the most
enjoyable children games ever published.  Both Harry Hops games would get
garbage rating in Wine, alas.

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

--- Comment #3 from GyB  2010-10-23 01:29:51 CDT ---
Created an attachment (id=31453)
 --> (http://bugs.winehq.org/attachment.cgi?id=31453)
+mmio traces

I attached a log containing +mmio traces while running the game Jane's 688(I)
Hunter-Killer in wine-1.3.5-209-g8c5718e.

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

--- Comment #4 from Alexander Puzankov  2010-10-28 12:44:27 CDT ---
Created an attachment (id=31570)
 --> (http://bugs.winehq.org/attachment.cgi?id=31570)
MMIO_ParseExtA fix

There is a bug in MMIO_ParseExtA logic. It assumes that the file extension is
after the last dot in the filename, but it should be before '+'. This should
probably fix it.

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

--- Comment #5 from GyB  2010-10-28 13:07:46 CDT ---
(In reply to comment #4)
> Created an attachment (id=31570)

--> (http://bugs.winehq.org/attachment.cgi?id=31570) [details]
> MMIO_ParseExtA fix
>
> There is a bug in MMIO_ParseExtA logic. It assumes that the file extension is
> after the last dot in the filename, but it should be before '+'. This should
> probably fix it.

I applied your patch on wine-1.3.5-388-gf216dba and it works great: the sound
effects/speeches that were missing so far, are now audible. Tested with Jane's
688(I) Hunter-Killer.

Thank you!

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

--- Comment #6 from GyB  2010-11-20 09:49:31 CST ---
Alexander,

Would you submit your patch so it should be merged into Wine?
According to my testing the patch fixes the missing audio problem in 3 out of 4
games (Fleet Command doesn't start for me for some reasons).

Regards,
Béla Gyebrószki

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

Alexander Puzankov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Alexander Puzankov  2010-11-27 16:54:56 CST ---
After some investigation, I discovered that the bug appeared after commit
ed593fdf2f5e7851cb59aa5a2253f43e33d2f14f. I guess this should probably be
reported to wine-devel.

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #8 from Jeff Zaroyko  2010-11-27 17:29:09 CST ---
(In reply to comment #7)
> After some investigation, I discovered that the bug appeared after commit
> ed593fdf2f5e7851cb59aa5a2253f43e33d2f14f. I guess this should probably be
> reported to wine-devel.

Adding the regression keyword here is fine, no need to mail wine-devel.  If you
can come up with a testcase to be integrated along with the fix that's all
that's left to do.

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from GyB  2010-12-01 13:32:28 CST ---
Fixed in wine-1.3.8-113-g9d9ce29.

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

--- Comment #10 from Jörg Höhle  2010-12-04 11:50:28 CST ---
Created an attachment (id=32354)
 --> (http://bugs.winehq.org/attachment.cgi?id=32354)
patch to prevent moving extStart before the buffer

Alexander,
unless I'm mistaken your patch will cause extStart to move outside of the
buffer contents when given a file name like "+".
Here's a patch to play it safe.

One cannot assume all names are of the form "foo.abc". For instance, MCICDA
used to cause complains about
err:mmio:MMIO_ParseExtA No . in szFileName: "D:\"
It's good you removed that incorrect error message.

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

--- Comment #11 from Alexander Puzankov  2010-12-05 08:33:46 CST ---
(In reply to comment #10)
> Created an attachment (id=32354)

--> (http://bugs.winehq.org/attachment.cgi?id=32354) [details]
> patch to prevent moving extStart before the buffer
>
> Alexander,
> unless I'm mistaken your patch will cause extStart to move outside of the
> buffer contents when given a file name like "+".
> Here's a patch to play it safe.
>
> One cannot assume all names are of the form "foo.abc". For instance, MCICDA
> used to cause complains about
> err:mmio:MMIO_ParseExtA No . in szFileName: "D:\"
> It's good you removed that incorrect error message.

Stupid mistake on my part... Thanks for pointing it out to me. Your patch is
not correct though, but thanks anyway! I've sent fix to wine-patches.

[Bug 23723] Multiple games from Sonalysts cannot play sound files (stored in Sfx.agg)

http://bugs.winehq.org/show_bug.cgi?id=23723

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2010-12-10 13:46:21 CST ---
Closing bugs fixed in 1.3.9.