[Bug 16833] New: Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

Summary: Build fails in Cygwin at
                    dlls/inetcomm/internettransport.c
           Product: Wine
           Version: 1.1.12
          Platform: PC
        OS/Version: other
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

./configure --without-freetype (Cygwin freetype isn't detected)
make depend
make

bombs out in the "make" with:

internettransport.c: In function `InternetTransport_WndProc':
internettransport.c:348: error:
`Include_winsock_h_before_stdlib_h_or_use_the_MSVCRT_library' undeclared (first
use in this function)
internettransport.c:348: error: (Each undeclared identifier is reported only
once
internettransport.c:348: error: for each function it appears in.)
internettransport.c:348: error: parse error before "infd"
internettransport.c:379: warning: implicit declaration of function
`Include_winock_h_before_stdlib_h_or_use_the_MSVCRT_library'
internettransport.c:379: error: `infd' undeclared (first use in this function)
make[2]: *** [internettransport.o] Error 1
make[2]: Leaving directory `/cygdrive/d/wine-1.1.12/dlls/inetcomm'
make[1]: *** [inetcomm] Error 2
make[1]: Leaving directory `/cygdrive/d/wine-1.1.12/dlls'
make: *** [dlls] Error 2

Applying attachment 18288 from bug 16660 (a failure in the same file on
OpenBSD) gives:

gcc -c -I. -I. -I../../include -I../../include  -D__WINESRC__  -D_REENTRANT
-Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings
-Wpointer-arith  -g -O2  -o internettransport.o internettransport.c
In file included from internettransport.c:31:
../../include/ws2tcpip.h:238: error: parse error before "socklen_t"
../../include/ws2tcpip.h:240: error: parse error before "socklen_t"
make[2]: *** [internettransport.o] Error 1
make[2]: Leaving directory `/home/fun/wine-1.1.11/dlls/inetcomm'
make[1]: *** [inetcomm] Error 2
make[1]: Leaving directory `/home/fun/wine-1.1.11/dlls'
make: *** [dlls] Error 2

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |download, source

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |minor

--- Comment #1 from Vitaliy Margolen   2009-01-07 23:49:56 ---
Not a blocker. Minor at best. Cigwin is not one of the "supported" platforms
and not interesting for regular use.

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

--- Comment #2 from Dmitry Timoshkov   2009-01-08 01:20:17 ---
Moreover, Wine won't run under Cygwin (due to a lot of technical reasons),
so compiling Wine under Cygwin is a purely academic task.

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

--- Comment #3 from David Gerard   2009-01-08 02:36:34 ---
Hmm, I filed it as "blocker" because it's a blocker on this platform. Not one
for all of Wine.

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

--- Comment #4 from Austin English   2009-01-08 09:52:29 ---
(In reply to comment #3)
> Hmm, I filed it as "blocker" because it's a blocker on this platform. Not one
> for all of Wine.

Technically a blocker, yes, but considering it's cygwin and not an OS we either
support currently or ever came close to supporting, it's not really a blocker.
Enhancement really.

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

--- Comment #5 from Austin English   2009-01-18 03:59:27 ---
Could you upload your config.log?

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

--- Comment #6 from David Gerard   2009-01-18 10:18:54 ---
Created an attachment (id=18797)
 --> (http://bugs.winehq.org/attachment.cgi?id=18797)
gzipped copy of config.log

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

--- Comment #7 from David Gerard   2009-01-18 10:52:39 ---
That's the config.log from ./configure on the wine-1.1.13 source tarball.

make bombs out in the same file, but slightly differently!

gcc -c -I. -I. -I../../include -I../../include  -D__WINESRC__  -D_REENTRANT
-Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings
-Wpointer-arith  -g -O2  -o internettransport.o internettransport.c
In file included from ../../include/winsock2.h:47,
                 from internettransport.c:30:
../../include/winsock.h:58:1: warning: "fd_set" redefined
In file included from /usr/include/stdio.h:46,
                 from internettransport.c:24:
/usr/include/sys/types.h:237:1: warning: this is the location of the previous
definition
internettransport.c: In function `InternetTransport_WndProc':
internettransport.c:348: error:
`Include_winsock_h_before_stdlib_h_or_use_the_MSVCRT_library' undeclared (first
use in this function)
internettransport.c:348: error: (Each undeclared identifier is reported only
once
internettransport.c:348: error: for each function it appears in.)
internettransport.c:348: error: parse error before "infd"
internettransport.c:379: warning: implicit declaration of function
`Include_winsock_h_before_stdlib_h_or_use_the_MSVCRT_library'
internettransport.c:379: error: `infd' undeclared (first use in this function)
make[2]: *** [internettransport.o] Error 1
make[2]: Leaving directory `/cygdrive/c/wine-1.1.13/dlls/inetcomm'
make[1]: *** [inetcomm] Error 2
make[1]: Leaving directory `/cygdrive/c/wine-1.1.13/dlls'
make: *** [dlls] Error 2

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

--- Comment #8 from Austin English   2009-01-18 16:25:15 ---
Looks like Cygwin is missing several header files:
configure:7941: checking for net/if_arp.h
configure:7974: gcc -c -g -O2  conftest.c >&5
conftest.c:84:24: net/if_arp.h: No such file or directory

(along with some of the other net/*,netinet* heaers).

Might compare your results on cygwin to linux to see what you're
missing/needing.

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

--- Comment #9 from David Gerard   2009-01-21 03:59:18 ---
Nope, that wasn't it. Cygwin appears to have pulled its /usr/include/net and
/usr/include/netinet files from FreeBSD 3, so I copied net/if_arp.h,
net/route.h, netinet/if_ether.h, net/ethernet.h and net/radix.h from there. The
tests pass, but internettransport.c still bombs out the same.

The problem appears to be that FD_CLR is defined by Cygwin in its winsock.h and
winsock2.h. I changed Wine's winsock2.h to pull "winsock.h" (its own) rather
than <winsock.h> (which could be its own or Cygwin's), but that didn't help
either. Continuing investigation ...

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

David Gerard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from David Gerard   2009-03-19 09:44:29 ---
This particular error appears fixed in wine-1.1.17 - it bombs out later with a
different error :-D Marking "fixed."

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

David Gerard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #11 from David Gerard   2009-03-27 10:43:38 ---
Wrong about close - this bug is still present. It's being masked in 1.1.17 by
the win16 compilation error happening *earlier*, not later - as evidenced by
configure --without-win16. Ah well. Reopening.

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

David Gerard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from David Gerard   2009-04-03 04:55:34 ---
This appears fixed in current git.

[Bug 16833] Build fails in Cygwin at dlls/inetcomm/internettransport.c

http://bugs.winehq.org/show_bug.cgi?id=16833

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard   2009-04-10 11:21:17 ---
Closing bugs fixed in 1.1.19.