[Bug 37849] New: Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

Bug ID: 37849
           Summary: Wine causing color temperature setting(redshift) not
                    working for a short time
           Product: Wine
           Version: 1.7.32
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

[Bug]
While using redshift(a display color temperature) and entered the sunset time,
if then use wine to start a GUI program, the current display color temperature
will be reset for several seconds and return back.

[Reproducer]
1. Start redshift and ensure it entered sunset color.
Better use -l LAT:LON to fake that you are in somewhere sun is already set.
Default redshift will use randr backend to reset the color temp, so no extra
setting is needed to reproduce.
And default redshift will use 5500K for daytime and 3500K for nighttime,
so the color temp change will be quite obvious.

2. Start wine GUI program
I'm using Startcraft2 an galgame called "月に寄り添う乙女の作法2", both of them
cause the display color temperature reset for several seconds.

[Version]
wine: 1.7.33
redshift: 1.9.1

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

--- Comment #1 from [e-mail] ---
Forgot to mention, not only in GUI program staring but also when it is being
closed.

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

--- Comment #2 from Henri Verbeet  ---
Are you using a NVIDIA card by any chance? I've seen this happen as well, but
only ever on NVIDIA hardware. In those cases my impression was that it happens
because GetDeviceGammaRamp() (implemented with XF86VidModeGetGammaRamp() in
winex11.drv) returns incorrect information, which we then later use to restore
gamma in wined3d swapchain_cleanup(). It seems to work fine on radeon / r600g
at least.

For what it's worth, I can make something similar happen just by running
nvidia-settings.

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

--- Comment #3 from [e-mail] ---
Oh, you are completely right, I'm using nvidia card with its proprietary
driver.

And it also happens with nvidia-setting...

So not a bug in wine but in nvidia cards or the proprietary driver?

Anyway, great thanks?

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

--- Comment #4 from Henri Verbeet  ---
(In reply to anonymous_temp_mail from comment #3)
> So not a bug in wine but in nvidia cards or the proprietary driver?

Likely in the driver, although I haven't done quite enough investigation to say
for sure.

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #5 from [e-mail] ---
Thanks, since it's not a bug in wine, I'll close it.

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WONTFIX                     |UPSTREAM

--- Comment #6 from Bruno Jesus  ---
(In reply to anonymous_temp_mail from comment #5)
> Thanks, since it's not a bug in wine, I'll close it.

Upstream since it's more likely a driver bug.

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

YAOMTC  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from YAOMTC  ---
You have this happen with Starcraft? I have an AMD graphics card and I've had
this happen with World of Warcraft and the Battle.net client. (It doesn't
happen in Catalyst.) So it's not an Nvidia thing, I think it's an issue with
Blizzard's games occasionally overriding redshift. I notice when I launch the
Battle.net client sometimes the color will change, and then change back. Also,
when I go into settings in WoW, sometimes the color will change, then change
back - and any change I make to the gamma checkbox in WoW gets reverted after a
very short time.

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

--- Comment #8 from [e-mail] ---
(In reply to YAOMTC from comment #7)
> You have this happen with Starcraft? I have an AMD graphics card and I've
> had this happen with World of Warcraft and the Battle.net client. (It
> doesn't happen in Catalyst.) So it's not an Nvidia thing, I think it's an
> issue with Blizzard's games occasionally overriding redshift. I notice when
> I launch the Battle.net client sometimes the color will change, and then
> change back. Also, when I go into settings in WoW, sometimes the color will
> change, then change back - and any change I make to the gamma checkbox in
> WoW gets reverted after a very short time.

As mentioned by Henri, it's the problem of the graphgic card drivers.
And it's not restricted to blizzard's games, I mentioned 2 games, the other one
is unrelated to blizzard.

If ATI opensource driver also has the problem, it should be reported to its
upstream.

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

--- Comment #9 from Henri Verbeet  ---
(In reply to YAOMTC from comment #7)
> change back. Also, when I go into settings in WoW, sometimes the color will
> change, then change back - and any change I make to the gamma checkbox in
> WoW gets reverted after a very short time.

That part at least is expected, redshift updates the color temperature of the
screen every 5 seconds or so, and any custom gamma setting by an application
will get overidden at that point. Because of that, it's also not unexpected for
an application that explicitly sets the screen gamma to briefly change the
colors and then change back when redshift updates again. In the case of
StarCraft 2 though, the application never does that and the issue (likely)
happens because of wined3d trying to restore the incorrect gamma ramp it read
earlier.

For what it's worth, I think you should be able to prevent Wine from touching
screen gamma at all by setting "UseXVidMode" = "N" (see also
http://wiki.winehq.org/UsefulRegistryKeys), although I haven't tested this.

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|UPSTREAM                    |---

--- Comment #10 from [e-mail] ---
> That part at least is expected, redshift updates the color temperature of
> the screen every 5 seconds or so, and any custom gamma setting by an
> application will get overidden at that point. Because of that, it's also not
> unexpected for an application that explicitly sets the screen gamma to
> briefly change the colors and then change back when redshift updates again.
> In the case of StarCraft 2 though, the application never does that and the
> issue (likely) happens because of wined3d trying to restore the incorrect
> gamma ramp it read earlier.

Makes sense, so the root cause is the driver, on the other hand, wine should
not touch any gamma settings, so wine is still invovled.
> For what it's worth, I think you should be able to prevent Wine from
> touching screen gamma at all by setting "UseXVidMode" = "N" (see also
> http://wiki.winehq.org/UsefulRegistryKeys), although I haven't tested this.

I tried this, and it works perfectly, no gamma change again.

So I reopened the case. Wait, I can only change the status to unconfirmed or
closed?

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

https://bugs.winehq.org/show_bug.cgi?id=37849

Ben Parsons  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Ben Parsons  ---
Possible duplicate of >>33759

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=37849

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from joaopa  ---
Does tbe bug still occur with wine-5.11?

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=37849

Maciej Stanczew  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Maciej Stanczew  ---
Yes, it does. I'm using KDE Plasma's Night Color instead of Redshift, but the
principle is the same: after launching a game, gamma gets reset. The
"UseXVidMode" trick still works -- there is no gamma change with the registry
entry.

[Bug 37849] Wine causing color temperature setting(redshift) not working for a short time

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=37849

--- Comment #14 from Maciej Stanczew  ---
Some time ago this got fixed for me. I created a fresh prefix and did *not*
apply the UseXVidMode workaround, and I don't see color temperature changes
when using Wine.