[Bug 56345] New: EA app installer has no text

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56345

Bug ID: 56345
           Summary: EA app installer has no text
           Product: Wine
           Version: 9.2
          Hardware: x86-64
               URL: https://www.ea.com/ea-app
                OS: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: gdiplus
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 1454ffe7ddf01226aacec07836d4afa62fecd3fa
      Distribution: ---

Created attachment 76072
  --> https://bugs.winehq.org/attachment.cgi?id=76072
comparison

Just like the title.

[Bug 56345] EA app installer has no text

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56345

--- Comment #1 from Rafał Mużyło  ---
...a guess: before that commit, following bit was in effect for GdipDrawString:

if(graphics->hdc)
    {
        hdc = graphics->hdc;
    }
    else
    {
        hdc = temp_hdc = CreateCompatibleDC(0);
    }

Now that only graphics are passed to gdip_format_string later in that function,
either something similar might be needed in gdip_format_string or some
functions need to be decoupled.

[Bug 56345] EA app installer has no text

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56345

--- Comment #2 from Esme Povirk  ---
I think my preference here is that we replace the unwieldy
format_string_callback argument list with a struct, and add an hdc field back
to the struct.

[Bug 56345] EA app installer has no text

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56345

--- Comment #3 from Esme Povirk  ---
Sent https://gitlab.winehq.org/wine/wine/-/merge_requests/5144

[Bug 56345] EA app installer has no text

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56345

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c37fea89e6202e82e91d6af75f9
                   |                            |4441a76a9c130
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Andrey Gusev  ---
Fixed by
https://source.winehq.org/git/wine.git/commit/c37fea89e6202e82e91d6af75f9444...

[Bug 56345] EA app installer has no text

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56345

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 9.4.