https://bugs.winehq.org/show_bug.cgi?id=42863
Bug ID: 42863 Summary: winexy: Creates invalid glsl Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs@winehq.org Reporter: leslie_alistair@hotmail.com Distribution: ---
Created attachment 57963 --> https://bugs.winehq.org/attachment.cgi?id=57963 Cutdown log of the error
When running winexy, via stream, the game doesn't display anything.
https://bugs.winehq.org/show_bug.cgi?id=42863
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://store.steampowered.c | |om/app/577740/
https://bugs.winehq.org/show_bug.cgi?id=42863
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |joseph.kucia@gmail.com Summary|winexy: Creates invalid |Multiple games require |glsl |sample_c_lz for cube/array | |textures (Winexy, Witcher | |3, Flame in the Flood)
--- Comment #1 from Józef Kucia joseph.kucia@gmail.com --- This is a known problem. Generally, GLSL doesn't provide a direct equivalent of sample_c_lz for cube, cube array and 2d array textures.
https://bugs.winehq.org/show_bug.cgi?id=42863
Shmerl shtetldik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |shtetldik@gmail.com
--- Comment #2 from Shmerl shtetldik@gmail.com --- (In reply to Józef Kucia from comment #1)
This is a known problem. Generally, GLSL doesn't provide a direct equivalent of sample_c_lz for cube, cube array and 2d array textures.
Is there a method to simulate in some other way?
https://bugs.winehq.org/show_bug.cgi?id=42863
Shmerl shtetldik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42292
https://bugs.winehq.org/show_bug.cgi?id=42863
tokktokk fdsfgs@krutt.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs@krutt.org
https://bugs.winehq.org/show_bug.cgi?id=42863
mirh mirh@protonmail.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mirh@protonmail.ch
https://bugs.winehq.org/show_bug.cgi?id=42863
--- Comment #3 from Józef Kucia joseph.kucia@gmail.com --- *** Bug 43134 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=42863
--- Comment #4 from Józef Kucia joseph.kucia@gmail.com --- *** Bug 43130 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=42863
--- Comment #5 from Józef Kucia joseph.kucia@gmail.com --- *** Bug 43132 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=42863
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=43131
https://bugs.winehq.org/show_bug.cgi?id=42863
--- Comment #6 from Józef Kucia joseph.kucia@gmail.com --- Created attachment 58404 --> https://bugs.winehq.org/attachment.cgi?id=58404 sample_c_lz hack
https://bugs.winehq.org/show_bug.cgi?id=42863
Simon Bolokanov sbolokanov@abv.bg changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sbolokanov@abv.bg
https://bugs.winehq.org/show_bug.cgi?id=42863
Anthony Jagers noonetinone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |noonetinone@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=42863
Ivan Set s.i.v.892@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |s.i.v.892@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=42863
Martin Procházka solow.trololo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |solow.trololo@gmail.com
--- Comment #7 from Martin Procházka solow.trololo@gmail.com --- Any chance we will see this patch in next wine or wine-staging?
https://bugs.winehq.org/show_bug.cgi?id=42863
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #8 from winetest@luukku.com --- (In reply to Martin Procházka from comment #7)
Any chance we will see this patch in next wine or wine-staging?
I highly doubt it that it will go into upstream since they try to prevent hacks.
https://bugs.winehq.org/show_bug.cgi?id=42863
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=42863
Guillaume Charifi guillaume.charifi@sfr.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |guillaume.charifi@sfr.fr
--- Comment #9 from Guillaume Charifi guillaume.charifi@sfr.fr --- (In reply to Józef Kucia from comment #1)
This is a known problem. Generally, GLSL doesn't provide a direct equivalent of sample_c_lz for cube, cube array and 2d array textures.
It's probably just plain wrong, but can't it be simulated by dot(textureGather(sampler, pos, refZ), vec4(0.25)) ?
https://bugs.winehq.org/show_bug.cgi?id=42863
--- Comment #10 from Matteo Bruni matteo.mystral@gmail.com --- (In reply to Guillaume Charifi from comment #9)
It's probably just plain wrong, but can't it be simulated by dot(textureGather(sampler, pos, refZ), vec4(0.25)) ?
Well, that's certainly incorrect in general. Weighting the four samples appropriately would be okay for the linear interpolation magnification case. That still leaves out the other cases though.
Another workaround could be to use an ad-hoc sampler or texture view overriding the texture levels / LOD to just enable level 0. It doesn't sound too appealing though, it would probably require some quite invasive and ugly changes to wined3d and the additional sampler / texture view would have to be used only for sample_c_lz i.e. we would waste a texture unit if the texture is also sampled without _lz in the same shaders. Not sure there are other realistic options though.
I don't know if Józef has already given some thought about a sensible fix.
https://bugs.winehq.org/show_bug.cgi?id=42863
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/wined3d-sample | |_c_lz CC| |dmitry@baikal.ru, | |erich.e.hoover@wine-staging | |.com, michael@fds-team.de, | |sebastian@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=42863
--- Comment #11 from Matteo Bruni matteo.mystral@gmail.com --- Ah, I guess textureGrad() with a sensible gradient would also work (i.e. something like the staging patch).
https://bugs.winehq.org/show_bug.cgi?id=42863
Daniel Oom oom.daniel@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |oom.daniel@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=42863
Ker noa blue-t@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |blue-t@web.de
--- Comment #12 from Ker noa blue-t@web.de --- With 2.18-staging i get err:d3d:wined3d_debug_callback 0xa20c110: "0:154(9): error: no function with name 'shadowCubeGrad'".
Where should that come from?
https://bugs.winehq.org/show_bug.cgi?id=42863
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|42292 |
https://bugs.winehq.org/show_bug.cgi?id=42863
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |ce8610cea58ed1ba9d8f17857e5 | |07d9d6c30132d Resolution|--- |FIXED Status|STAGED |RESOLVED
--- Comment #13 from Józef Kucia joseph.kucia@gmail.com --- Fixed by commit ce8610cea58ed1ba9d8f17857e507d9d6c30132d
https://bugs.winehq.org/show_bug.cgi?id=42863
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 2.21.