[Bug 58423] New: Flickering in games using dxvk/vkd3d-proton on sway

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58423

Bug ID: 58423
           Summary: Flickering in games using dxvk/vkd3d-proton on sway
           Product: Wine
           Version: 10.11
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: winewayland
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Bisected to
https://gitlab.winehq.org/wine/wine/-/commit/de0fc7fd95074cfdeb032d36246c562...

Games using Vulkan flicker when the compositor supports explicit sync and it is
active after the commit mentioned above.

Disabling explicit sync in sway with `export WLR_RENDER_NO_EXPLICIT_SYNC=1`
makes the game window not flicker even with the bad commit.

[Bug 58423] Flickering in games using dxvk/vkd3d-proton on sway

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58423

--- Comment #1 from [e-mail] ---
Not calling `set_client_surface` from `wayland_vulkan_surface_presented` fixes
the issue with no obvious regressions

[Bug 58423] Flickering in games using dxvk/vkd3d-proton on sway

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58423

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |regression
    Regression SHA1|                            |de0fc7fd95074cfdeb032d36246
                   |                            |c56247d2bd82b
           Severity|major                       |normal

--- Comment #2 from Ken Sharp  ---
Neither DXVK nor vkd3d-proton is supported here. Is there an issue with vanilla
Wine?

CC: Rémi (commit author)

[Bug 58423] Flickering in games using dxvk/vkd3d-proton on sway

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58423

--- Comment #3 from [e-mail] ---
(In reply to Ken Sharp from comment #2)
> Neither DXVK nor vkd3d-proton is supported here. Is there an issue with
> vanilla Wine?
>
> CC: Rémi (commit author)

Yes, it is. The problem is on the end where Wine interacts with the Wayland
compositor, not where Wine interacts with the Win32 application. It doesn't
have to be dxvk or vkd3d-proton, it just needs to use vulkan. I can't test
opengl because I don't have a proper test client, but I'd expect that is
affected too.

I think the flickering is a sway/wlroots bug, but what wine is doing here is
not sane at all. It's destroying and recreating subsurfaces on every present,
even on compositors that handle it without flickers, doing so results in
degraded performance.

[Bug 58423] Flickering in games using dxvk/vkd3d-proton on sway

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58423

--- Comment #4 from Rémi Bernon  ---
Created attachment 78868
  --> http://bugs.winehq.org/attachment.cgi?id=78868
Tentative fix

Thanks for the report, does this help?

[Bug 58423] Flickering in games using dxvk/vkd3d-proton on sway

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58423

--- Comment #5 from [e-mail] ---
That patch results in a blackscreen, with absolutely no updates in
WAYLAND_DEBUG=1 logging

[Bug 58423] Flickering in games using dxvk/vkd3d-proton on sway

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58423

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78868|0                           |1
        is obsolete|                            |

--- Comment #6 from Rémi Bernon  ---
Created attachment 78871
  --> http://bugs.winehq.org/attachment.cgi?id=78871
Tentative fix

Sorry, this might be better?

[Bug 58423] Flickering in games using dxvk/vkd3d-proton on sway

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58423

--- Comment #7 from [e-mail] ---
Yep, that fixes the issue. Thanks

[Bug 58423] Flickering in games using dxvk/vkd3d-proton on sway

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58423

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |c756ea4e801d7eae32bc8a00efa
                   |                            |26fc0f0f47819
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #8 from Rémi Bernon  ---
Should be fixed with c756ea4e801d7eae32bc8a00efa26fc0f0f47819