[Bug 34034] New: Locale settings broke shader program generator.

http://bugs.winehq.org/show_bug.cgi?id=34034

Bug #: 34034
           Summary: Locale settings broke shader program generator.
           Product: Wine
           Version: 1.6-rc4
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: opengl
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

I've encountered today shader program compilation problems. The error is in
following line:
PARAM yv12_coef = {0,666667, 0,166667, 0,833333, 0,333333};

This program was generated by wine itself: in arb_program_shader.c by code:
shader_addline(buffer, "PARAM yv12_coef = {%f, %f, %f, %f};\n", 2.0f / 3.0f,
1.0f / 6.0f, (2.0f / 3.0f) + (1.0f / 6.0f), 1.0f / 3.0f);

The problem is that in polish locale (and others probably to), decimal
separator is a comma not a dot.

The shader_(v)addline should use "C" locale for program generations (best) or
this line above should have %f replaced by counted values.

[Bug 34034] Locale settings broke shader program generator.

http://bugs.winehq.org/show_bug.cgi?id=34034

--- Comment #1 from Ken Sharp  2013-07-13 17:27:38 CDT ---
What is the application?
http://www.winehq.org/docs/wineusr-guide/bug-reporting

[Bug 34034] Locale settings broke shader program generator.

http://bugs.winehq.org/show_bug.cgi?id=34034

--- Comment #2 from Konrad Rzepecki  2013-07-14 12:05:48 CDT ---
GTA III SA from steam, but IT DOESN'T MATTER. I show exactly point where it's,
and why it's a bug.

[Bug 34034] Locale settings broke shader program generator.

http://bugs.winehq.org/show_bug.cgi?id=34034

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|opengl                      |directx-d3d

--- Comment #3 from Henri Verbeet  2013-07-15 02:51:20 CDT ---
We should probably move shader_glsl_ftoa() to the common code and use it in
arb_program_shader.c as well. Ideally we wouldn't need to use the ARB_program
code for blitting when GLSL is used though.

[Bug 34034] Locale settings broke shader program generator.

http://bugs.winehq.org/show_bug.cgi?id=34034

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |b73464a41337992c612e1403537
                   |                            |5c0da70d7eb36
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Henri Verbeet  2013-11-21 12:01:21 CST ---
I believe this should be fixed by commit
b73464a41337992c612e14035375c0da70d7eb36. Please reopen if that's not the case.

[Bug 34034] Locale settings broke shader program generator.

http://bugs.winehq.org/show_bug.cgi?id=34034

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2013-11-22 12:51:12 CST ---
Closing bugs fixed in 1.7.7.

[Bug 34034] Locale settings broke shader program generator.

https://bugs.winehq.org/show_bug.cgi?id=34034

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.6.x

[Bug 34034] Locale settings broke shader program generator.

https://bugs.winehq.org/show_bug.cgi?id=34034

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.6.x                       |---

--- Comment #6 from Alexandre Julliard  ---
Removing 1.6.x milestone from bugs included in 1.6.2.