[Bug 25456] New: ws2_32:sock tests fail for nearly everyone

http://bugs.winehq.org/show_bug.cgi?id=25456

Summary: ws2_32:sock tests fail for nearly everyone
           Product: Wine
           Version: 1.3.8
          Platform: x86
               URL: http://test.winehq.org/data/a6bfa0dd5d0a3ce3c6bd622224
                    53953467275cc5/wine_ae-ub1004/ws2_32:sock.html
        OS/Version: Linux
            Status: NEW
          Keywords: download, source
          Severity: minor
          Priority: P2
         Component: winsock
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=32401)
 --> (http://bugs.winehq.org/attachment.cgi?id=32401)
+winsock

Apparently AJ's machine is magical, but for everyone else on test.winehq.org,
these test fail:
sock.c:3977: Test failed: Waiting for connect event failed with 258 + errno 997
sock.c:3980: Test failed: Connecting to a disconnected host returned error 0 -
996

I suspect it may be a race, since, for instance,
http://test.winehq.org/data/32bbb0bbcfed7591fe2adcf39a2ccf905cbc7027/index_W...
works for everyone, but
http://test.winehq.org/data/b1b485e65cb6e151979e094fbb1c6bd82af5356d/index_W...
has several failures. This was a release day, the first test result was the
last 'real' commit.

I've attached a +winsock trace of the failure.

[Bug 25456] ws2_32:sock tests fail for nearly everyone

http://bugs.winehq.org/show_bug.cgi?id=25456

--- Comment #1 from Mike Kaplinskiy  2011-01-16 14:55:39 CST ---
Created an attachment (id=32875)
 --> (http://bugs.winehq.org/attachment.cgi?id=32875)
possible fix

Looks like it's a kernel change. For some reason when connect() fails we get
POLLOUT|POLLERR|POLLHUP which confuses the server network handling. See if this
helps.

[Bug 25456] ws2_32:sock tests fail for nearly everyone

http://bugs.winehq.org/show_bug.cgi?id=25456

--- Comment #2 from Austin English  2011-01-16 16:15:57 CST ---
(In reply to comment #1)
> Created an attachment (id=32875)

--> (http://bugs.winehq.org/attachment.cgi?id=32875) [details]
> possible fix
>
> Looks like it's a kernel change. For some reason when connect() fails we get
> POLLOUT|POLLERR|POLLHUP which confuses the server network handling. See if this
> helps.

Looks good here :-).

[Bug 25456] ws2_32:sock tests fail for nearly everyone

http://bugs.winehq.org/show_bug.cgi?id=25456

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Austin English  2011-01-24 12:41:15 CST ---
Fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=f58c709b5f82ec6c850a72...

[Bug 25456] ws2_32:sock tests fail for nearly everyone

http://bugs.winehq.org/show_bug.cgi?id=25456

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2011-02-04 13:20:35 CST ---
Closing bugs fixed in 1.3.13.