[Bug 29847] New: comctl32: Sliders of disabled trackbars are rendered the same as enabled ones

http://bugs.winehq.org/show_bug.cgi?id=29847

Bug #: 29847
           Summary: comctl32: Sliders of disabled trackbars are rendered
                    the same as enabled ones
           Product: Wine
           Version: 1.4-rc1
          Platform: x86-64
               URL: http://www.winuae.net/files/InstallWinUAE2330.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Sliders of disabled trackbar controls should be rendered differently from the
non-disabled state, to indicate that the control is disabled. However with
Wine's built-in comctl32, disabled trackbars are rendered identically to
enabled ones. There is no visual indication that the slider cannot be moved.

To demonstrate, download and run WinUAE. When the settings window opens, click
"CPU and FPU" in the treeview on the left. The sliders in the CPU Emulation
Speed area are disabled. Click the "Adjustable between CPU and chipset" radio
button to enable them. There is no change in how the sliders are rendered.

Enable native comctl32 (winetricks comctl32) and run WinUAE again. Disabled
sliders are rendered with a cross-hatch white/grey pattern. Clicking the radio
button to enable the trackbars renders the sliders all grey, indicating that
the user can adjust them.

Using built-in comctl32: http://bugs.winehq.org/attachment.cgi?id=38738
Using native comctl32: http://bugs.winehq.org/attachment.cgi?id=38739

[Bug 29847] comctl32: Sliders of disabled trackbars are rendered the same as enabled ones

http://bugs.winehq.org/show_bug.cgi?id=29847

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #1 from Nikolay Sivov  2012-02-09 10:50:20 CST ---
Yes, I can confirm this. Should be trivial to fix, I'll take a look.

[Bug 29847] comctl32: Sliders of disabled trackbars are rendered the same as enabled ones

http://bugs.winehq.org/show_bug.cgi?id=29847

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 29847] comctl32: Sliders of disabled trackbars are rendered the same as enabled ones

http://bugs.winehq.org/show_bug.cgi?id=29847

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #2 from Nikolay Sivov  2013-05-08 02:18:03 CDT ---
Thumb drawing should be done differently, it's not just about filling colour
but all edges don't look properly. I'm working on that.

[Bug 29847] comctl32: Sliders of disabled trackbars are rendered the same as enabled ones

http://bugs.winehq.org/show_bug.cgi?id=29847

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source

--- Comment #3 from Nikolay Sivov  2013-05-10 07:50:05 CDT ---
WinUAE uses EnableWindow to disable sliders but the thing is that there's no
style change messages in this case so we don't update stored window style.

After commit 2248cfbb6b24bcbb75369028d838ab1166eda539 and patch
http://www.winehq.org/pipermail/wine-patches/2013-May/124102.html that I just
sent it works properly. I'll still need to fix painting of thumb itself but
that's a separate issue.

[Bug 29847] comctl32: Sliders of disabled trackbars are rendered the same as enabled ones

http://bugs.winehq.org/show_bug.cgi?id=29847

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |2248cfbb6b24bcbb75369028d83
                   |                            |8ab1166eda539
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Nikolay Sivov  2013-05-10 13:18:56 CDT ---
This is fixed with 2248cfbb6b24bcbb75369028d838ab1166eda539 and
2620e3cbe079bc4b7d974a4c32b4b0b2b527f6d1.

[Bug 29847] comctl32: Sliders of disabled trackbars are rendered the same as enabled ones

http://bugs.winehq.org/show_bug.cgi?id=29847

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2013-05-10 13:42:17 CDT ---
Closing bugs fixed in 1.5.30.

[Bug 29847] comctl32: Sliders of disabled trackbars are rendered the same as enabled ones

https://bugs.winehq.org/show_bug.cgi?id=29847

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]