http://bugs.winehq.org/show_bug.cgi?id=14367
Summary: revise stack-frame relay code never to touch other side of stack pointer Product: Wine Version: 1.0.0 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: jreiser@BitWagon.com
Created an attachment (id=14664) --> (http://bugs.winehq.org/attachment.cgi?id=14664) always avoid memory on wrong side of stack pointer
The code which relays stack frames from one calling sequence to another can be written never to touch memory that lies on the undefined side of the current stack pointer. Even though in normal cases there may be no danger in referencing below the stack pointer (because of precautions with alternate signal stack, etc.), it is more robust to avoid this. Debuggers (both code and human) and other tools may be unaware of the special precautions, or may find it impossible to comply. Patch is attached, and will be sent to wine-patches@winehq.org.
http://bugs.winehq.org/show_bug.cgi?id=14367
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #1 from Austin English austinenglish@gmail.com 2009-01-05 11:13:12 --- Is this still an issue in current (1.1.12 or newer) wine? Would you mind resubmitting the patch and asking for comments?
http://bugs.winehq.org/show_bug.cgi?id=14367
--- Comment #2 from Austin English austinenglish@gmail.com 2009-07-16 13:11:19 --- Probably still present.
http://bugs.winehq.org/show_bug.cgi?id=14367
--- Comment #3 from Austin English austinenglish@gmail.com 2010-05-19 14:51:14 --- Probably still present.
http://bugs.winehq.org/show_bug.cgi?id=14367
--- Comment #4 from Austin English austinenglish@gmail.com 2012-03-19 14:02:48 CDT --- Still present.
https://bugs.winehq.org/show_bug.cgi?id=14367
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
https://bugs.winehq.org/show_bug.cgi?id=14367
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
--- Comment #5 from Sebastian Lackner sebastian@fds-team.de --- Still present in 1.7.36.
The original patch doesn't apply anymore, but this cleaned up and improved version should do basically the same:
https://github.com/wine-compholio/wine-staging/tree/master/patches/winebuild...
https://bugs.winehq.org/show_bug.cgi?id=14367
--- Comment #6 from Sebastian Lackner sebastian@fds-team.de --- Patch was submitted to the mailing list: http://source.winehq.org/patches/data/109332
https://bugs.winehq.org/show_bug.cgi?id=14367
--- Comment #7 from Sebastian Lackner sebastian@fds-team.de --- Patch was accepted, should be fixed with: http://source.winehq.org/git/wine.git/patch/44fbc018eda12bdee5c2c1e2e40dbdc6...
https://bugs.winehq.org/show_bug.cgi?id=14367
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |44fbc018eda12bdee5c2c1e2e40 | |dbdc6a81b27fd Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #8 from Austin English austinenglish@gmail.com --- (In reply to Sebastian Lackner from comment #7)
Patch was accepted, should be fixed with: http://source.winehq.org/git/wine.git/patch/ 44fbc018eda12bdee5c2c1e2e40dbdc6a81b27fd
Fixed.
https://bugs.winehq.org/show_bug.cgi?id=14367
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.38.